From patchwork Mon Jul 3 21:15:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Acayan X-Patchwork-Id: 42420 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:3b1e:b0:12b:9ae3:586d with SMTP id c30csp4666194pzh; Mon, 3 Jul 2023 15:21:36 -0700 (PDT) X-Google-Smtp-Source: APBJJlHK1W7Jm7RYUP7yCq2OYscDa2N4GJzF0V0voKGjjzvgcvvTmXiwdslpPO6jgzP1NaZTynqz X-Received: by 2002:a05:6512:360a:b0:4f7:55e4:4665 with SMTP id f10-20020a056512360a00b004f755e44665mr6798708lfs.56.1688422895982; Mon, 03 Jul 2023 15:21:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688422895; cv=none; d=google.com; s=arc-20160816; b=mQFF0h0kic7zV9mK2f0T4xTyRYkr80SMVS6ZHR9OXHAn/muWUOB8b9Gf9vZd6DOT6w TaVpv0jRoaWd9dZVHffgrMlkNu2uHPKxDqySj2uh3ItOakgL/RV3XVViKNTgyicZ2sIf 9sZfyVOzXeA8BeJORht8MtqB7cU7P1VbLffke3efXm9qKREp/l0nPmGIptbx1Heel4wz Qcr0ZnxBEBxENxDqYSHS6TFk+992iqupm0ruDhOxr1ni7YD30+8FhEAjSeW7X01M9z0d YCsAN6YYQh9nhJsLKNt+1a3Y5XB357ObxD+S0Zouy/xXnbnuZNaHHKEL1OEWixfTHhMQ h+3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :resent-to:resent-message-id:resent-date:resent-from:dkim-signature :delivered-to; bh=aXBJMxGd0cBwSwjHo8Yt2S18yxP2+FYzf2dz4UPyK4U=; fh=D+T3jGauzEsH3XliIYO9oSx4f1jC1gG8TsATWgY4mx0=; b=XTtmKBLDAu4+VaukjLi7LnD2n+Ja0ReEOaNuusiuxhW4fs6Uf9lb30XHxfSW/4eH3a nEcQxWwiEpl2mnIrgiGgXAV3rtSMEw7qsF38ir53iCt7k9KS/oSemFJHuXtw0nBGrqw3 Het/d0kBWN6ac4+fDa4/Cm9qMzSbMvnP6r0PD2okDZWtwDS7aPvuQ/yMUF8jkMnDJ+xX aX1zuwlb0GR9wplqVwqXqsJzqFUiq3aHrN9YDDZnXMC3lTnNBj6nJaOihhT/1St/qR3A nbHH6lD8JAms2/Frr+kVVHpqq7OuYmusPuv/OG/bNhdVztr3oXZQ+J6+YW9M/HQcp9SV WFmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20221208 header.b=jtyZJyfc; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id l6-20020a056402124600b0051e04e2e4b7si2992254edw.168.2023.07.03.15.21.35; Mon, 03 Jul 2023 15:21:35 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20221208 header.b=jtyZJyfc; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A2C4D68C5A2; Tue, 4 Jul 2023 01:21:32 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EC05D68C5A2 for ; Tue, 4 Jul 2023 01:21:25 +0300 (EEST) Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-4033b79287cso34036581cf.1 for ; Mon, 03 Jul 2023 15:21:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688422884; x=1691014884; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:resent-to:resent-message-id:resent-date:resent-from:from:to :cc:subject:date:message-id:reply-to; bh=c9RbE1RpNP6V9cJ29iFty6veB/Yh7KHZ7AHgbFvs7D0=; b=jtyZJyfcmyQ++u+ERSlyqZZAuovDmjLQjck7Be+mnvAIs1fr7Ns/yAg1A1m+5TiiHx F0Tgnqcea3mXApFCGIdXedeO6iR0ygjeoy4iJIZy52CNJO+ecEAZBv2Lf8FyustS84sR TDitpZNn4I+ddix6QWvSAFGSj8mHXeABBafWa4nKxvipBaKrPybZSrhyz9G4K3KnCxis /ToOMz//BY1sJ1JXjFNGKBnaDCXyuU1eQ6hJ5WuUVBFfv5Cpnj4YUjlU+Ky9oydrQYkp lOHPE8g8+P42tqcmNBxXmNXTSu7jaWLENkRWRLYK/MBQbUVaPTuRDI6yrj94cVmVynXY V3GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688422884; x=1691014884; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:resent-to:resent-message-id:resent-date:resent-from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c9RbE1RpNP6V9cJ29iFty6veB/Yh7KHZ7AHgbFvs7D0=; b=db2vUEeib7cQKpUqG6Hebw70pYo6x2u6cOeIwsr4OcvYZeG+AHtdhUOVH+WvU6djPq JCYect874ujiNuuU3bs2Q97vGmlB6vxDQfZx7rH0ZILm7WAuhYPVsUy58hyr8J3SLiwS I3tBRZ+SpLCbAA/qBPcYTrn4BQwyXPjxO1+eNehpLxOQCoOlo+TDbC/ROFeQ84gHyedL 1U9h1lV3oEvXu9FtCGPdZkzYzvmNCIv2dHEOXwQ16DU1XuHEu59IBD3UaT06s74oNBTF MKQ9+W5J7sdwjE09+W1cdms/gLv+hge5eXR/168NgcDi61yENlsxHMMdMwvEcmmIZx8z ZRRQ== X-Gm-Message-State: AC+VfDwoTkoWcWLVS18LHB503oV4vST1QYmlf1nmU7njZLS9kmUG8vyx bCx4xaIM1e0bRqoj4D11XUG8B5QLS6sDMw== X-Received: by 2002:a05:622a:189b:b0:400:880a:51bf with SMTP id v27-20020a05622a189b00b00400880a51bfmr13906252qtc.33.1688422884136; Mon, 03 Jul 2023 15:21:24 -0700 (PDT) Received: from localhost ([2607:fea8:529d:4d00::30df]) by smtp.gmail.com with ESMTPSA id d30-20020ac800de000000b003f38aabb88asm3182825qtg.20.2023.07.03.15.21.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 15:21:23 -0700 (PDT) Resent-From: Richard Acayan Resent-Date: Mon, 3 Jul 2023 18:21:22 -0400 Resent-Message-ID: Resent-To: ffmpeg-devel@ffmpeg.org Received: from localhost ([2607:fea8:529d:4d00::30df]) by smtp.gmail.com with ESMTPSA id c7-20020a25bbc7000000b00c39e3d75bfcsm2418240ybk.44.2023.07.03.14.15.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 14:15:27 -0700 (PDT) From: Richard Acayan To: ffmpeg-devel@ffmpeg.org Date: Mon, 3 Jul 2023 17:15:10 -0400 Message-ID: <20230703211510.255629-1-mailingradian@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avcodec/v4l2_context: always log POLLERR when buffers are uninitialized X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Richard Acayan Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: i1vvJ9b27S+Q The error handler for POLLERRs assumes that the timeout is only zero when v4l2_dequeue_v4l2buf is called by v4l2_getfree_v4l2buf. This assumption is incorrect, as ff_v4l2_context_dequeue_frame also calls this function with a timeout of zero. Do not check for unavailable buffers if the buffers are uninitialized. See https://trac.ffmpeg.org/ticket/9957 for the original bug report. Signed-off-by: Richard Acayan --- libavcodec/v4l2_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_context.c index a40be94690..69ddf80723 100644 --- a/libavcodec/v4l2_context.c +++ b/libavcodec/v4l2_context.c @@ -327,7 +327,7 @@ start: if (pfd.revents & POLLERR) { /* if we are trying to get free buffers but none have been queued yet no need to raise a warning */ - if (timeout == 0) { + if (timeout == 0 && ctx->buffers) { for (i = 0; i < ctx->num_buffers; i++) { if (ctx->buffers[i].status != V4L2BUF_AVAILABLE) av_log(logger(ctx), AV_LOG_WARNING, "%s POLLERR\n", ctx->name);