From patchwork Sat Jul 15 23:58:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Almer X-Patchwork-Id: 42749 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:6da1:b0:131:a7d0:bc6d with SMTP id gl33csp4568650pzb; Sat, 15 Jul 2023 16:58:52 -0700 (PDT) X-Google-Smtp-Source: APBJJlGXa+kMpUgUq6RtCJxNWJtrQqBGjHuPq6Te3fk5u8K2hxxnMjlgRENyHCx13MNeravuPKRi X-Received: by 2002:a17:907:601f:b0:97d:9b73:690b with SMTP id fs31-20020a170907601f00b0097d9b73690bmr6946875ejc.59.1689465531984; Sat, 15 Jul 2023 16:58:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689465531; cv=none; d=google.com; s=arc-20160816; b=L+fOaquctl5ZbooUUoU3RtvJZWyHI+Mlaz1yLtngEO+ZC4tuzrkq5Kky+iU7uHzDd2 ZomeGy18tPs3qepVZzmOoKnLLDofBopaWSdURs8Q5SNHK6IOieXFz9b7TMdvCBXwqWXz XrXUUw+/fwkkIVSNmtFJu0Vh6o+k0MnpJlHRPVM6PgVgEVvEZKiCUX4FF+R9/grvmD+l 4xk0+6JujDymoUYLakzRHd2sEU58uhC1YtVQ2iOAf5TDr3xFVObwSh+BFbPsUHXMKnZa FpYXIP+eLPCDmqdo2keNnS9SBE1QULFimejFaIQgKriCcJ3Wb2ARGZ7hkDeTfmukXKBS 7GMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=NcAYEPLRvIr4Xrj5A+bBX8qO17tM4/rcsBZFWjY9qco=; fh=J3zlMo7rVW2t2IQYogliBcMNuBh6YQg7NRChcrschf4=; b=ICRmzsmXJ2N9ryXcRiWE2iHWLWB1kw4yISWG5uNGGIMUahFqGE18j0WOt98pttAFMi Izkjsyig6VTCxad62UGidWXx9OhyVc38F1AuSfQBfaD3IlViejqAyV9PkKVhio2EV5lr J8RNh1r33HKobxF5WcsW/EwjXsJ9sUz0QvvN9k+HBhxhivcb2eoOVuyAafEbo0ScxODP NBJhRzNtWOoOqBfAAPVp2ZisghKCVi+ql0MyGwvFKAZPT/u+eS8+4y4NEt6Ea0HV1THn izhQM6PiQ/IGGdYjRbVAEy32P2HFeB0LgpGy+9FoIMXn3hKhdCv5/ghe3ZZIMlI2aUaM mkhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20221208 header.b=rQrbXASE; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id gq8-20020a170906e24800b00988a9273633si2216466ejb.344.2023.07.15.16.58.51; Sat, 15 Jul 2023 16:58:51 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20221208 header.b=rQrbXASE; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E74A968C5C3; Sun, 16 Jul 2023 02:58:46 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CBBCE68C570 for ; Sun, 16 Jul 2023 02:58:39 +0300 (EEST) Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-6b9c90527a0so596648a34.1 for ; Sat, 15 Jul 2023 16:58:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689465517; x=1692057517; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=qBDBrWUHLSlYaH2u+8+4grJbuDLU5x00FVZxCpvrjTI=; b=rQrbXASEf79lhJCMnzIPjphdNpTReDj9bmhzcKRNWJrOnhkSftQHO/xSpUJvYs+PY5 32Y1kLlrImtXQtzCIE05RWqB9DhEuj4O3TjwY7/wGcgW8CcDvoElr1zNzIteb3+fRecm hrcnd4IOm0UA+E8iskn1yQu9E2hhkq9fynqAXAnpygRBGtBJ4XI7W6H06KxLM/ISKWmL g94mO8h7t7ie3XilVnI4Fa6/E7TAJef8UPRTe+A8yHNXJcQoGHvELp7N8hulKR/UIpBa 8R7v2swM1E+fjp/m0NcZl9wOsll0J1A3aE1PW3BuJTsgAnnA5U9VNIRoxYLvtRGU4t+m M3hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689465517; x=1692057517; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qBDBrWUHLSlYaH2u+8+4grJbuDLU5x00FVZxCpvrjTI=; b=FST1P/m5tANhrDc0fw9QmNGI2cnIcWQ3Wh7kii8NV+LQOOQ4JY8zsMimPl8mprbWd8 7Qwu2REwjPHpQKanMeFzFyhaLCstEhtQIte4W+0tk1CahrjUmzp+khR90wy2ojnxjiw7 VRaJjlOb0HrhU28IQbd2lcH96GQCZgryD+A43YuTHEKGaThNq1E//NDFLQT/qLhyp+Do H3iSfmX9fl6mckX5ONlWta1DIeLqRWKUArP7R9/I085GgiSW9fr37/mBzaS+HNbu/BSx Gei1CNzB7U8sUT9gWx57x6MNYjkqavXMbroHATusIrdoeQXovXN4yJNiIulDve+tcoyw uWdQ== X-Gm-Message-State: ABy/qLYuS+05VunO3Yo3JCJ0nFjynABqZL8VUGCl4HdVs0ZQKkszMK2x UFUTjKHqsdxgSGRg6LVrigPMAKD2gG0= X-Received: by 2002:a05:6870:5b8f:b0:1b4:5bd9:9fb9 with SMTP id em15-20020a0568705b8f00b001b45bd99fb9mr8513889oab.43.1689465517363; Sat, 15 Jul 2023 16:58:37 -0700 (PDT) Received: from localhost.localdomain (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id dt14-20020a0568705a8e00b001ba72480f2fsm311754oab.43.2023.07.15.16.58.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jul 2023 16:58:37 -0700 (PDT) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Sat, 15 Jul 2023 20:58:32 -0300 Message-ID: <20230715235832.64221-1-jamrial@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avcodec/x86/mathops: use constrained immediate operands X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: YWAACFL7y+8N Should fix assembling with binutil as >= 2.41 Signed-off-by: James Almer --- This is IMO a big breakage. binutil's as has until now clipped these values on its own, and never required the compiler to do it. libavcodec/x86/mathops.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/x86/mathops.h b/libavcodec/x86/mathops.h index 6298f5ed19..a08c6193bf 100644 --- a/libavcodec/x86/mathops.h +++ b/libavcodec/x86/mathops.h @@ -39,7 +39,7 @@ static av_always_inline av_const int MULL(int a, int b, unsigned shift) "imull %3 \n\t" "shrdl %4, %%edx, %%eax \n\t" :"=a"(rt), "=d"(dummy) - :"a"(a), "rm"(b), "ci"((uint8_t)shift) + :"a"(a), "rm"(b), "cI"((uint8_t)shift) ); return rt; } @@ -115,16 +115,17 @@ __asm__ volatile(\ static inline int32_t NEG_SSR32( int32_t a, int8_t s){ __asm__ ("sarl %1, %0\n\t" : "+r" (a) - : "ic" ((uint8_t)(-s)) + : "Ic" ((uint8_t)(-s)) ); return a; } #define NEG_USR32 NEG_USR32 static inline uint32_t NEG_USR32(uint32_t a, int8_t s){ + __asm__ ("shrl %1, %0\n\t" : "+r" (a) - : "ic" ((uint8_t)(-s)) + : "Ic" ((uint8_t)(-s)) ); return a; }