From patchwork Mon Jul 17 18:55:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= X-Patchwork-Id: 42788 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:b813:b0:130:ccc6:6c4b with SMTP id fi19csp31475pzb; Mon, 17 Jul 2023 11:55:17 -0700 (PDT) X-Google-Smtp-Source: APBJJlHMZyvSdM5566wupVhvpe83/FuZirlMvX/EGNiymG7wneWLGxHDspTbuEPl2l983Vnx46DJ X-Received: by 2002:a17:906:2cd:b0:997:c377:b41f with SMTP id 13-20020a17090602cd00b00997c377b41fmr2894947ejk.64.1689620117120; Mon, 17 Jul 2023 11:55:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689620117; cv=none; d=google.com; s=arc-20160816; b=zcDvcSFrxhWXJLCGQsJhPCb43lWK5lA+hbP6ARoW+M9IZOAR5AHqwnCCSUAjigxspk XWRGl852tTSAN53jy/Bpa8oQwwkojNQOJSVIyyfON7rzoVSu2iWeAiS2lwsLTvdJFKYQ jHZtn8HpE4m6j2m+DkFA3WpcxfHw04ikgK3TdvQ3iTveioENj0uUag/g6WJ8eV6BiyPi lcOv1VJgsw68X4vEIEaa2SgFr5+jWwNVdaM/4x7wncGM7DIgaKFlyOS01B3mFY7PeupU CdjGtv5wwLfPkG5BXorSIiwGP4piAKVPXZV0ZlNxZ9en54jDxs8Wr+n6leOCG2lny/nb qAww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=r47uPeJHg7sEAY9ngqsS6kqPcLqgkfbfgSFsoKyVH0Q=; fh=hQcp50obTJ8bXC1it5NuEN23RGKfx0/zZ3s2gmreL+A=; b=cp5ASLdWnmPa+53ngqvJUmQck8RS3k2clDFyMwHyRmJMoGVNXjhxTthjJhODsdMjr3 f/zrvl/y6Cyu8T/gXTtbbLwnttZMDuGofpXjNWA3N4caOa2+0B0ZlSGlvCCMc8+6PWdx vUCfNp2fvOLh/Z70aEIIKtaUqZ1FUl5j52KK5q9rZYstZlUGGGseHXe4Mt9RAen0gCkI q1t50ViLhz5blbr+YnkqkO0eOFJYpghY0LHpRP8vyzz8mpqMbETEyv5ZWReW9HprDNlW ECUZNbq9LBue/1QpE8xaPUp0zUcs42VfcAGDVRS0299OZdAPHWvi983tVjjHHr4uK6nS Q6Nw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id t13-20020a1709063e4d00b00992feae3848si52709eji.38.2023.07.17.11.55.16; Mon, 17 Jul 2023 11:55:17 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5826068C301; Mon, 17 Jul 2023 21:55:12 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from ursule.remlab.net (vps-a2bccee9.vps.ovh.net [51.75.19.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D4B2768BECC for ; Mon, 17 Jul 2023 21:55:05 +0300 (EEST) Received: from basile.remlab.net (localhost [IPv6:::1]) by ursule.remlab.net (Postfix) with ESMTP id 69B0AC0014 for ; Mon, 17 Jul 2023 21:55:05 +0300 (EEST) From: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= To: ffmpeg-devel@ffmpeg.org Date: Mon, 17 Jul 2023 21:55:05 +0300 Message-Id: <20230717185505.32346-1-remi@remlab.net> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCHv2] lavu/float_dsp: rework RISC-V V scalar product X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: KRSq9fUI87/S 1) Take the reductive sum out of the loop, leaving a regular vector addition in the loop. 2) Merge the addition and the multiplication. 3) Unroll. Before: scalarproduct_float_rvv_f32: 832.5 After: scalarproduct_float_rvv_f32: 275.2 --- libavutil/riscv/float_dsp_rvv.S | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavutil/riscv/float_dsp_rvv.S b/libavutil/riscv/float_dsp_rvv.S index 77961b7387..605729b1d4 100644 --- a/libavutil/riscv/float_dsp_rvv.S +++ b/libavutil/riscv/float_dsp_rvv.S @@ -166,20 +166,22 @@ endfunc // a0 = (a0).(a1) [0..a2-1] func ff_scalarproduct_float_rvv, zve32f - vsetivli zero, 1, e32, m1, ta, ma - vmv.s.x v8, zero + vsetvli t0, zero, e32, m8, ta, ma + vmv.v.x v8, zero + vmv.s.x v0, zero 1: - vsetvli t0, a2, e32, m1, ta, ma + vsetvli t0, a2, e32, m8, tu, ma vle32.v v16, (a0) sub a2, a2, t0 vle32.v v24, (a1) sh2add a0, t0, a0 - vfmul.vv v16, v16, v24 + vfmacc.vv v8, v16, v24 sh2add a1, t0, a1 - vfredusum.vs v8, v16, v8 bnez a2, 1b - vfmv.f.s fa0, v8 + vsetvli t0, zero, e32, m8, ta, ma + vfredusum.vs v0, v8, v0 + vfmv.f.s fa0, v0 NOHWF fmv.x.w a0, fa0 ret endfunc