From patchwork Wed Aug 2 00:01:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 43068 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:c11f:b0:130:ccc6:6c4b with SMTP id bh31csp309075pzb; Tue, 1 Aug 2023 17:01:53 -0700 (PDT) X-Google-Smtp-Source: APBJJlHnDbTp0n6A1Ts3dBFAX/S2JfDPIOH0Hdzi0pNylWhtrXIUhG+F5G9H67nT+RAr1pCQ6EB0 X-Received: by 2002:a17:907:78c8:b0:99c:461e:2369 with SMTP id kv8-20020a17090778c800b0099c461e2369mr248299ejc.42.1690934513319; Tue, 01 Aug 2023 17:01:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690934513; cv=none; d=google.com; s=arc-20160816; b=Axfzx3Ym7OLNYX8yRPXFrSdu/KEwJggJiYOp6EYICkUQEP39dkPfwnZAGNgK50v3bA K7A5/t+5V7YmtObzf7pG9hB04viI/geLr9d9mdfvUJOnEppupptVAq3KeRyS+EWA1iaL vq6bctgtmDor6FbnlImLE7Ze1tAyJ/e/e6eOlv28EuGNYrIT4ccM+n1CiJJXncYlsnGR 3i/Srgz0WG/8C3WnpQb1weMQZPax/7Rci4fVpfYQZ9EyUr2SHJmXyiMCgBgeSC9/5lEu gbGgkECa2GcctUYLfzQhNbcOYxk6HLn3wqmtNv7Wd2OfD9RJj/p3C9cyOCZlnR8xRFjB pbiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to; bh=uEtcXo2k2xJUPoeLVm1iUE0XTh7a/XpIFyXz47ESekU=; fh=YYwLYmpaV0Fpw/rxmSKNRLS2XzDkAlGbHATiKOPtZrY=; b=sNtjJhXSLZVHqkXZ8NotmxytTVyTxhxNtNVqWz70DcRdI7FroFD6CInDhLXDfP+P8f ESEgAr9+xEQ1cLAbD4zDgJ7lK/pXTtOqCFVACvJHK7x1EGH5JMfU50EMgwnOtjZs2cZU IA0ww5OJkk8q/a48fmDYKZQycOCx3+PL6Efz6f0nmWGZp+tSoHjxERgOpqCL68byoZs+ e5LNDFY4fquRSr40NhVQL7IolL0D8gspfNR14io9aR218QpulQWZxuOjboPEgNegtkEM Tmq/TT+qXK/dDlrDSj7UarBEhwe1u/grJBaQ7djlVtr3YOXC2Y7UcLrDNtskJnZpV5kt 4i/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id qp27-20020a170907207b00b0099379d3f91esi6599103ejb.477.2023.08.01.17.01.48; Tue, 01 Aug 2023 17:01:53 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6D27668C55E; Wed, 2 Aug 2023 03:01:44 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9ECD568AEC5 for ; Wed, 2 Aug 2023 03:01:37 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 72FC760006 for ; Wed, 2 Aug 2023 00:01:36 +0000 (UTC) From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Wed, 2 Aug 2023 02:01:33 +0200 Message-Id: <20230802000135.26482-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 1/3] avcodec/jpeg2000htdec: Avoid freeing uninitialized pointers in ff_jpeg2000_decode_htj2k() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: G6iWt5f4N+3+ Fixes: freeing of uninitialized pointers Fixes: part of 58299 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/jpeg2000htdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/jpeg2000htdec.c b/libavcodec/jpeg2000htdec.c index 4c4e54710d..2b082b3b2f 100644 --- a/libavcodec/jpeg2000htdec.c +++ b/libavcodec/jpeg2000htdec.c @@ -1174,8 +1174,8 @@ ff_jpeg2000_decode_htj2k(const Jpeg2000DecoderContext *s, Jpeg2000CodingStyle *c int ret; /* Temporary buffers */ - int32_t *sample_buf; - uint8_t *block_states; + int32_t *sample_buf = NULL; + uint8_t *block_states = NULL; int32_t n, val; // Post-processing From patchwork Wed Aug 2 00:01:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 43069 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:c11f:b0:130:ccc6:6c4b with SMTP id bh31csp309148pzb; Tue, 1 Aug 2023 17:02:01 -0700 (PDT) X-Google-Smtp-Source: APBJJlEdEPgXdtUoKOp8Ov7OES7Ti2LJFb7WS9qbl0VVo3///S1IdinVVTkq9ZZ6n4qjJaGeVeWo X-Received: by 2002:adf:cf0e:0:b0:314:dc0:2fca with SMTP id o14-20020adfcf0e000000b003140dc02fcamr3469123wrj.29.1690934521536; Tue, 01 Aug 2023 17:02:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690934521; cv=none; d=google.com; s=arc-20160816; b=NGznXdxj0KO86BQvDVBk4SUXSJGwrCUVCCIpObIC51xNK05xYYqC69ghZONqhyFDGP rm0iW+1vEZ7mgzX3LdTslH4h9qlN8wldHWRgXgpPke9e4+V2a/ClQtDbnyw2MkcYnoYA pIb4e5Z+kJwpk7YxpmPG82BuTt9pLyAbM5tyE3Zosuy48rraQiOuGvLj2vCax3RFFzwn imkQM45b6i4jDLBambWx0OOaEDLBuRitaTG4YQOaH2FsAt2iyAs7JN4rY4PCvHlnnuEH lMvfcYd+8+wWYLYY0rLPnepcsejLoxcwg5e8lNQNd3eImNcQGn7MiUi4dmLUh4A76mHH 1Eiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=PoOIIJsBVLg0jcq7fzxO0uA0OJumbSXQPxqhmshEVhM=; fh=YYwLYmpaV0Fpw/rxmSKNRLS2XzDkAlGbHATiKOPtZrY=; b=S+iRbbT7se1l3+R/TtkSwjrlEOC1Uu/DybYuYjNWhHe6M35rWzYqLVi0JRZmBUMMD4 z114QPS0+NHUpZsHS3J96qEnGHUFPNUjH1MIRoTtHs71QOaPOEFOEp3srN1HxWM/EATc 5i3EZKS2ozhtaOMQZCS95aJtpRwRPZGljkFvgjj8KqQ3ovbZUkBy7qI9mbn3H3jH+8N/ BUMhEdzX4iVsoAzoIic3HZY1VaG/EV0ozBYXA3ZTfXrEdgoXkP3U7B/tpBZRzbLWxBZl 9Wr3acNJokgzcD7C3zXu88nOujS0OIBQpfY1sbTS/EaA2MGMw7/UMJRGECDsVC49t46Q yoSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id d28-20020a056402517c00b00522b93d47c1si4421616ede.448.2023.08.01.17.02.00; Tue, 01 Aug 2023 17:02:01 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 96D7C68C581; Wed, 2 Aug 2023 03:01:45 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 431D468BE6F for ; Wed, 2 Aug 2023 03:01:38 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 7E1CC240002 for ; Wed, 2 Aug 2023 00:01:37 +0000 (UTC) From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Wed, 2 Aug 2023 02:01:34 +0200 Message-Id: <20230802000135.26482-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230802000135.26482-1-michael@niedermayer.cc> References: <20230802000135.26482-1-michael@niedermayer.cc> X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 2/3] avcodec/jpeg2000htdec: Consolidate jpeg2000 spec bits in jpeg2000_bitbuf_refill_backwards() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 7MeuaUZsJfqG Code should make more sense now Fixes: out of array access Fixes: 58299/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-6627570448465920 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/jpeg2000htdec.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/libavcodec/jpeg2000htdec.c b/libavcodec/jpeg2000htdec.c index 2b082b3b2f..3985783f3a 100644 --- a/libavcodec/jpeg2000htdec.c +++ b/libavcodec/jpeg2000htdec.c @@ -159,21 +159,14 @@ static int jpeg2000_bitbuf_refill_backwards(StateVars *buffer, const uint8_t *ar */ position -= 4; - tmp = AV_RB32(&array[position + 1]); - - if (buffer->pos < 4){ - /* mask un-needed bits if we are close to input end */ - uint64_t mask = (1ull << (buffer->pos + 1) * 8) - 1; - tmp &= mask; - } - /** * Unstuff bits. Load a temporary byte, which precedes the position we * currently at, to ensure that we can also un-stuff if the stuffed bit is * the bottom most bits. */ - tmp <<= 8; - tmp |= array[buffer->pos + 1]; + + for(int i = FFMAX(0, position + 1); i <= buffer->pos + 1; i++) + tmp = 256*tmp + array[i]; if ((tmp & 0x7FFF000000) > 0x7F8F000000) { tmp &= 0x7FFFFFFFFF; From patchwork Wed Aug 2 00:01:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 43070 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:c11f:b0:130:ccc6:6c4b with SMTP id bh31csp309252pzb; Tue, 1 Aug 2023 17:02:12 -0700 (PDT) X-Google-Smtp-Source: APBJJlEIdTo7D2mrhvpT8idUZVGfqYSiYb5fIbhdJpwCOdf05EHQ68aqURt/5o7MTRbBUzTS+dgg X-Received: by 2002:a17:906:53ce:b0:989:34a0:45b0 with SMTP id p14-20020a17090653ce00b0098934a045b0mr3991577ejo.49.1690934532402; Tue, 01 Aug 2023 17:02:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690934532; cv=none; d=google.com; s=arc-20160816; b=vovFD8U1fkpsKufc+J5dOVQp1cEaEnqyJLmZ04ZbJ/wcynzLrxarq/DLHRPg36zWbg ryE0AX3u3M/uiOOR6fH9YO89E0hx6F7AE/fJtT4X1GU1C4NSVHp1oRQrnPF7E74Y9yy5 TSBI84CVUNObk4yWK4UojtK0S6UkkZkuhxvMEGHxkvczxmV5h0xlYqPEz2pwsrBjB5Bw +adWVPLuFJmoFIZNJ+sqz2lHZH4x8qBYIRCME0ZGFyLnjK0eVnXOHROgoRacqfVWYAJ/ ofkkfKzMsLohuXXn1/WC8k8r8CmEdkLVeEY1DAG8K7AbFaa+0aEkNplhGZWkFfewVpwE TKQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=e5+g1hV+Bz8UlZNf5tBAycSOSCBWagP2v18bnp6tK98=; fh=YYwLYmpaV0Fpw/rxmSKNRLS2XzDkAlGbHATiKOPtZrY=; b=BxvxhtZjLwez/wZVHaDFTDWOlZeRqq6QoMVTxqmF+cesURTQzalX7fV5i3oukZCYIo U7wrVXfZE3lXdL1cFFy3vfoTP93N3uFOq5oxnV/I/XPfJFMo9Q/yPmeydJXYLMguyJ6G MMurg/GynjXEnAqMyWH6k58MusOHOBoun87+NJGqnt0hOuNmVVZhfFP6tmnx4ywBP6SK YklrlX16y5cUCSfIsM79iymyxfmg9ik74mOXqJjPxvQoMqupznkpJQqX2RbyWR5+MJYW qoxh0XaCbsVemugNBHJJ87DUKs8ujUQ61XBLjnem9z08G7bpA4qDDA6rto7AUPVYbcT1 y/Hg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id n19-20020a170906165300b00992e51fe33bsi5338893ejd.118.2023.08.01.17.02.11; Tue, 01 Aug 2023 17:02:12 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B7BBB68C58E; Wed, 2 Aug 2023 03:01:46 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2D1E968C52B for ; Wed, 2 Aug 2023 03:01:39 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 754CD20003 for ; Wed, 2 Aug 2023 00:01:38 +0000 (UTC) From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Wed, 2 Aug 2023 02:01:35 +0200 Message-Id: <20230802000135.26482-3-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230802000135.26482-1-michael@niedermayer.cc> References: <20230802000135.26482-1-michael@niedermayer.cc> X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 3/3] avcodec/jpeg2000htdec: Check m X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: +iXDqNZL0WQj This also fixes assertion failures Fixes: shift exponent 95 is too large for 64-bit type 'unsigned long long' Fixes: 58299/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5828618092937216 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/jpeg2000htdec.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/libavcodec/jpeg2000htdec.c b/libavcodec/jpeg2000htdec.c index 3985783f3a..ae2ee6d6ee 100644 --- a/libavcodec/jpeg2000htdec.c +++ b/libavcodec/jpeg2000htdec.c @@ -689,6 +689,10 @@ static int jpeg2000_decode_ht_cleanup_segment(const Jpeg2000DecoderContext *s, for (int i = 0; i < 4; i++) { m[J2K_Q1][i] = sigma_n[4 * q1 + i] * U[J2K_Q1] - ((emb_pat_k[J2K_Q1] >> i) & 1); m[J2K_Q2][i] = sigma_n[4 * q2 + i] * U[J2K_Q2] - ((emb_pat_k[J2K_Q2] >> i) & 1); + if (m[J2K_Q1][i] > 63 || m[J2K_Q2][i] > 63) { + ret = AVERROR_INVALIDDATA; + goto free; + } } recover_mag_sgn(mag_sgn_stream, J2K_Q1, q1, m_n, known_1, emb_pat_1, v, m, @@ -723,8 +727,13 @@ static int jpeg2000_decode_ht_cleanup_segment(const Jpeg2000DecoderContext *s, U[J2K_Q1] = kappa[J2K_Q1] + u[J2K_Q1]; - for (int i = 0; i < 4; i++) + for (int i = 0; i < 4; i++) { m[J2K_Q1][i] = sigma_n[4 * q1 + i] * U[J2K_Q1] - ((emb_pat_k[J2K_Q1] >> i) & 1); + if (m[J2K_Q1][i] > 63) { + ret = AVERROR_INVALIDDATA; + goto free; + } + } recover_mag_sgn(mag_sgn_stream, J2K_Q1, q1, m_n, known_1, emb_pat_1, v, m, E, mu_n, Dcup, Pcup, pLSB); @@ -855,6 +864,10 @@ static int jpeg2000_decode_ht_cleanup_segment(const Jpeg2000DecoderContext *s, for (int i = 0; i < 4; i++) { m[J2K_Q1][i] = sigma_n[4 * q1 + i] * U[J2K_Q1] - ((emb_pat_k[J2K_Q1] >> i) & 1); m[J2K_Q2][i] = sigma_n[4 * q2 + i] * U[J2K_Q2] - ((emb_pat_k[J2K_Q2] >> i) & 1); + if (m[J2K_Q1][i] > 63 || m[J2K_Q2][i] > 63) { + ret = AVERROR_INVALIDDATA; + goto free; + } } recover_mag_sgn(mag_sgn_stream, J2K_Q1, q1, m_n, known_1, emb_pat_1, v, m, E, mu_n, Dcup, Pcup, pLSB); @@ -920,8 +933,13 @@ static int jpeg2000_decode_ht_cleanup_segment(const Jpeg2000DecoderContext *s, U[J2K_Q1] = kappa[J2K_Q1] + u[J2K_Q1]; - for (int i = 0; i < 4; i++) + for (int i = 0; i < 4; i++) { m[J2K_Q1][i] = sigma_n[4 * q1 + i] * U[J2K_Q1] - ((emb_pat_k[J2K_Q1] >> i) & 1); + if (m[J2K_Q1][i] > 63) { + ret = AVERROR_INVALIDDATA; + goto free; + } + } recover_mag_sgn(mag_sgn_stream, J2K_Q1, q1, m_n, known_1, emb_pat_1, v, m, E, mu_n, Dcup, Pcup, pLSB);