From patchwork Sun Aug 20 18:35:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Spencer X-Patchwork-Id: 43278 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:47ca:b0:130:ccc6:6c4b with SMTP id ey10csp1016521pzb; Sun, 20 Aug 2023 11:36:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE/fskbzeA2rCYx2yUDwKCN1sjHsFA5SxSAntI7f9lxFsxEX3IgJUcF0XcGqLpgycIG/GAW X-Received: by 2002:a19:7b10:0:b0:4ff:9bd9:f69a with SMTP id w16-20020a197b10000000b004ff9bd9f69amr2079158lfc.65.1692556573223; Sun, 20 Aug 2023 11:36:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692556573; cv=none; d=google.com; s=arc-20160816; b=NGxZI7ge/5RJSZ3U/Gk5ClYaNrCOwhTz4EHt+fnDtwP1MMMs8/T9QNttu46yoy7H/G XyJ6L2krYdbPmkS4k7tIUjRafZINeSD5W5bG/RpYNwIjRZUD0hDMu3GXDWT+rbKCwPH9 00wRZSVLGJ/a6QFbkRwqY9oBSpWD4aDhkEub+9IfkaP0rQ02x6Tl/GZmvICHya+M3stR XT1N8wLH8McD/L5a7Kpg+3djhwsz4Cv5JStM90l1TDt/dBruX1JHl909Dx78KdjPo8DU bpqUpbHkfMkplhPaKNDqXozE5bDuhNpfKgtjEabYesS4dLMLGAocfQ86tkjN+ux+ywsV 4tfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=TPbthqMX7meKFlnwzd8tKltV777L+q6ecaG9ak+MY50=; fh=7XptQmT5KFyAKBPvp7UR38tff7fuHplpRbg0RNXz0n4=; b=RDWL0VDY+oDCsnYdj2KJWrlIIvmDzzW930bH+Lp0dWrLC5OqQhVUgSIgtqhu+2lduq fIapgE6vkQh2+BpJzTWiNahQgf4l10IeBuTnDrtUdLDND1H1Cd+ClBueMeJ0gQTWVMzh gVeAe5VQCS8gPtG6xA3TXZqQ7TvXHCYWkZsAcAV6WNfOFeSUzxTvX9/nQw5CiQ58blOM 0apClrFZZCRM+G2l1dT9XhCeFn/tDvNpzovUMIg9mX6DmEc1adN2mcim9KA+jOMZfm0g /75+5ZCsI+eIngZh9zE/q4ZpTi9dqaR3zLmbrkZGTrlVE8qTji9JR074VKVnNpZdnvlk gsNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20221208 header.b=JTerXpi0; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id jr16-20020a170906a99000b0099cbdd785a2si4599215ejb.821.2023.08.20.11.36.12; Sun, 20 Aug 2023 11:36:13 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20221208 header.b=JTerXpi0; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D62AB68BFD6; Sun, 20 Aug 2023 21:36:09 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1844868BBF9 for ; Sun, 20 Aug 2023 21:36:03 +0300 (EEST) Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-99cdb0fd093so354730266b.1 for ; Sun, 20 Aug 2023 11:36:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692556562; x=1693161362; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QEIiiIVXAFT/jeTsf0eORHz7Pl49x1elrQBsxZ8wsTQ=; b=JTerXpi0uHCZawwge4OP2vo2IufhFs9E5EYYJFBu5Dk//IaQhSpZMmQIkzte4vaGao IOLrFeVH0lrRMEPh1ZtLd/K4EvCnqff7QGKfZlfQbCs0/zqCPAUIuSOrRCG5D7o+cGAu A5Ek/jrrVudTTudwWb/vcnOjLUk0z417miO7bxP8Vy/v+GtivTzlReuP2kzkTx1FG+Zs db0Aej01AzbahBrKCk3Gq9V3AgdnvNnm5Y9GF5pqB1BBX1ERhemyP1BFRN5PAylOViA6 Vr8FJSAWYOQoYZwqPnxy42gEZRjw+kkeSDKCnpa5zdedOm9Z2N0A8JOtbHCydN83zboa O6cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692556562; x=1693161362; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QEIiiIVXAFT/jeTsf0eORHz7Pl49x1elrQBsxZ8wsTQ=; b=CIbGOpdEoWbUSkh8b9tyBJEfMFp0ca8WpjKscQ7HWC/UfFQ+CAoTcP3O4NKSJ93b4F 2YK++r2Z88sC95c9PYo00+giBb9kpqOVnZ5QWUO3+LnHPeCGq3tVDjG/dBeztiv5IMbi DIZelFRpG2lco4zFw/91Bk5w8I85y+7eKfX6rw6Mia67zj7vDdnbLBM/6XUplxLdxCMd AygQs7UGFe1Lgpnm95e8khbg3eKfXTVC5mymSpZHUd4ZaONB3KTwnXJe6QluVaqjxsHl wJ0PtnQUMXTTrPRvEU5AeKbvCAYDrd0FqpyQ8XedzHVSUimCCJT53bhL2ho1Rwv5EXgC bE7w== X-Gm-Message-State: AOJu0YyeVFtM8iznld/GDK/dhD5mry150C3XR/EBmKrVmeRJ+T4YfWCS icpW108hjyG3XpnIVyYRFMRM+r3rXk0= X-Received: by 2002:a17:907:2c48:b0:99d:6b3c:3d40 with SMTP id hf8-20020a1709072c4800b0099d6b3c3d40mr3438246ejc.6.1692556562205; Sun, 20 Aug 2023 11:36:02 -0700 (PDT) Received: from chrispc.tailb45b3.ts.net (host-92-8-168-213.as13285.net. [92.8.168.213]) by smtp.gmail.com with ESMTPSA id i6-20020a170906698600b009928b4e3b9fsm5040962ejr.114.2023.08.20.11.36.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Aug 2023 11:36:01 -0700 (PDT) From: Chris Spencer To: ffmpeg-devel@ffmpeg.org Date: Sun, 20 Aug 2023 19:35:44 +0100 Message-ID: <20230820183544.239058-1-spencercw@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] hwcontext_vulkan: always use create_pnext in vulkan_pool_alloc X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Chris Spencer Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Kv7YtrXnVuGY Currently, create_pnext is only used if an applicable external memory extension is enabled. This will usually the case when used from the command line, but may not be when the Vulkan context is created manually. For images used in video decoding, create_pnext contains the video profile list, which is mandatory.[1] This fixes a GPU crash when using RADV. [1] https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VkImageCreateInfo.html#VUID-VkImageCreateInfo-usage-04815 Signed-off-by: Chris Spencer --- libavutil/hwcontext_vulkan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 75314f1407..54faf16a69 100644 --- a/libavutil/hwcontext_vulkan.c +++ b/libavutil/hwcontext_vulkan.c @@ -2179,7 +2179,8 @@ static AVBufferRef *vulkan_pool_alloc(void *opaque, size_t size) } err = create_frame(hwfc, &f, hwctx->tiling, hwctx->usage, hwctx->img_flags, - hwctx->nb_layers, eiinfo.handleTypes ? &eiinfo : NULL); + hwctx->nb_layers, + eiinfo.handleTypes ? &eiinfo : hwctx->create_pnext); if (err) return NULL;