From patchwork Mon Sep 4 19:06:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 43547 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:4f16:b0:149:dfde:5c0a with SMTP id gi22csp1400188pzb; Mon, 4 Sep 2023 12:06:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHAxMN7AAXAQD/cJClLGJgH5VQEd+jM9RJVmRaMnfAgJ2QPTIV3sAxSkJjq00dbYoGx+69w X-Received: by 2002:ac2:4f09:0:b0:500:bd75:77cf with SMTP id k9-20020ac24f09000000b00500bd7577cfmr7952800lfr.17.1693854406765; Mon, 04 Sep 2023 12:06:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693854406; cv=none; d=google.com; s=arc-20160816; b=vpH6vNlSruLtmA0FPVhOroLmGStnl5SMe0qdDfducDwiMG6Q9+4lJxRkL+Zzc7Ikp6 JjaMJMLGFx2LBxOMiFsqbhkXEQJwnmR2lhawIR3RBY41EXZXOWDSHnUOZgfaHiR48irH YRCcSvUgsABKc1TJ1UB9lR2HSa1uMq4dqCZPOQveQ/mqSeN4QXhiRUxbk/PlKFbyel55 5FXavAxOMJAvQ7toX9qY4Px1h7IFh8W14hg4E5RddklJagOgTX8i2PpJC9HFUCl62wlF 82u7Pz1VtfY0NI6M4+lMNYqolbsMerBngQ7g8Mv46zTwW8zuE5yLFvgIWOJr5BIPGDJh radw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to; bh=xAVDZBW+7P35KZ5O6zRGmoixWBN3WKFLyxgF4qa8jKw=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=ADpsmSDzk5AHDGCkbHCuxxyXJDE/f0hn56p1u0pmJf98zy/oOgEObZct5W3eT1SW+Y 1fpjCY3cPCqPGSFSJuCm0719SIlTyQliJT79JlQguL0GnNy6bqIj0xw8M4CMxpqiIBn9 G/EeXJcz9PKG3oAU7cqi0G+buOiSxt/b8NaBwmG/5J03dmb++2ryLmrhe4bDauSKOJT/ YPADqSRG+N//ixwbk0TR3gL68hrFmqJsj6PY1orSwb5ffnvu4gfdqvxrOXAnBn246WP7 ScovbNjc5x2RyF5FjG7ih2+aNL1dxq+gz/HGMJ6CRAAMX+Dzu/28uEz6YYwLSgia7C/A PI2Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id l26-20020a056402125a00b00522e5272088si6337078edw.415.2023.09.04.12.06.46; Mon, 04 Sep 2023 12:06:46 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B42C768C799; Mon, 4 Sep 2023 22:06:43 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DFABA687F25 for ; Mon, 4 Sep 2023 22:06:36 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 402D140009 for ; Mon, 4 Sep 2023 19:06:35 +0000 (UTC) From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Mon, 4 Sep 2023 21:06:35 +0200 Message-Id: <20230904190635.21930-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH] avcodec/bonk: Fix integer overflow in predictor_calc_error() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: YJE+2qdhl89E Fixes: signed integer overflow: -2147483300 - 12285 cannot be represented in type 'int' Fixes: 59462/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BONK_fuzzer-5714298807386112 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/bonk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/bonk.c b/libavcodec/bonk.c index fbea91c750..6cd6a0af61 100644 --- a/libavcodec/bonk.c +++ b/libavcodec/bonk.c @@ -277,7 +277,7 @@ static int predictor_calc_error(int *k, int *state, int order, int error) for (i = order-2; i >= 0; i--, k_ptr--, state_ptr--) { unsigned k_value = *k_ptr, state_value = *state_ptr; - x -= shift_down(k_value * (unsigned)state_value, LATTICE_SHIFT); + x -= (unsigned) shift_down(k_value * (unsigned)state_value, LATTICE_SHIFT); state_ptr[1] = state_value + shift_down(k_value * x, LATTICE_SHIFT); }