From patchwork Mon Sep 18 06:37:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Xiang, Haihao" X-Patchwork-Id: 43763 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:bca2:b0:149:dfde:5c0a with SMTP id fx34csp1744524pzb; Sun, 17 Sep 2023 23:38:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGL8p9p99AkaSkjZBT7ZqyccWKHs9um5ZMj9oP6PB4Izcdz8rNPJfsy7CxoUeU+ysAY1SfK X-Received: by 2002:a2e:3c16:0:b0:2bc:e51d:d09c with SMTP id j22-20020a2e3c16000000b002bce51dd09cmr6195842lja.36.1695019083258; Sun, 17 Sep 2023 23:38:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695019083; cv=none; d=google.com; s=arc-20160816; b=i+Bdcs8daP/1yZZd2R0AYOzTWHaM9ek8Lua3+p1ZVvRP0oYX+s2pZ72xA7EdEasMHP 43nFyFsJXHyYrYc4S8TAGXUawKgP2zL6/XfUYDjmEn09CCGBRqGEMcpFTEZb0q6CpOG9 T8nu4qj0st50ZFssqKWF52CMhVSbr+5jzOwYZjOaaqJg7eXTjLaf7AHjM6hH6eA03IJf eD9P2rPUFDOS468/Lnbx5k5XHmWFuj3RCec1Tt8VWYHCIzoOma3byl6Ke8058NHVRwjQ 7QPw9GqzEkiGj0eD4uQ2hX/jXd/h5C2ukrbQmNhO3223Q5pkojguMw20Uu5Lvj4pjnBR L9VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=QQPyc9vxgnA3hP1aekyUjgOKls+Lonma3yQ67HshhHc=; fh=1kpmTRI1sW42eNCnNMby7VLIISQBX6KJuVYxOEG0t2A=; b=D2lvmdPhRoOTQmX2j6jtEjPg8nDH/lU8mDytDPAFkQAK3fFViWhg9z4ynbe0dURbis HiA2WgX4IdJDmQV/yeLhWNGzmoVMtsyQ9M5is0nsHk9GO4DQb4POQOwWqfFoI21XCcK9 g9Byf6ASTfewycuWWQSzcSB7dQ+H6EvUIXtXq+nFDEFM/UPHfltWLHCsd+KUaF6WWz8m LLZ7y4w33Gv3zuIKj6bKF2et1ivXzw4bZYt/iFDqBMnHG5cyECNBg9uItXCpjZHDV7cr UzT17dqCo67HZEg1cabRVYYig8+8Re5gTgYPFNWwxTW4EC85bsIQTJdBj/lPRmnh6Juh lNOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=G4T2ueOq; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id m18-20020a1709066d1200b0099bc55749c1si7784723ejr.349.2023.09.17.23.38.01; Sun, 17 Sep 2023 23:38:03 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=G4T2ueOq; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C85D268C82C; Mon, 18 Sep 2023 09:37:57 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8FCDE68C655 for ; Mon, 18 Sep 2023 09:37:50 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695019075; x=1726555075; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=/Idm+D5aXbA3LDskfnBkieCVUO3H8FYE1AX2VK7X5xs=; b=G4T2ueOq2W4SwCVT1tAYGrhZwua397LycY1JVoRCCgPhDrogKkb2qwg9 x2CYp0hP7bAY/KrxCnQEOVFkN6828pFweLuF6i85rOAMpSXJ1INqMTCcl KGWSwh9+LF0hxHx01TI4SmWfZ8OCUSJxNleGxG7l0NU6GzGqia/ORol56 kV8DD2twJ1cGs8L4YQMzSroQvqZXxKHdec7z4NezL5U8wTFB7DHlDbj3v 5wypCx5RfS3P8lubKDbphwrSoycBBLXWA1rhNYltvMJt7c/a6skBoLmgQ Wsy+N4fIQqguIo8lodh1eWA+UsVbitd+xhKJUwyHm5iTCnaSxgmrLBNUl w==; X-IronPort-AV: E=McAfee;i="6600,9927,10836"; a="443654829" X-IronPort-AV: E=Sophos;i="6.02,155,1688454000"; d="scan'208";a="443654829" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2023 23:37:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10836"; a="739011073" X-IronPort-AV: E=Sophos;i="6.02,155,1688454000"; d="scan'208";a="739011073" Received: from xhh-tgl64.sh.intel.com ([10.238.6.115]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2023 23:37:46 -0700 From: "Xiang, Haihao" To: ffmpeg-devel@ffmpeg.org Date: Mon, 18 Sep 2023 14:37:28 +0800 Message-Id: <20230918063728.198377-1-haihao.xiang@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] lavd/sdl2: postpone sdl2 window creation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Haihao Xiang Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: snaGt37E4nxt From: Haihao Xiang Since 2d924b3, sdl2_write_header() and sdl2_write_packet() are called in two different threads. However SDL2 requires window creation and rendering should be done in the same thread, otherwise it shows nothing when specifying SDL2 output device. $ ffmpeg -f lavfi -i yuvtestsrc -pix_fmt yuv420p -f sdl2 "sdl2" Signed-off-by: Haihao Xiang --- libavdevice/sdl2.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/libavdevice/sdl2.c b/libavdevice/sdl2.c index 342a253dc0..c9f7f03c28 100644 --- a/libavdevice/sdl2.c +++ b/libavdevice/sdl2.c @@ -158,6 +158,11 @@ static int sdl2_write_trailer(AVFormatContext *s) } static int sdl2_write_header(AVFormatContext *s) +{ + return 0; +} + +static int sdl2_init(AVFormatContext *s) { SDLContext *sdl = s->priv_data; AVStream *st = s->streams[0]; @@ -165,6 +170,9 @@ static int sdl2_write_header(AVFormatContext *s) int i, ret = 0; int flags = 0; + if (sdl->inited) + return 0; + if (!sdl->window_title) sdl->window_title = av_strdup(s->url); @@ -249,6 +257,11 @@ static int sdl2_write_packet(AVFormatContext *s, AVPacket *pkt) int linesize[4]; SDL_Event event; + + ret = sdl2_init(s); + if (ret) + return ret; + if (SDL_PollEvent(&event)){ switch (event.type) { case SDL_KEYDOWN: