From patchwork Wed Sep 27 16:25:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= X-Patchwork-Id: 43991 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:2a18:b0:15d:8365:d4b8 with SMTP id e24csp2721749pzh; Wed, 27 Sep 2023 09:25:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEy/1WkYW8q2EfBTxIrJrKPaEiqznHpZy+V3k7WEGe8Ad1Krh6+m6Q2RWA/oJZUeHRWwPGc X-Received: by 2002:a05:6402:11d3:b0:525:4d74:be8c with SMTP id j19-20020a05640211d300b005254d74be8cmr9629979edw.14.1695831940657; Wed, 27 Sep 2023 09:25:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695831940; cv=none; d=google.com; s=arc-20160816; b=R0RrrgGeZ4W5NUu0j1PHKWdsAJD/gHANfe5XuxFimF+gASdJczDZkXDNQlBF9XmCyY w+VUsYtjWTRgDLVZFH8EFl97h6Btj0kiAQz5kaf55kvK/u+6DefHr8n/2jb8fIs6J6kk 6/zSAbbyUyMhaX29SP6v0cUeG/RJ9s8RI/b/Z/i8dPe0HDtMeODgSCBomwbE/gIeKhkT ZQPdce3uGzCB2FJSLu0YrWq9scZyDWnefzUDiEq58DgC8lBGl1/ui1x88zUSKeVZ2rNl r8eTajWn+RhPbyQi5avfw13Is0oaNwIvcM68B4sTxNfhSnhgOUIeNl+DHZiS1A/MgFt7 a3fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=5epLsV8JSR9xGw09c/Of9SiCHffQWejC0If0Hu9dv0k=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=LKEk2l+S2aSPDXPrq3DTUF/FwPN3iUcu86SsENLdmF296Oai+q2mQldP+G+RoTMKjP Lq9YG5xsdrK7ECj3axPJW8kjctiWkjaT1b+RppmbxOvxjZGjHcyXhFtQYtUMywKwjLQq 9bRfFApbbqovAGawMwWkP9PN0/Wa68J+NcNe27tJE4vyJSEF0jFwdKKDX4cMGJKub79x ++qs7/+o98nefne/lY5qJDTjD0TOsFHORzvDrxbtDX9gBqe2TWcX6v1B+ktUd8dV5wBD T0PtE6mT2oJ5vxxttbFHzFXmQrIEaV+Q+YzfNEOfktOSJKe94h8vHqsJfGrzMjhPOFYR lHig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id p17-20020a056402075100b00528d30a7755si5318728edy.548.2023.09.27.09.25.39; Wed, 27 Sep 2023 09:25:40 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6E6B168CAEF; Wed, 27 Sep 2023 19:25:36 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from ursule.remlab.net (vps-a2bccee9.vps.ovh.net [51.75.19.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 145BC68CA79 for ; Wed, 27 Sep 2023 19:25:30 +0300 (EEST) Received: from basile.remlab.net (localhost [IPv6:::1]) by ursule.remlab.net (Postfix) with ESMTP id 73B45C016E for ; Wed, 27 Sep 2023 19:25:29 +0300 (EEST) From: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= To: ffmpeg-devel@ffmpeg.org Date: Wed, 27 Sep 2023 19:25:29 +0300 Message-Id: <20230927162529.74679-1-remi@remlab.net> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] Revert "lavu/timer: remove gratuitous volatile" X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: vodu6iQAmPeV It does not make much sense to me, but GCC somehow optimises the inline assembler way even when the output are very obviously used. This reverts commit 09731fbfc3a914ec4f6ffad60aa9062db6a8f6aa. --- libavutil/riscv/timer.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/riscv/timer.h b/libavutil/riscv/timer.h index df1a730b5e..174b469cbe 100644 --- a/libavutil/riscv/timer.h +++ b/libavutil/riscv/timer.h @@ -29,13 +29,13 @@ static inline uint64_t ff_read_time(void) #if (__riscv_xlen >= 64) uintptr_t cycles; - __asm__ ("rdtime %0" : "=r" (cycles)); + __asm__ volatile ("rdtime %0" : "=r" (cycles)); #else uint64_t cycles; uint32_t hi, lo, check; - __asm__ ( + __asm__ volatile ( "1: rdtimeh %0\n" " rdtime %1\n" " rdtimeh %2\n"