From patchwork Sat Oct 28 13:04:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: WooDzu X-Patchwork-Id: 44403 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:dd83:b0:15d:8365:d4b8 with SMTP id kw3csp448177pzb; Sat, 28 Oct 2023 06:05:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFKZDwtK21uonVXa0JDIhu8Uq+Q2cW6kXgWmerFyNyzOzsxYyMa2bE02CG2tpj8W7udz6sa X-Received: by 2002:a17:907:970d:b0:9ad:93c8:c483 with SMTP id jg13-20020a170907970d00b009ad93c8c483mr8005954ejc.2.1698498304930; Sat, 28 Oct 2023 06:05:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698498304; cv=none; d=google.com; s=arc-20160816; b=DXKGe2dJrH/29wyzwv1yg6A+u8Lk13Q0OltrLvCFYzKbF5WDwyd+74FbXGg7GNP5y+ ge/SlosDyXkgfm0psRmFG6k4mAdBN20qejCyRdk9guBBp/QLU8yxYu4a//WyUSKHIZdt YwfWX3fYuWVTazxlRS8MXNLMJ8dtNqHxZTdb7jCakrpMxSxe3MHWGWi/o+JxrY/CmF+G yICnKTAD+NH0QTYDBuZF8PYhehy75c+ZNW5IJcV5d1cQNFezp3+7MbOBBg49kuySrSFd qDkUfCjpimW/bWTp9XbDLLvDqtH4mYBpqGueN6TH7xO/OqiDuG3ffUgfo1mAsoliBV+y Mr9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject :content-language:to:from:user-agent:mime-version:date:message-id :dkim-signature:delivered-to; bh=VwLb33qGjrAyIcUJgrRtgVlAkI+ZwOygK0/2g/A+6DE=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=svG6HPZWrHWBV5b1ID7lqkDALKpqUbNQqBnsznMrk3/d2D9Jl/jERnwm8kfPTa36GG 1VHVzALFF61uOHwb0pe7d5WDhN5ib3oJix3aLZIZfDi+UiHMa0uH12XVv2QCqEyK9Ipg g0Ywbhf8RV40Biq0UvkbcAJEzZn4ucKWHPnqMV3U/tCjgPeIogKjQHEbeAU5QFOBDSkq T7IKESsPoDpAqDFYynn7Jm4hHjDAeT99oGlm5Ze/zI216fS2Qc9JY8FmNeC7RUhU+HKz /NxFbmJ1kXXxqSrAjZ3VXI8LHHRBSulttBsjpt1B3dfD354d2fSM32oS8ePruPB4gZCO UZ3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=BWDozPFU; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id dp21-20020a170906c15500b009adb687ee9csi1811293ejc.168.2023.10.28.06.04.50; Sat, 28 Oct 2023 06:05:04 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=BWDozPFU; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 13A4468C987; Sat, 28 Oct 2023 16:04:47 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BAE1F68C987 for ; Sat, 28 Oct 2023 16:04:40 +0300 (EEST) Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-9c603e2354fso606130966b.1 for ; Sat, 28 Oct 2023 06:04:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698498280; x=1699103080; darn=ffmpeg.org; h=subject:content-language:to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=xSDWBxVlTaskHeQeBCNyo1uhG7rPCLbVcHIjGskQhqM=; b=BWDozPFUGIdqicng0HJqzHERtJZtzYlSkju+nWsHTk/gNXhXXjK7Jd4EKrCG2uDrGU gkdzMJpP8Sey1yvQrW+KlooiyLARIi4KGj1N0NluxL7aQa80E03PNZ33PuHAwsKzhuNv Lj5Iw8+sAZMztjiJX6ngJ58CeyzMD19fSptfAEiibonMW+011X+8IhyV2C7b7CHIA5cy xULGVSxRuQYYv2LWpa2XcBv2adZ0fhgmKsHluZZyve1StqXhqf8X/eEN2LhXoBwUAKwM OjTthcTepS1GYFUG5+asSXBPlfQOFlqWfj56DsdS4H7WjK/I28LfkKsIrQRYxssnoWkP 8YOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698498280; x=1699103080; h=subject:content-language:to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xSDWBxVlTaskHeQeBCNyo1uhG7rPCLbVcHIjGskQhqM=; b=nHXhd1Y3btLExEui6033tgKLxr1kUPQniP6lwjePeF8eJ4AVv7vyQzyuPORfRMhDld Vtc+EQ6uqz7gRHK+PW0scbGAb5zyHmGWe1DxocVrN/bTPUVfig4g8gjt05D2YMDjw57m FYpzoKTjEFGb8UDAtufzth/4wBSCC7/zHDJxr87IGEOfCXuGrGV+YHzqIg4TBdHcrX39 OateQZHX6UY7TGXXUyw0xcGXwFLQEuKoLNjDg7rZ/WM1PVphEsdC4t/oh3KFKcxJLSVT aInccRITXiNVfQxjAsDFaKo6+i70swPfNxnO34xXco3nB/TErfjD9C3nlp2ksMCuiWU1 OHfw== X-Gm-Message-State: AOJu0Yy/E8UYdukmZojLgM8V+mcrPddKWsI/w10aTbrmNZtlNq3lxPj0 MxUhS7xu1BQganCzTjVMaO89q0KPBw4Exw== X-Received: by 2002:a17:907:3e9f:b0:9b6:3be9:a8f with SMTP id hs31-20020a1709073e9f00b009b63be90a8fmr5478419ejc.20.1698498279837; Sat, 28 Oct 2023 06:04:39 -0700 (PDT) Received: from [192.168.8.101] (apn-78-30-66-254.dynamic.gprs.plus.pl. [78.30.66.254]) by smtp.googlemail.com with ESMTPSA id y4-20020a170906470400b009ad778a68c5sm2760023ejq.60.2023.10.28.06.04.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Oct 2023 06:04:39 -0700 (PDT) Message-ID: <03aae8d1-edc7-4bb8-b2c8-23ac49c665c0@gmail.com> Date: Sat, 28 Oct 2023 15:04:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: WooDzu To: ffmpeg-devel@ffmpeg.org Content-Language: en-US Subject: [FFmpeg-devel] [PATCH] libavformat: increase MAX_URL_SIZE X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: yYJmS0cgLqW0 With the rise of object storage, like S3, it is not uncommon to generate long pre-signed URLs. When a pre-signed URL is generated using a short-lived credentials it may include a query parameter called X-Amz-Security-Token that is 4kB on its own. The current MAX_URL_SIZE will trim the URL with no any errors or warnings and the request will fail with a http 400 error. Signed-off-by: Piotr Gasiorowski --- libavformat/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) From bfc0dc3e68f1d1cec33084bbea0dd87e19d325d5 Mon Sep 17 00:00:00 2001 From: Piotr Gasiorowski Date: Sat, 28 Oct 2023 14:00:38 +0200 Subject: [PATCH] libavformat: increase MAX_URL_SIZE With the rise of object storage, like S3, it is not uncommon to generate long pre-signed URLs. When a pre-signed URL is generated using a short-lived credentials it may include a query parameter called X-Amz-Security-Token that is 4kB on its own. The current MAX_URL_SIZE will trim the URL with no any errors or warnings and the request will fail with a http 400 error. Signed-off-by: Piotr Gasiorowski --- libavformat/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/internal.h b/libavformat/internal.h index 7702986c9c..d6465bad7c 100644 --- a/libavformat/internal.h +++ b/libavformat/internal.h @@ -27,7 +27,7 @@ #include "avformat.h" -#define MAX_URL_SIZE 4096 +#define MAX_URL_SIZE 8192 /** size of probe buffer, for guessing file type from file contents */ #define PROBE_BUF_MIN 2048 -- 2.39.2 (Apple Git-143)