diff mbox

[FFmpeg-devel] libavformat/movenc: mov: added subtitle codec tags to codec tag list

Message ID 20190225105043.18480-1-pawel.wegner95@gmail.com
State Accepted
Commit 4ed6a485d324b5d0fdd1740d1b2d500ff186dc90
Headers show

Commit Message

Paweł Wegner Feb. 25, 2019, 10:50 a.m. UTC 
This fixes avformat_query_codec incorrectly returning 0 for
mov container and mov_text subtitles.

Signed-off-by: Paweł Wegner <pawel.wegner95@gmail.com>
---
 libavformat/movenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paweł Wegner March 4, 2019, 9:50 a.m. UTC | #1 
ping

On Mon, Feb 25, 2019 at 11:50 AM Paweł Wegner <pawel.wegner95@gmail.com>
wrote:

> This fixes avformat_query_codec incorrectly returning 0 for
> mov container and mov_text subtitles.
>
> Signed-off-by: Paweł Wegner <pawel.wegner95@gmail.com>
> ---
>  libavformat/movenc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 77943304b5..8969d5b170 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -6858,7 +6858,7 @@ AVOutputFormat ff_mov_muxer = {
>      .deinit            = mov_free,
>      .flags             = AVFMT_GLOBALHEADER | AVFMT_ALLOW_FLUSH |
> AVFMT_TS_NEGATIVE,
>      .codec_tag         = (const AVCodecTag* const []){
> -        ff_codec_movvideo_tags, ff_codec_movaudio_tags, 0
> +        ff_codec_movvideo_tags, ff_codec_movaudio_tags,
> ff_codec_movsubtitle_tags, 0
>      },
>      .check_bitstream   = mov_check_bitstream,
>      .priv_class        = &mov_muxer_class,
> --
> 2.17.1
>
>
Paweł Wegner March 4, 2019, 9:52 a.m. UTC | #2 
On Mon, Mar 4, 2019 at 10:50 AM Paweł Wegner <pawel.wegner95@gmail.com>
wrote:

> ping
>
> On Mon, Feb 25, 2019 at 11:50 AM Paweł Wegner <pawel.wegner95@gmail.com>
> wrote:
>
>> This fixes avformat_query_codec incorrectly returning 0 for
>> mov container and mov_text subtitles.
>>
>> Signed-off-by: Paweł Wegner <pawel.wegner95@gmail.com>
>> ---
>>  libavformat/movenc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
>> index 77943304b5..8969d5b170 100644
>> --- a/libavformat/movenc.c
>> +++ b/libavformat/movenc.c
>> @@ -6858,7 +6858,7 @@ AVOutputFormat ff_mov_muxer = {
>>      .deinit            = mov_free,
>>      .flags             = AVFMT_GLOBALHEADER | AVFMT_ALLOW_FLUSH |
>> AVFMT_TS_NEGATIVE,
>>      .codec_tag         = (const AVCodecTag* const []){
>> -        ff_codec_movvideo_tags, ff_codec_movaudio_tags, 0
>> +        ff_codec_movvideo_tags, ff_codec_movaudio_tags,
>> ff_codec_movsubtitle_tags, 0
>>      },
>>      .check_bitstream   = mov_check_bitstream,
>>      .priv_class        = &mov_muxer_class,
>> --
>> 2.17.1
>>
>> Sorry for top posted ping.
Paweł Wegner March 13, 2019, 11:08 a.m. UTC | #3 
On Mon, Mar 4, 2019 at 10:52 AM Paweł Wegner <pawel.wegner95@gmail.com>
wrote:

> On Mon, Mar 4, 2019 at 10:50 AM Paweł Wegner <pawel.wegner95@gmail.com>
> wrote:
>
>> ping
>>
>> On Mon, Feb 25, 2019 at 11:50 AM Paweł Wegner <pawel.wegner95@gmail.com>
>> wrote:
>>
>>> This fixes avformat_query_codec incorrectly returning 0 for
>>> mov container and mov_text subtitles.
>>>
>>> Signed-off-by: Paweł Wegner <pawel.wegner95@gmail.com>
>>> ---
>>>  libavformat/movenc.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
>>> index 77943304b5..8969d5b170 100644
>>> --- a/libavformat/movenc.c
>>> +++ b/libavformat/movenc.c
>>> @@ -6858,7 +6858,7 @@ AVOutputFormat ff_mov_muxer = {
>>>      .deinit            = mov_free,
>>>      .flags             = AVFMT_GLOBALHEADER | AVFMT_ALLOW_FLUSH |
>>> AVFMT_TS_NEGATIVE,
>>>      .codec_tag         = (const AVCodecTag* const []){
>>> -        ff_codec_movvideo_tags, ff_codec_movaudio_tags, 0
>>> +        ff_codec_movvideo_tags, ff_codec_movaudio_tags,
>>> ff_codec_movsubtitle_tags, 0
>>>      },
>>>      .check_bitstream   = mov_check_bitstream,
>>>      .priv_class        = &mov_muxer_class,
>>> --
>>> 2.17.1
>>>
>>> Sorry for top posted ping.
>
ping x2
Paweł Wegner March 18, 2019, 10:09 p.m. UTC | #4 
On Wed, Mar 13, 2019 at 12:08 PM Paweł Wegner <pawel.wegner95@gmail.com>
wrote:

> On Mon, Mar 4, 2019 at 10:52 AM Paweł Wegner <pawel.wegner95@gmail.com>
> wrote:
>
>> On Mon, Mar 4, 2019 at 10:50 AM Paweł Wegner <pawel.wegner95@gmail.com>
>> wrote:
>>
>>> ping
>>>
>>> On Mon, Feb 25, 2019 at 11:50 AM Paweł Wegner <pawel.wegner95@gmail.com>
>>> wrote:
>>>
>>>> This fixes avformat_query_codec incorrectly returning 0 for
>>>> mov container and mov_text subtitles.
>>>>
>>>> Signed-off-by: Paweł Wegner <pawel.wegner95@gmail.com>
>>>> ---
>>>>  libavformat/movenc.c | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
>>>> index 77943304b5..8969d5b170 100644
>>>> --- a/libavformat/movenc.c
>>>> +++ b/libavformat/movenc.c
>>>> @@ -6858,7 +6858,7 @@ AVOutputFormat ff_mov_muxer = {
>>>>      .deinit            = mov_free,
>>>>      .flags             = AVFMT_GLOBALHEADER | AVFMT_ALLOW_FLUSH |
>>>> AVFMT_TS_NEGATIVE,
>>>>      .codec_tag         = (const AVCodecTag* const []){
>>>> -        ff_codec_movvideo_tags, ff_codec_movaudio_tags, 0
>>>> +        ff_codec_movvideo_tags, ff_codec_movaudio_tags,
>>>> ff_codec_movsubtitle_tags, 0
>>>>      },
>>>>      .check_bitstream   = mov_check_bitstream,
>>>>      .priv_class        = &mov_muxer_class,
>>>> --
>>>> 2.17.1
>>>>
>>>> Sorry for top posted ping.
>>
> ping x2
>
ping x3
James Almer March 19, 2019, 12:11 a.m. UTC | #5 
On 2/25/2019 7:50 AM, Paweł Wegner wrote:
> This fixes avformat_query_codec incorrectly returning 0 for
> mov container and mov_text subtitles.
> 
> Signed-off-by: Paweł Wegner <pawel.wegner95@gmail.com>
> ---
>  libavformat/movenc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 77943304b5..8969d5b170 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -6858,7 +6858,7 @@ AVOutputFormat ff_mov_muxer = {
>      .deinit            = mov_free,
>      .flags             = AVFMT_GLOBALHEADER | AVFMT_ALLOW_FLUSH | AVFMT_TS_NEGATIVE,
>      .codec_tag         = (const AVCodecTag* const []){
> -        ff_codec_movvideo_tags, ff_codec_movaudio_tags, 0
> +        ff_codec_movvideo_tags, ff_codec_movaudio_tags, ff_codec_movsubtitle_tags, 0
>      },
>      .check_bitstream   = mov_check_bitstream,
>      .priv_class        = &mov_muxer_class,

Applied, thanks.
diff mbox

Patch

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 77943304b5..8969d5b170 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -6858,7 +6858,7 @@  AVOutputFormat ff_mov_muxer = {
     .deinit            = mov_free,
     .flags             = AVFMT_GLOBALHEADER | AVFMT_ALLOW_FLUSH | AVFMT_TS_NEGATIVE,
     .codec_tag         = (const AVCodecTag* const []){
-        ff_codec_movvideo_tags, ff_codec_movaudio_tags, 0
+        ff_codec_movvideo_tags, ff_codec_movaudio_tags, ff_codec_movsubtitle_tags, 0
     },
     .check_bitstream   = mov_check_bitstream,
     .priv_class        = &mov_muxer_class,