diff mbox

[FFmpeg-devel,v1] doc/developer: make clear for the patch processing time

Message ID 20191007160710.18230-1-lance.lmwang@gmail.com
State New
Headers show

Commit Message

Lance Wang Oct. 7, 2019, 4:07 p.m. UTC
From: Limin Wang <lance.lmwang@gmail.com>

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 doc/developer.texi | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Andriy Gelman Oct. 7, 2019, 6:36 p.m. UTC | #1
On Tue, 08. Oct 00:07, lance.lmwang@gmail.com wrote:
> From: Limin Wang <lance.lmwang@gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
>  doc/developer.texi | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/developer.texi b/doc/developer.texi
> index 5c342c9..698a814 100644
> --- a/doc/developer.texi
> +++ b/doc/developer.texi
> @@ -497,8 +497,12 @@ incorporates the requests from the review. This process may go through
>  several iterations. Once your patch is deemed good enough, some developer
>  will pick it up and commit it to the official FFmpeg tree.
>  
> -Give us a few days to react. But if some time passes without reaction,
> -send a reminder by email. Your patch should eventually be dealt with.
> +Give us a few days to react. But if ten days passes without reaction,
> +send a reminder by email. If ten days passes without reaction still,
> +send a ping reminder by email again. If one more week passes without
> +reaction, your patch is rejected most likely if you're not maintainer,
> +because no one will handle it. Although you can continue to send reminder
> +emails.

Maybe you can ping the individual maintainers and ask them to review your
patches?

I've been following the list for a bit of time and it seems that mem leaks,
seg faults and documentation always get merged. Anything else is tough because
there are just not enough reviewers.

You could help by reviewing other people's patches. That's a good way to
build traction with the community. Hopefully people will review your patches in
return.
diff mbox

Patch

diff --git a/doc/developer.texi b/doc/developer.texi
index 5c342c9..698a814 100644
--- a/doc/developer.texi
+++ b/doc/developer.texi
@@ -497,8 +497,12 @@  incorporates the requests from the review. This process may go through
 several iterations. Once your patch is deemed good enough, some developer
 will pick it up and commit it to the official FFmpeg tree.
 
-Give us a few days to react. But if some time passes without reaction,
-send a reminder by email. Your patch should eventually be dealt with.
+Give us a few days to react. But if ten days passes without reaction,
+send a reminder by email. If ten days passes without reaction still,
+send a ping reminder by email again. If one more week passes without
+reaction, your patch is rejected most likely if you're not maintainer,
+because no one will handle it. Although you can continue to send reminder
+emails.
 
 
 @chapter New codecs or formats checklist