Message ID | 20191030012254.21976-1-lance.lmwang@gmail.com |
---|---|
State | New |
Headers | show |
On Wed, Oct 30, 2019 at 09:22:52AM +0800, lance.lmwang@gmail.com wrote: > From: Limin Wang <lance.lmwang@gmail.com> > > Signed-off-by: Limin Wang <lance.lmwang@gmail.com> > --- > tests/fate/filter-video.mak | 3 +++ > tests/ref/fate/filter-pixfmts-lut3d | 24 ++++++++++++++++++++++++ > 2 files changed, 27 insertions(+) > create mode 100644 tests/ref/fate/filter-pixfmts-lut3d > > diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak > index 9e6351be3e..53e9def176 100644 > --- a/tests/fate/filter-video.mak > +++ b/tests/fate/filter-video.mak > @@ -678,6 +678,9 @@ fate-filter-pixfmts-kerndeint: CMD = pixfmts "" "tinterlace=interleave_top," > FATE_FILTER_PIXFMTS-$(CONFIG_LUT_FILTER) += fate-filter-pixfmts-lut > fate-filter-pixfmts-lut: CMD = pixfmts "c0=2*val:c1=2*val:c2=val/2:c3=negval+40" > > +FATE_FILTER_PIXFMTS-$(CONFIG_LUT_FILTER) += fate-filter-pixfmts-lut3d > +fate-filter-pixfmts-lut3d: CMD = pixfmts > + > FATE_FILTER_PIXFMTS-$(CONFIG_NULL_FILTER) += fate-filter-pixfmts-null > fate-filter-pixfmts-null: CMD = pixfmts > > diff --git a/tests/ref/fate/filter-pixfmts-lut3d b/tests/ref/fate/filter-pixfmts-lut3d > new file mode 100644 > index 0000000000..56c294fa86 > --- /dev/null > +++ b/tests/ref/fate/filter-pixfmts-lut3d > @@ -0,0 +1,24 @@ > +0bgr 5087cdbb3da0d014de02fda75618f278 > +0rgb 9ccde40a857919017558353aaecfa5de > +abgr 0505ae7e852cf32ce9e2a0fc06462f48 > +argb 77e7baba2d8b4389267a2ecb67662c15 > +bgr0 cded4da42263da5bf0153e8bad09a0de > +bgr24 fef9ee2e37a1d5c1787ffb3ed5dcc3bf > +bgr48le 39fe9f41285f3325833d28ce1611d586 For mips, it'll print out bgr48be, but fate-filter-pixfmts-lut is *le always, I haven't see any special process for lut, please give comment if you're expert for the pixfmts test. > +bgra 3433cdbdf07abbd8af4698a3b7a1a189 > +bgra64le 8f33508d6c0362df83296513ebee3a2d > +gbrap 4227379340c3d822dd6c59263b170972 > +gbrap10le 90721f63d6e3d5d7a6bafcefdca5151d > +gbrap12le e1eee70df0c2578937dcd7a90e22f4b7 > +gbrap16le 2fd82ec30573ed65fa23c4d1c150d596 > +gbrp e615c8ea180a0358261953812df0aa3d > +gbrp10le d61faad75dbd7cbb0271b47fa33d714e > +gbrp12le 90c4ec04807bbfbe194eddcc8d7bcb2a > +gbrp14le c424158744f9e16dbfcf00c66ba651f9 > +gbrp16le 8ccb63f9407cae03b2e061ed1249127d > +gbrp9le 4a267ed7c6535c8829e83e35c51df6bf > +rgb0 545f5c4e4a7b7f3e61373149db0b932a > +rgb24 aec4f0a1954823de17024383d6401b75 > +rgb48le 1d1e5a1849ed3c326961184bb2f45400 > +rgba ecd543877779d03bded1e8209f5bdea5 > +rgba64le b26c35d221b026304db46014260ed1db > -- > 2.21.0 >
On 10/30/19, Limin Wang <lance.lmwang@gmail.com> wrote: > On Wed, Oct 30, 2019 at 09:22:52AM +0800, lance.lmwang@gmail.com wrote: >> From: Limin Wang <lance.lmwang@gmail.com> >> >> Signed-off-by: Limin Wang <lance.lmwang@gmail.com> >> --- >> tests/fate/filter-video.mak | 3 +++ >> tests/ref/fate/filter-pixfmts-lut3d | 24 ++++++++++++++++++++++++ >> 2 files changed, 27 insertions(+) >> create mode 100644 tests/ref/fate/filter-pixfmts-lut3d >> >> diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak >> index 9e6351be3e..53e9def176 100644 >> --- a/tests/fate/filter-video.mak >> +++ b/tests/fate/filter-video.mak >> @@ -678,6 +678,9 @@ fate-filter-pixfmts-kerndeint: CMD = pixfmts "" >> "tinterlace=interleave_top," >> FATE_FILTER_PIXFMTS-$(CONFIG_LUT_FILTER) += fate-filter-pixfmts-lut >> fate-filter-pixfmts-lut: CMD = pixfmts >> "c0=2*val:c1=2*val:c2=val/2:c3=negval+40" >> >> +FATE_FILTER_PIXFMTS-$(CONFIG_LUT_FILTER) += fate-filter-pixfmts-lut3d >> +fate-filter-pixfmts-lut3d: CMD = pixfmts >> + >> FATE_FILTER_PIXFMTS-$(CONFIG_NULL_FILTER) += fate-filter-pixfmts-null >> fate-filter-pixfmts-null: CMD = pixfmts >> >> diff --git a/tests/ref/fate/filter-pixfmts-lut3d >> b/tests/ref/fate/filter-pixfmts-lut3d >> new file mode 100644 >> index 0000000000..56c294fa86 >> --- /dev/null >> +++ b/tests/ref/fate/filter-pixfmts-lut3d >> @@ -0,0 +1,24 @@ >> +0bgr 5087cdbb3da0d014de02fda75618f278 >> +0rgb 9ccde40a857919017558353aaecfa5de >> +abgr 0505ae7e852cf32ce9e2a0fc06462f48 >> +argb 77e7baba2d8b4389267a2ecb67662c15 >> +bgr0 cded4da42263da5bf0153e8bad09a0de >> +bgr24 fef9ee2e37a1d5c1787ffb3ed5dcc3bf >> +bgr48le 39fe9f41285f3325833d28ce1611d586 > > For mips, it'll print out bgr48be, but fate-filter-pixfmts-lut is *le > always, I haven't see any special process > for lut, please give comment if you're expert for the pixfmts test. I'm expert for pixfmts test, and your patch is invalid. > >> +bgra 3433cdbdf07abbd8af4698a3b7a1a189 >> +bgra64le 8f33508d6c0362df83296513ebee3a2d >> +gbrap 4227379340c3d822dd6c59263b170972 >> +gbrap10le 90721f63d6e3d5d7a6bafcefdca5151d >> +gbrap12le e1eee70df0c2578937dcd7a90e22f4b7 >> +gbrap16le 2fd82ec30573ed65fa23c4d1c150d596 >> +gbrp e615c8ea180a0358261953812df0aa3d >> +gbrp10le d61faad75dbd7cbb0271b47fa33d714e >> +gbrp12le 90c4ec04807bbfbe194eddcc8d7bcb2a >> +gbrp14le c424158744f9e16dbfcf00c66ba651f9 >> +gbrp16le 8ccb63f9407cae03b2e061ed1249127d >> +gbrp9le 4a267ed7c6535c8829e83e35c51df6bf >> +rgb0 545f5c4e4a7b7f3e61373149db0b932a >> +rgb24 aec4f0a1954823de17024383d6401b75 >> +rgb48le 1d1e5a1849ed3c326961184bb2f45400 >> +rgba ecd543877779d03bded1e8209f5bdea5 >> +rgba64le b26c35d221b026304db46014260ed1db >> -- >> 2.21.0 >> > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On Wed, Oct 30, 2019 at 09:37:06AM +0100, Paul B Mahol wrote: > On 10/30/19, Limin Wang <lance.lmwang@gmail.com> wrote: > > On Wed, Oct 30, 2019 at 09:22:52AM +0800, lance.lmwang@gmail.com wrote: > >> From: Limin Wang <lance.lmwang@gmail.com> > >> > >> Signed-off-by: Limin Wang <lance.lmwang@gmail.com> > >> --- > >> tests/fate/filter-video.mak | 3 +++ > >> tests/ref/fate/filter-pixfmts-lut3d | 24 ++++++++++++++++++++++++ > >> 2 files changed, 27 insertions(+) > >> create mode 100644 tests/ref/fate/filter-pixfmts-lut3d > >> > >> diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak > >> index 9e6351be3e..53e9def176 100644 > >> --- a/tests/fate/filter-video.mak > >> +++ b/tests/fate/filter-video.mak > >> @@ -678,6 +678,9 @@ fate-filter-pixfmts-kerndeint: CMD = pixfmts "" > >> "tinterlace=interleave_top," > >> FATE_FILTER_PIXFMTS-$(CONFIG_LUT_FILTER) += fate-filter-pixfmts-lut > >> fate-filter-pixfmts-lut: CMD = pixfmts > >> "c0=2*val:c1=2*val:c2=val/2:c3=negval+40" > >> > >> +FATE_FILTER_PIXFMTS-$(CONFIG_LUT_FILTER) += fate-filter-pixfmts-lut3d > >> +fate-filter-pixfmts-lut3d: CMD = pixfmts > >> + > >> FATE_FILTER_PIXFMTS-$(CONFIG_NULL_FILTER) += fate-filter-pixfmts-null > >> fate-filter-pixfmts-null: CMD = pixfmts > >> > >> diff --git a/tests/ref/fate/filter-pixfmts-lut3d > >> b/tests/ref/fate/filter-pixfmts-lut3d > >> new file mode 100644 > >> index 0000000000..56c294fa86 > >> --- /dev/null > >> +++ b/tests/ref/fate/filter-pixfmts-lut3d > >> @@ -0,0 +1,24 @@ > >> +0bgr 5087cdbb3da0d014de02fda75618f278 > >> +0rgb 9ccde40a857919017558353aaecfa5de > >> +abgr 0505ae7e852cf32ce9e2a0fc06462f48 > >> +argb 77e7baba2d8b4389267a2ecb67662c15 > >> +bgr0 cded4da42263da5bf0153e8bad09a0de > >> +bgr24 fef9ee2e37a1d5c1787ffb3ed5dcc3bf > >> +bgr48le 39fe9f41285f3325833d28ce1611d586 > > > > For mips, it'll print out bgr48be, but fate-filter-pixfmts-lut is *le > > always, I haven't see any special process > > for lut, please give comment if you're expert for the pixfmts test. > > I'm expert for pixfmts test, and your patch is invalid. Thanks for comments, I add the fate testing is help to make sure my next patch is consistent with the old. I have spend more time to solve the problem by add a parameter to force output pixel format of little endian, it'll pass the fate testing on big and little endian system. Please help to review the update patch. > > > > >> +bgra 3433cdbdf07abbd8af4698a3b7a1a189 > >> +bgra64le 8f33508d6c0362df83296513ebee3a2d > >> +gbrap 4227379340c3d822dd6c59263b170972 > >> +gbrap10le 90721f63d6e3d5d7a6bafcefdca5151d > >> +gbrap12le e1eee70df0c2578937dcd7a90e22f4b7 > >> +gbrap16le 2fd82ec30573ed65fa23c4d1c150d596 > >> +gbrp e615c8ea180a0358261953812df0aa3d > >> +gbrp10le d61faad75dbd7cbb0271b47fa33d714e > >> +gbrp12le 90c4ec04807bbfbe194eddcc8d7bcb2a > >> +gbrp14le c424158744f9e16dbfcf00c66ba651f9 > >> +gbrp16le 8ccb63f9407cae03b2e061ed1249127d > >> +gbrp9le 4a267ed7c6535c8829e83e35c51df6bf > >> +rgb0 545f5c4e4a7b7f3e61373149db0b932a > >> +rgb24 aec4f0a1954823de17024383d6401b75 > >> +rgb48le 1d1e5a1849ed3c326961184bb2f45400 > >> +rgba ecd543877779d03bded1e8209f5bdea5 > >> +rgba64le b26c35d221b026304db46014260ed1db > >> -- > >> 2.21.0 > >> > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak index 9e6351be3e..53e9def176 100644 --- a/tests/fate/filter-video.mak +++ b/tests/fate/filter-video.mak @@ -678,6 +678,9 @@ fate-filter-pixfmts-kerndeint: CMD = pixfmts "" "tinterlace=interleave_top," FATE_FILTER_PIXFMTS-$(CONFIG_LUT_FILTER) += fate-filter-pixfmts-lut fate-filter-pixfmts-lut: CMD = pixfmts "c0=2*val:c1=2*val:c2=val/2:c3=negval+40" +FATE_FILTER_PIXFMTS-$(CONFIG_LUT_FILTER) += fate-filter-pixfmts-lut3d +fate-filter-pixfmts-lut3d: CMD = pixfmts + FATE_FILTER_PIXFMTS-$(CONFIG_NULL_FILTER) += fate-filter-pixfmts-null fate-filter-pixfmts-null: CMD = pixfmts diff --git a/tests/ref/fate/filter-pixfmts-lut3d b/tests/ref/fate/filter-pixfmts-lut3d new file mode 100644 index 0000000000..56c294fa86 --- /dev/null +++ b/tests/ref/fate/filter-pixfmts-lut3d @@ -0,0 +1,24 @@ +0bgr 5087cdbb3da0d014de02fda75618f278 +0rgb 9ccde40a857919017558353aaecfa5de +abgr 0505ae7e852cf32ce9e2a0fc06462f48 +argb 77e7baba2d8b4389267a2ecb67662c15 +bgr0 cded4da42263da5bf0153e8bad09a0de +bgr24 fef9ee2e37a1d5c1787ffb3ed5dcc3bf +bgr48le 39fe9f41285f3325833d28ce1611d586 +bgra 3433cdbdf07abbd8af4698a3b7a1a189 +bgra64le 8f33508d6c0362df83296513ebee3a2d +gbrap 4227379340c3d822dd6c59263b170972 +gbrap10le 90721f63d6e3d5d7a6bafcefdca5151d +gbrap12le e1eee70df0c2578937dcd7a90e22f4b7 +gbrap16le 2fd82ec30573ed65fa23c4d1c150d596 +gbrp e615c8ea180a0358261953812df0aa3d +gbrp10le d61faad75dbd7cbb0271b47fa33d714e +gbrp12le 90c4ec04807bbfbe194eddcc8d7bcb2a +gbrp14le c424158744f9e16dbfcf00c66ba651f9 +gbrp16le 8ccb63f9407cae03b2e061ed1249127d +gbrp9le 4a267ed7c6535c8829e83e35c51df6bf +rgb0 545f5c4e4a7b7f3e61373149db0b932a +rgb24 aec4f0a1954823de17024383d6401b75 +rgb48le 1d1e5a1849ed3c326961184bb2f45400 +rgba ecd543877779d03bded1e8209f5bdea5 +rgba64le b26c35d221b026304db46014260ed1db