diff mbox

[FFmpeg-devel,v1] doc/demuxers: Fix typo in help text

Message ID 20191125052012.12717-1-lance.lmwang@gmail.com
State New
Headers show

Commit Message

Lance Wang Nov. 25, 2019, 5:20 a.m. UTC
From: Limin Wang <lance.lmwang@gmail.com>

dose -> does

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 doc/demuxers.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gyan Doshi Nov. 25, 2019, 5:57 a.m. UTC | #1
On 25-11-2019 10:50 am, lance.lmwang@gmail.com wrote:
> From: Limin Wang <lance.lmwang@gmail.com>
>
> dose -> does
>
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
>   doc/demuxers.texi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/demuxers.texi b/doc/demuxers.texi
> index 4e1a5cb6aa..2820934d7a 100644
> --- a/doc/demuxers.texi
> +++ b/doc/demuxers.texi
> @@ -332,7 +332,7 @@ Maximum number of times a insufficient list is attempted to be reloaded.
>   Default value is 1000.
>   
>   @item m3u8_hold_counters
> -Maximum number of times to load m3u8 when the m3u8 dose not refresh with new segments.
> +Maximum number of times to load m3u8 when the m3u8 does not refresh with new segments.
>   Default value is 1000.
>   
>   @item http_persistent

LGTM.

Gyan
Steven Liu Nov. 25, 2019, 6:33 a.m. UTC | #2
> 在 2019年11月25日,13:57,Gyan <ffmpeg@gyani.pro> 写道:
> 
> 
> 
> On 25-11-2019 10:50 am, lance.lmwang@gmail.com wrote:
>> From: Limin Wang <lance.lmwang@gmail.com>
>> 
>> dose -> does
>> 
>> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
>> ---
>>  doc/demuxers.texi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/doc/demuxers.texi b/doc/demuxers.texi
>> index 4e1a5cb6aa..2820934d7a 100644
>> --- a/doc/demuxers.texi
>> +++ b/doc/demuxers.texi
>> @@ -332,7 +332,7 @@ Maximum number of times a insufficient list is attempted to be reloaded.
>>  Default value is 1000.
>>    @item m3u8_hold_counters
>> -Maximum number of times to load m3u8 when the m3u8 dose not refresh with new segments.
>> +Maximum number of times to load m3u8 when the m3u8 does not refresh with new segments.
Ah, My mistake, i will mofify it by my self, thanks
This line should 
“Maximum number of times to load m3u8 when the m3u8 refresh without new segments”

reference: https://patchwork.ffmpeg.org/patch/16316/

>>  Default value is 1000.
>>    @item http_persistent
> 
> LGTM.
> 
> Gyan
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Thanks
Steven
Rodney Baker Nov. 25, 2019, 8:28 a.m. UTC | #3
On Monday, 25 November 2019 17:03:15 ACDT Steven Liu wrote:
> > 在 2019年11月25日,13:57,Gyan <ffmpeg@gyani.pro> 写道:
> > 
> > On 25-11-2019 10:50 am, lance.lmwang@gmail.com wrote:
> >> From: Limin Wang <lance.lmwang@gmail.com>
> >> 
> >> dose -> does
> >> 
> >> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> >> ---
> >> 
> >>  doc/demuxers.texi | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/doc/demuxers.texi b/doc/demuxers.texi
> >> index 4e1a5cb6aa..2820934d7a 100644
> >> --- a/doc/demuxers.texi
> >> +++ b/doc/demuxers.texi
> >> @@ -332,7 +332,7 @@ Maximum number of times a insufficient list is
> >> attempted to be reloaded.>> 
> >>  Default value is 1000.
> >>  
> >>    @item m3u8_hold_counters
> >> 
> >> -Maximum number of times to load m3u8 when the m3u8 dose not refresh with
> >> new segments. +Maximum number of times to load m3u8 when the m3u8 does
> >> not refresh with new segments.
> Ah, My mistake, i will mofify it by my self, thanks
> This line should
> “Maximum number of times to load m3u8 when the m3u8 refresh without new
> segments”

Suggestion: that would be better worded as, "The maximum number of times to 
load m3u8 when it refreshes without new segments."
Steven Liu Nov. 25, 2019, 8:38 a.m. UTC | #4
Rodney Baker <rodney.baker@iinet.net.au> 于 2019年11月25日周一 下午4:32写道:

> On Monday, 25 November 2019 17:03:15 ACDT Steven Liu wrote:
> > > 在 2019年11月25日,13:57,Gyan <ffmpeg@gyani.pro> 写道:
> > >
> > > On 25-11-2019 10:50 am, lance.lmwang@gmail.com wrote:
> > >> From: Limin Wang <lance.lmwang@gmail.com>
> > >>
> > >> dose -> does
> > >>
> > >> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > >> ---
> > >>
> > >>  doc/demuxers.texi | 2 +-
> > >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/doc/demuxers.texi b/doc/demuxers.texi
> > >> index 4e1a5cb6aa..2820934d7a 100644
> > >> --- a/doc/demuxers.texi
> > >> +++ b/doc/demuxers.texi
> > >> @@ -332,7 +332,7 @@ Maximum number of times a insufficient list is
> > >> attempted to be reloaded.>>
> > >>  Default value is 1000.
> > >>
> > >>    @item m3u8_hold_counters
> > >>
> > >> -Maximum number of times to load m3u8 when the m3u8 dose not refresh
> with
> > >> new segments. +Maximum number of times to load m3u8 when the m3u8 does
> > >> not refresh with new segments.
> > Ah, My mistake, i will mofify it by my self, thanks
> > This line should
> > “Maximum number of times to load m3u8 when the m3u8 refresh without new
> > segments”
>
> Suggestion: that would be better worded as, "The maximum number of times
> to
> load m3u8 when it refreshes without new segments."
>
Thanks :D

>
>
> --
> ==============================================================
> Rodney Baker VK5ZTV
> rodney.baker@iinet.net.au
> CCNA #CSCO12880208
> ==============================================================
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox

Patch

diff --git a/doc/demuxers.texi b/doc/demuxers.texi
index 4e1a5cb6aa..2820934d7a 100644
--- a/doc/demuxers.texi
+++ b/doc/demuxers.texi
@@ -332,7 +332,7 @@  Maximum number of times a insufficient list is attempted to be reloaded.
 Default value is 1000.
 
 @item m3u8_hold_counters
-Maximum number of times to load m3u8 when the m3u8 dose not refresh with new segments.
+Maximum number of times to load m3u8 when the m3u8 does not refresh with new segments.
 Default value is 1000.
 
 @item http_persistent