Message ID | 1583392635-26197-1-git-send-email-linjie.fu@intel.com |
---|---|
State | Accepted |
Headers | show |
Series | [FFmpeg-devel,v2,1/4] tests/checkasm: add overflow test for hevc_add_res | expand |
Context | Check | Description |
---|---|---|
andriy/ffmpeg-patchwork | fail | Make fate failed |
> -----Original Message----- > From: Fu, Linjie <linjie.fu@intel.com> > Sent: Thursday, March 5, 2020 15:17 > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie <linjie.fu@intel.com>; Xu, Guangxin <guangxin.xu@intel.com> > Subject: [PATCH,v2 1/4] tests/checkasm: add overflow test for hevc_add_res > > Add overflow test for hevc_add_res when int16_t coeff = -32768, > and doubled the test cases. > > The result of C is good, while ASM is not. > > To verify: > make fate-checkasm-hevc_add_res > ffmpeg/tests/checkasm/checkasm --test=hevc_add_res > > ./checkasm --test=hevc_add_res > checkasm: using random seed 679391863 > MMXEXT: > hevc_add_res_4x4_8_mmxext (hevc_add_res.c:69) > - hevc_add_res.add_residual [FAILED] > SSE2: > hevc_add_res_8x8_8_sse2 (hevc_add_res.c:69) > hevc_add_res_16x16_8_sse2 (hevc_add_res.c:69) > hevc_add_res_32x32_8_sse2 (hevc_add_res.c:69) > - hevc_add_res.add_residual [FAILED] > AVX: > hevc_add_res_8x8_8_avx (hevc_add_res.c:69) > hevc_add_res_16x16_8_avx (hevc_add_res.c:69) > hevc_add_res_32x32_8_avx (hevc_add_res.c:69) > - hevc_add_res.add_residual [FAILED] > AVX2: > hevc_add_res_32x32_8_avx2 (hevc_add_res.c:69) > - hevc_add_res.add_residual [FAILED] > checkasm: 8 of 14 tests have failed > > Signed-off-by: Xu Guangxin <guangxin.xu@intel.com> > Signed-off-by: Linjie Fu <linjie.fu@intel.com> > --- > [v2]: test 2x cases to make sure the random residuals > could be testd. > This modification in fate should be put after the fix patch(2~4), Otherwise it would break fate test in CI. I'll resend the set, sorry for the noise. - Linjie
diff --git a/tests/checkasm/hevc_add_res.c b/tests/checkasm/hevc_add_res.c index e92c6b4..8c82ac1 100644 --- a/tests/checkasm/hevc_add_res.c +++ b/tests/checkasm/hevc_add_res.c @@ -58,6 +58,7 @@ static void check_add_res(HEVCDSPContext h, int bit_depth) randomize_buffers(res0, size); randomize_buffers2(dst0, size); + res0[0] = 0x8000;// overflow test memcpy(res1, res0, sizeof(*res0) * size); memcpy(dst1, dst0, sizeof(int16_t) * size); @@ -80,6 +81,7 @@ void checkasm_check_hevc_add_res(void) ff_hevc_dsp_init(&h, bit_depth); check_add_res(h, bit_depth); + check_add_res(h, bit_depth); } report("add_residual"); }