diff mbox series

[FFmpeg-devel,2/4] avfilter/vf_zscale: fix number of threads

Message ID 20220314210603.23870-2-cus@passwd.hu
State Accepted
Commit c0351ee5c58e0640066d0430a8c9af88a3918504
Headers show
Series [FFmpeg-devel,1/4] avfilter/x86/vf_blend: use unaligned movs for output | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Marton Balint March 14, 2022, 9:06 p.m. UTC
Make sure it is between [1, MAX_THERADS] and also take into account the outlink
size in order not to request zero height output from zscale.

Signed-off-by: Marton Balint <cus@passwd.hu>
---
 libavfilter/vf_zscale.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul B Mahol March 14, 2022, 9:58 p.m. UTC | #1
lgtm
Victoria Zhislina March 16, 2022, 11:33 a.m. UTC | #2
Thanks for the fix, lgtm as well.

On Tue, Mar 15, 2022 at 12:56 AM Paul B Mahol <onemda@gmail.com> wrote:

> lgtm
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
Marton Balint March 16, 2022, 7:26 p.m. UTC | #3
On Wed, 16 Mar 2022, Victoria Zhislina wrote:

> Thanks for the fix, lgtm as well.

Thanks, applied the zscale patches in the series.

Regards,
Marton

>
> On Tue, Mar 15, 2022 at 12:56 AM Paul B Mahol <onemda@gmail.com> wrote:
>
>> lgtm
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
diff mbox series

Patch

diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c
index bb457423b3..bab87b0c94 100644
--- a/libavfilter/vf_zscale.c
+++ b/libavfilter/vf_zscale.c
@@ -799,7 +799,7 @@  static int filter_frame(AVFilterLink *link, AVFrame *in)
         link->dst->inputs[0]->w      = in->width;
         link->dst->inputs[0]->h      = in->height;
 
-        s->nb_threads = FFMIN(ff_filter_get_nb_threads(ctx), link->h / 8);
+        s->nb_threads = av_clip(FFMIN(ff_filter_get_nb_threads(ctx), FFMIN(link->h, outlink->h) / 8), 1, MAX_THREADS);
         s->in_colorspace = in->colorspace;
         s->in_trc = in->color_trc;
         s->in_primaries = in->color_primaries;