Message ID | 20240609184450.933199-1-post@frankplowman.com |
---|---|
State | New |
Headers | show |
Series | [FFmpeg-devel] fate/vvc: add vvc-conformance-RPR_A_Alibaba_4 | expand |
Context | Check | Description |
---|---|---|
andriy/make_x86 | success | Make finished |
andriy/make_fate_x86 | success | Make fate finished |
Hi Frank, Thank you for the patch. Could we follow the naming conventions used for other clips? On Mon, Jun 10, 2024 at 2:45 AM Frank Plowman <post@frankplowman.com> wrote: > Before After > ------------------------------------------------- > make fate-vvc CPU Time (No ASM) 131.52s 134.83s > libavcodec/vvc/* Line Coverage 95.3% 96.9% > inter_template.c Line Coverage 74.3% 88.2% > inter.c Line Coverage 85.3% 99.2% > > Signed-off-by: Frank Plowman <post@frankplowman.com> > --- > tests/fate/vvc.mak | 1 + > tests/ref/fate/vvc-conformance-RPR_A_Alibaba_4 | 9 +++++++++ > 2 files changed, 10 insertions(+) > create mode 100644 tests/ref/fate/vvc-conformance-RPR_A_Alibaba_4 > > diff --git a/tests/fate/vvc.mak b/tests/fate/vvc.mak > index 0ff287eea6..93b86f15f0 100644 > --- a/tests/fate/vvc.mak > +++ b/tests/fate/vvc.mak > @@ -14,6 +14,7 @@ VVC_SAMPLES_10BIT = \ > POC_A_1 \ > PPS_B_1 \ > RAP_A_1 \ > + RPR_A_Alibaba_4 \ > SAO_A_3 \ > SCALING_A_1 \ > SLICES_A_3 \ > diff --git a/tests/ref/fate/vvc-conformance-RPR_A_Alibaba_4 > b/tests/ref/fate/vvc-conformance-RPR_A_Alibaba_4 > new file mode 100644 > index 0000000000..58ae0f3861 > --- /dev/null > +++ b/tests/ref/fate/vvc-conformance-RPR_A_Alibaba_4 > @@ -0,0 +1,9 @@ > +#tb 0: 1/25 > +#media_type 0: video > +#codec_id 0: rawvideo > +#dimensions 0: 832x480 > +#sar 0: 0/1 > +0, 0, 0, 1, 1198080, 0x2c12c2be > +0, 1, 1, 1, 1198080, 0x47275378 > +0, 2, 2, 1, 1198080, 0x5d7b0327 > +0, 3, 3, 1, 1198080, 0x0b15318a > -- > 2.45.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >
On 10/06/2024 14:26, Nuo Mi wrote: > Hi Frank, > Thank you for the patch. > Could we follow the naming conventions used for other clips? > Hi, I did it this way because I do not have access to the FATE server, so somebody had to upload the clip for me and I felt it was easier if they did not have to rename the clip. Also there is already a mixture of VVC clip titles with and without the vendor's name. If someone renames the clip on the FATE server it is easy to send a v2. Cheers, -- Frank
On 6/10/2024 2:23 PM, Frank Plowman wrote: > On 10/06/2024 14:26, Nuo Mi wrote: >> Hi Frank, >> Thank you for the patch. >> Could we follow the naming conventions used for other clips? >> > Hi, > > I did it this way because I do not have access to the FATE server, so > somebody had to upload the clip for me and I felt it was easier if they > did not have to rename the clip. Also there is already a mixture of VVC > clip titles with and without the vendor's name. > > If someone renames the clip on the FATE server it is easy to send a v2. I just renamed it to RPR_A_4.bit
On 10/06/2024 18:31, James Almer wrote: > On 6/10/2024 2:23 PM, Frank Plowman wrote: >> On 10/06/2024 14:26, Nuo Mi wrote: >>> Hi Frank, >>> Thank you for the patch. >>> Could we follow the naming conventions used for other clips? >>> >> Hi, >> >> I did it this way because I do not have access to the FATE server, so >> somebody had to upload the clip for me and I felt it was easier if they >> did not have to rename the clip. Also there is already a mixture of VVC >> clip titles with and without the vendor's name. >> >> If someone renames the clip on the FATE server it is easy to send a v2. > > I just renamed it to RPR_A_4.bit Thank you James. v2 sent.
diff --git a/tests/fate/vvc.mak b/tests/fate/vvc.mak index 0ff287eea6..93b86f15f0 100644 --- a/tests/fate/vvc.mak +++ b/tests/fate/vvc.mak @@ -14,6 +14,7 @@ VVC_SAMPLES_10BIT = \ POC_A_1 \ PPS_B_1 \ RAP_A_1 \ + RPR_A_Alibaba_4 \ SAO_A_3 \ SCALING_A_1 \ SLICES_A_3 \ diff --git a/tests/ref/fate/vvc-conformance-RPR_A_Alibaba_4 b/tests/ref/fate/vvc-conformance-RPR_A_Alibaba_4 new file mode 100644 index 0000000000..58ae0f3861 --- /dev/null +++ b/tests/ref/fate/vvc-conformance-RPR_A_Alibaba_4 @@ -0,0 +1,9 @@ +#tb 0: 1/25 +#media_type 0: video +#codec_id 0: rawvideo +#dimensions 0: 832x480 +#sar 0: 0/1 +0, 0, 0, 1, 1198080, 0x2c12c2be +0, 1, 1, 1, 1198080, 0x47275378 +0, 2, 2, 1, 1198080, 0x5d7b0327 +0, 3, 3, 1, 1198080, 0x0b15318a
Before After ------------------------------------------------- make fate-vvc CPU Time (No ASM) 131.52s 134.83s libavcodec/vvc/* Line Coverage 95.3% 96.9% inter_template.c Line Coverage 74.3% 88.2% inter.c Line Coverage 85.3% 99.2% Signed-off-by: Frank Plowman <post@frankplowman.com> --- tests/fate/vvc.mak | 1 + tests/ref/fate/vvc-conformance-RPR_A_Alibaba_4 | 9 +++++++++ 2 files changed, 10 insertions(+) create mode 100644 tests/ref/fate/vvc-conformance-RPR_A_Alibaba_4