diff mbox series

[FFmpeg-devel,v2] lavu/opt: Mention that AV_OPT_TYPE_IMAGE_SIZE can be unsigned

Message ID 20240708195951.1309956-1-ffmpeg-devel@pileofstuff.org
State New
Headers show
Series [FFmpeg-devel,v2] lavu/opt: Mention that AV_OPT_TYPE_IMAGE_SIZE can be unsigned | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 fail Make fate failed
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andrew Sayers July 8, 2024, 7:59 p.m. UTC 
TileContext in libavfilter/vf_tile.c and
UntileContext in libavfilter/vf_untile.c
point to unsigned ints - confirm this is OK.
---

Thanks Marcus - have updated my e-mail script to remind myself in future.

 libavutil/opt.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul B Mahol July 10, 2024, 2:01 p.m. UTC | #1 
tile and untile are wrong
Andrew Sayers July 10, 2024, 2:54 p.m. UTC | #2 
On Wed, Jul 10, 2024 at 04:01:44PM +0200, Paul B Mahol wrote:
> tile and untile are wrong

How so?
Andrew Sayers July 19, 2024, 8:34 a.m. UTC | #3 
Ping
Paul B Mahol July 19, 2024, 12:42 p.m. UTC | #4 
Rudimentary programming skills.
Unsigned range of values is different from signed range.

On Fri, Jul 19, 2024 at 10:34 AM Andrew Sayers <ffmpeg-devel@pileofstuff.org>
wrote:

> Ping
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
James Almer July 19, 2024, 12:54 p.m. UTC | #5 
On 7/10/2024 11:54 AM, Andrew Sayers wrote:
> On Wed, Jul 10, 2024 at 04:01:44PM +0200, Paul B Mahol wrote:
>> tile and untile are wrong
> 
> How so?

I think it's better to just make those filters use ints than changing 
what the API is documented to handle.
diff mbox series

Patch

diff --git a/libavutil/opt.h b/libavutil/opt.h
index 07e27a9208..9339b1a6ac 100644
--- a/libavutil/opt.h
+++ b/libavutil/opt.h
@@ -252,7 +252,7 @@  enum AVOptionType{
     AV_OPT_TYPE_DICT,
     AV_OPT_TYPE_UINT64,
     AV_OPT_TYPE_CONST,
-    AV_OPT_TYPE_IMAGE_SIZE, ///< offset must point to two consecutive ints
+    AV_OPT_TYPE_IMAGE_SIZE, ///< offset must point to two consecutive ints (or unsigned ints)
     AV_OPT_TYPE_PIXEL_FMT,
     AV_OPT_TYPE_SAMPLE_FMT,
     AV_OPT_TYPE_VIDEO_RATE, ///< offset must point to AVRational