Message ID | 20240708195951.1309956-1-ffmpeg-devel@pileofstuff.org |
---|---|
State | New |
Headers | show |
Series | [FFmpeg-devel,v2] lavu/opt: Mention that AV_OPT_TYPE_IMAGE_SIZE can be unsigned | expand |
Context | Check | Description |
---|---|---|
yinshiyou/make_loongarch64 | success | Make finished |
yinshiyou/make_fate_loongarch64 | fail | Make fate failed |
andriy/make_x86 | success | Make finished |
andriy/make_fate_x86 | success | Make fate finished |
tile and untile are wrong
On Wed, Jul 10, 2024 at 04:01:44PM +0200, Paul B Mahol wrote:
> tile and untile are wrong
How so?
Ping
Rudimentary programming skills. Unsigned range of values is different from signed range. On Fri, Jul 19, 2024 at 10:34 AM Andrew Sayers <ffmpeg-devel@pileofstuff.org> wrote: > Ping > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >
On 7/10/2024 11:54 AM, Andrew Sayers wrote: > On Wed, Jul 10, 2024 at 04:01:44PM +0200, Paul B Mahol wrote: >> tile and untile are wrong > > How so? I think it's better to just make those filters use ints than changing what the API is documented to handle.
diff --git a/libavutil/opt.h b/libavutil/opt.h index 07e27a9208..9339b1a6ac 100644 --- a/libavutil/opt.h +++ b/libavutil/opt.h @@ -252,7 +252,7 @@ enum AVOptionType{ AV_OPT_TYPE_DICT, AV_OPT_TYPE_UINT64, AV_OPT_TYPE_CONST, - AV_OPT_TYPE_IMAGE_SIZE, ///< offset must point to two consecutive ints + AV_OPT_TYPE_IMAGE_SIZE, ///< offset must point to two consecutive ints (or unsigned ints) AV_OPT_TYPE_PIXEL_FMT, AV_OPT_TYPE_SAMPLE_FMT, AV_OPT_TYPE_VIDEO_RATE, ///< offset must point to AVRational