diff mbox series

[FFmpeg-devel,1/2] lavc/hw_base_encode: correct the timestamp when input_order = decode_delay

Message ID SY7P282MB4502E845F9A269D35608C361C7DA2@SY7P282MB4502.AUSP282.PROD.OUTLOOK.COM
State New
Headers show
Series [FFmpeg-devel,1/2] lavc/hw_base_encode: correct the timestamp when input_order = decode_delay | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 fail Make fate failed
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Tong Wu July 8, 2024, 3:13 p.m. UTC
Fixed the command line: ffmpeg -hwaccel vaapi -pix_fmt nv12 -s:v
widthxheight -i input.yuv -vf "hwupload" -c:v hevc_vaapi -bf 10 -b_depth 3
-vframes 3 -f null -

Signed-off-by: Tong Wu <wutong1208@outlook.com>
---
 libavcodec/hw_base_encode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tong Wu July 19, 2024, 1:45 p.m. UTC | #1
>From: Tong Wu <wutong1208@outlook.com>
>Sent: 2024年7月8日 23:13
>To: ffmpeg-devel@ffmpeg.org
>Cc: Tong Wu <wutong1208@outlook.com>
>Subject: [FFmpeg-devel][PATCH 1/2] lavc/hw_base_encode: correct the
>timestamp when input_order = decode_delay
>
>Fixed the command line: ffmpeg -hwaccel vaapi -pix_fmt nv12 -s:v
>widthxheight -i input.yuv -vf "hwupload" -c:v hevc_vaapi -bf 10 -b_depth 3 -
>vframes 3 -f null -
>
>Signed-off-by: Tong Wu <wutong1208@outlook.com>
>---
> libavcodec/hw_base_encode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/libavcodec/hw_base_encode.c b/libavcodec/hw_base_encode.c
>index ecb4be6aa4..869096caea 100644
>--- a/libavcodec/hw_base_encode.c
>+++ b/libavcodec/hw_base_encode.c
>@@ -472,7 +472,7 @@ static int
>hw_base_encode_send_frame(AVCodecContext *avctx,
>FFHWBaseEncodeContex
>
>         // Fix timestamps if we hit end-of-stream before the initial decode
>         // delay has elapsed.
>-        if (ctx->input_order < ctx->decode_delay)
>+        if (ctx->input_order <= ctx->decode_delay)
>             ctx->dts_pts_diff = ctx->pic_end->pts - ctx->first_pts;
>     }
>
>--
>2.45.1.windows.1


Ping. Is there any comment on this patchset?
Lynne July 20, 2024, 9:22 a.m. UTC | #2
On 19/07/2024 15:45, Tong Wu wrote:
> 
>> From: Tong Wu <wutong1208@outlook.com>
>> Sent: 2024年7月8日 23:13
>> To: ffmpeg-devel@ffmpeg.org
>> Cc: Tong Wu <wutong1208@outlook.com>
>> Subject: [FFmpeg-devel][PATCH 1/2] lavc/hw_base_encode: correct the
>> timestamp when input_order = decode_delay
>>
>> Fixed the command line: ffmpeg -hwaccel vaapi -pix_fmt nv12 -s:v
>> widthxheight -i input.yuv -vf "hwupload" -c:v hevc_vaapi -bf 10 -b_depth 3 -
>> vframes 3 -f null -
>>
>> Signed-off-by: Tong Wu <wutong1208@outlook.com>
>> ---
>> libavcodec/hw_base_encode.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavcodec/hw_base_encode.c b/libavcodec/hw_base_encode.c
>> index ecb4be6aa4..869096caea 100644
>> --- a/libavcodec/hw_base_encode.c
>> +++ b/libavcodec/hw_base_encode.c
>> @@ -472,7 +472,7 @@ static int
>> hw_base_encode_send_frame(AVCodecContext *avctx,
>> FFHWBaseEncodeContex
>>
>>          // Fix timestamps if we hit end-of-stream before the initial decode
>>          // delay has elapsed.
>> -        if (ctx->input_order < ctx->decode_delay)
>> +        if (ctx->input_order <= ctx->decode_delay)
>>              ctx->dts_pts_diff = ctx->pic_end->pts - ctx->first_pts;
>>      }
>>
>> --
>> 2.45.1.windows.1
> 
> 
> Ping. Is there any comment on this patchset?
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Sorry, didn't notice the patch. Pushed.
Thanks!
diff mbox series

Patch

diff --git a/libavcodec/hw_base_encode.c b/libavcodec/hw_base_encode.c
index ecb4be6aa4..869096caea 100644
--- a/libavcodec/hw_base_encode.c
+++ b/libavcodec/hw_base_encode.c
@@ -472,7 +472,7 @@  static int hw_base_encode_send_frame(AVCodecContext *avctx, FFHWBaseEncodeContex
 
         // Fix timestamps if we hit end-of-stream before the initial decode
         // delay has elapsed.
-        if (ctx->input_order < ctx->decode_delay)
+        if (ctx->input_order <= ctx->decode_delay)
             ctx->dts_pts_diff = ctx->pic_end->pts - ctx->first_pts;
     }