diff mbox series

[FFmpeg-devel,v3,09/17] avcodec/codec_internal: nuke init_static_data()

Message ID 20240830102402.18149-10-ffmpeg@haasn.xyz
State New
Headers show
Series Add avcodec_get_supported_config() | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 fail Make fate failed
andriy/make_x86 success Make finished
andriy/make_fate_x86 fail Make fate failed

Commit Message

Niklas Haas Aug. 30, 2024, 10:15 a.m. UTC 
From: Niklas Haas <git@haasn.dev>

All hail get_supported_config()
---
 libavcodec/allcodecs.c      | 7 +------
 libavcodec/codec_internal.h | 8 --------
 2 files changed, 1 insertion(+), 14 deletions(-)

Comments

Anton Khirnov Sept. 2, 2024, 2:33 p.m. UTC | #1 
Quoting Niklas Haas (2024-08-30 12:15:32)
> From: Niklas Haas <git@haasn.dev>
> 
> All hail get_supported_config()

\o/
diff mbox series

Patch

diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
index 60b1278830..66ea502cf4 100644
--- a/libavcodec/allcodecs.c
+++ b/libavcodec/allcodecs.c
@@ -910,13 +910,8 @@  static AVOnce av_codec_static_init = AV_ONCE_INIT;
 static void av_codec_init_static(void)
 {
     for (int i = 0; codec_list[i]; i++) {
-        const FFCodec *codec = codec_list[i];
-        if (codec->init_static_data) {
-            codec->init_static_data((FFCodec*) codec);
-            continue;
-        }
-
         /* Backward compatibility with deprecated public fields */
+        const FFCodec *codec = codec_list[i];
         if (!codec->get_supported_config)
             continue;
 
diff --git a/libavcodec/codec_internal.h b/libavcodec/codec_internal.h
index 84a4376753..8443c51d71 100644
--- a/libavcodec/codec_internal.h
+++ b/libavcodec/codec_internal.h
@@ -173,14 +173,6 @@  typedef struct FFCodec {
      */
     const FFCodecDefault *defaults;
 
-    /**
-     * Initialize codec static data, called from av_codec_iterate().
-     *
-     * This is not intended for time consuming operations as it is
-     * run for every codec regardless of that codec being used.
-     */
-    void (*init_static_data)(struct FFCodec *codec);
-
     int (*init)(struct AVCodecContext *);
 
     union {