[FFmpeg-devel] lavc/cfhd: Drop an unused function

Submitted by Carl Eugen Hoyos on Aug. 23, 2018, 2 p.m.

Details

Message ID CAB0OVGpF=spsSY=Z7HmAx+gUJ5_gmB7Md2_w9ojtVqP_jrSb=w@mail.gmail.com
State New
Headers show

Commit Message

Carl Eugen Hoyos Aug. 23, 2018, 2 p.m.
Hi!

Attached patch removes an unused function from cfhd.c.

Please comment, Carl Eugen

Comments

Paul B Mahol Aug. 23, 2018, 2:03 p.m.
On 8/23/18, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
> Hi!
>
> Attached patch removes an unused function from cfhd.c.
>
> Please comment, Carl Eugen
>

Not acceptable. Function is needed, but was dropped due programmer's error.
Gagandeep Singh Aug. 23, 2018, 3:43 p.m.
On Thu, Aug 23, 2018 at 7:33 PM Paul B Mahol <onemda@gmail.com> wrote:

> On 8/23/18, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
> > Hi!
> >
> > Attached patch removes an unused function from cfhd.c.
> >
> > Please comment, Carl Eugen
> >
>
> Not acceptable. Function is needed, but was dropped due programmer's error.
>
I just noticed. Will add it back in the updated patch that i will work on
saturday.

Thanks.

Gagandeep Singh

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
Paul B Mahol Aug. 30, 2018, 8:19 a.m.
On 8/23/18, Gagandeep Singh <deepgagan231197@gmail.com> wrote:
> On Thu, Aug 23, 2018 at 7:33 PM Paul B Mahol <onemda@gmail.com> wrote:
>
>> On 8/23/18, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
>> > Hi!
>> >
>> > Attached patch removes an unused function from cfhd.c.
>> >
>> > Please comment, Carl Eugen
>> >
>>
>> Not acceptable. Function is needed, but was dropped due programmer's
>> error.
>>
> I just noticed. Will add it back in the updated patch that i will work on
> saturday.

So, you worked out something?
Carl Eugen Hoyos Jan. 14, 2019, 4:14 p.m.
2018-08-23 16:00 GMT+02:00, Carl Eugen Hoyos <ceffmpeg@gmail.com>:

> Attached patch removes an unused function from cfhd.c.

Ping, the function seems less needed than expected (and
can be resurrected anytime).

Carl Eugen
Paul B Mahol Jan. 14, 2019, 4:39 p.m.
On 1/14/19, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
> 2018-08-23 16:00 GMT+02:00, Carl Eugen Hoyos <ceffmpeg@gmail.com>:
>
>> Attached patch removes an unused function from cfhd.c.
>
> Ping, the function seems less needed than expected (and
> can be resurrected anytime).
>
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

NACK

Please refrain from pinging this patch.
Carl Eugen Hoyos Jan. 14, 2019, 5:20 p.m.
2019-01-14 17:39 GMT+01:00, Paul B Mahol <onemda@gmail.com>:
> On 1/14/19, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
>> 2018-08-23 16:00 GMT+02:00, Carl Eugen Hoyos <ceffmpeg@gmail.com>:
>>
>>> Attached patch removes an unused function from cfhd.c.
>>
>> Ping, the function seems less needed than expected (and
>> can be resurrected anytime).

> NACK
>
> Please refrain from pinging this patch.

What do you suggest?

Carl Eugen
Paul B Mahol Jan. 14, 2019, 5:26 p.m.
On 1/14/19, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
> 2019-01-14 17:39 GMT+01:00, Paul B Mahol <onemda@gmail.com>:
>> On 1/14/19, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
>>> 2018-08-23 16:00 GMT+02:00, Carl Eugen Hoyos <ceffmpeg@gmail.com>:
>>>
>>>> Attached patch removes an unused function from cfhd.c.
>>>
>>> Ping, the function seems less needed than expected (and
>>> can be resurrected anytime).
>
>> NACK
>>
>> Please refrain from pinging this patch.
>
> What do you suggest?

Fix it properly, by reusing function obviously.

Patch hide | download patch | download mbox

From 191c7baea8b820d07bbcf1ddb50ffcff8f6c6a08 Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
Date: Thu, 23 Aug 2018 15:56:06 +0200
Subject: [PATCH] lavc/cfhd: Remove an unused function.

---
 libavcodec/cfhd.c |   14 --------------
 1 file changed, 14 deletions(-)

diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c
index 846d334..616f5af 100644
--- a/libavcodec/cfhd.c
+++ b/libavcodec/cfhd.c
@@ -136,20 +136,6 @@  static inline void peak_table(int16_t *band, Peak *peak, int length)
             band[i] = bytestream2_get_le16(&peak->base);
 }
 
-static inline void process_alpha(int16_t *alpha, int width)
-{
-    int i, channel;
-    for (i = 0; i < width; i++) {
-        channel   = alpha[i];
-        channel  -= ALPHA_COMPAND_DC_OFFSET;
-        channel <<= 3;
-        channel  *= ALPHA_COMPAND_GAIN;
-        channel >>= 16;
-        channel   = av_clip_uintp2(channel, 12);
-        alpha[i]  = channel;
-    }
-}
-
 static inline void filter(int16_t *output, ptrdiff_t out_stride,
                           int16_t *low, ptrdiff_t low_stride,
                           int16_t *high, ptrdiff_t high_stride,
-- 
1.7.10.4