[FFmpeg-devel] configure: Do not use -fomit-frame-pointer on sparc

Submitted by Carl Eugen Hoyos on Sept. 8, 2018, 11:03 p.m.

Details

Message ID CAB0OVGq=0PvDOcfv_Ytib2fLML3vvU4NeKZ4mocCsXYVodq44g@mail.gmail.com
State New
Headers show

Commit Message

Carl Eugen Hoyos Sept. 8, 2018, 11:03 p.m.
Hi!

Attached patch fixes many warnings when compiling for sparc.

Please comment, Carl Eugen

Comments

Michael Niedermayer Sept. 9, 2018, 12:39 a.m.
On Sun, Sep 09, 2018 at 01:03:36AM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch fixes many warnings when compiling for sparc.
> 
> Please comment, Carl Eugen

>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 92a4853fbf697e9528ab000924a001fd6366b279  0001-configure-Do-not-use-fomit-frame-pointer-on-sparc.patch
> From 9239602b04abb2ee7b986897923a929a2e6a5028 Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
> Date: Sun, 9 Sep 2018 01:01:24 +0200
> Subject: [PATCH] configure: Do not use -fomit-frame-pointer on sparc.
> 
> Silences many warnings on compilation.

can you show some examples of these warnings ?
(its hard to review this without knowing what warnings this is about
 exactly i think)
 
thx

[...]
Carl Eugen Hoyos Sept. 9, 2018, 2:03 p.m.
2018-09-09 2:39 GMT+02:00, Michael Niedermayer <michael@niedermayer.cc>:
> On Sun, Sep 09, 2018 at 01:03:36AM +0200, Carl Eugen Hoyos wrote:
>> Hi!
>>
>> Attached patch fixes many warnings when compiling for sparc.
>>
>> Please comment, Carl Eugen
>
>>  configure |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 92a4853fbf697e9528ab000924a001fd6366b279
>> 0001-configure-Do-not-use-fomit-frame-pointer-on-sparc.patch
>> From 9239602b04abb2ee7b986897923a929a2e6a5028 Mon Sep 17 00:00:00 2001
>> From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
>> Date: Sun, 9 Sep 2018 01:01:24 +0200
>> Subject: [PATCH] configure: Do not use -fomit-frame-pointer on sparc.
>>
>> Silences many warnings on compilation.
>
> can you show some examples of these warnings ?

The warning for every C file when using the Sun Studio / Oracle Studio
compiler is:
cc: Warning: frameptr value of the xregs option is not available on
SPARC Solaris, ignored.
cc: Warning: illegal use of -xregs option, empty value ignored

Added locally to the commit message.

Carl Eugen

Patch hide | download patch | download mbox

From 9239602b04abb2ee7b986897923a929a2e6a5028 Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
Date: Sun, 9 Sep 2018 01:01:24 +0200
Subject: [PATCH] configure: Do not use -fomit-frame-pointer on sparc.

Silences many warnings on compilation.
---
 configure |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 0d6ee0a..556414e 100755
--- a/configure
+++ b/configure
@@ -5471,7 +5471,7 @@  set_default libdir
 set_default $PATHS_LIST
 set_default nm
 
-disabled optimizations || enabled ossfuzz || check_cflags -fomit-frame-pointer
+disabled optimizations || enabled ossfuzz || enabled sparc || check_cflags -fomit-frame-pointer
 
 enable_weak_pic() {
     disabled pic && return
-- 
1.7.10.4