| Message ID | 20180930204513.26772-4-cus@passwd.hu |
|---|---|
| State | Accepted |
| Headers | show |
On Sun, Sep 30, 2018 at 10:45:12PM +0200, Marton Balint wrote: > These are buggy for now... > > Signed-off-by: Marton Balint <cus@passwd.hu> > --- > libavutil/tests/parseutils.c | 4 ++++ > tests/ref/fate/parseutils | 4 ++++ > 2 files changed, 8 insertions(+) This patch should only be pushed when the one fixing these issues is otherwise we might have test failures from these buggy cases behaving differently across platforms [...]
On Wed, 3 Oct 2018, Michael Niedermayer wrote: > On Sun, Sep 30, 2018 at 10:45:12PM +0200, Marton Balint wrote: >> These are buggy for now... >> >> Signed-off-by: Marton Balint <cus@passwd.hu> >> --- >> libavutil/tests/parseutils.c | 4 ++++ >> tests/ref/fate/parseutils | 4 ++++ >> 2 files changed, 8 insertions(+) > > This patch should only be pushed when the one fixing these issues is > otherwise we might have test failures from these buggy cases behaving > differently across platforms Ok, pushed the series with reversed order of patch 4 and 5. Thanks, Marton
diff --git a/libavutil/tests/parseutils.c b/libavutil/tests/parseutils.c index 180f624002..a1ac8d44e2 100644 --- a/libavutil/tests/parseutils.c +++ b/libavutil/tests/parseutils.c @@ -185,6 +185,10 @@ static void test_av_parse_time(void) "42.1729", "-1729.42", "12:34", + "2147483648s", + "4294967296ms", + "8589934592us", + "9223372036854775808us", }; av_log_set_level(AV_LOG_DEBUG); diff --git a/tests/ref/fate/parseutils b/tests/ref/fate/parseutils index 568b6d28be..36db4fa8a0 100644 --- a/tests/ref/fate/parseutils +++ b/tests/ref/fate/parseutils @@ -90,6 +90,10 @@ now -> 1331972053.200000 = 2012-03-17T08:14:13Z 42.1729 -> +42172900 -1729.42 -> -1729420000 12:34 -> +754000000 +2147483648s -> -2147483648000000 +4294967296ms -> +0 +8589934592us -> +0 +9223372036854775808us -> -1 Testing av_get_known_color_name() AliceBlue -> R(240) G(248) B(255) A(0)
These are buggy for now... Signed-off-by: Marton Balint <cus@passwd.hu> --- libavutil/tests/parseutils.c | 4 ++++ tests/ref/fate/parseutils | 4 ++++ 2 files changed, 8 insertions(+)