[FFmpeg-devel] removing comma at final enumeration items to fix pedantic warnings

Submitted by Michael Behrisch on Oct. 21, 2016, 8:32 a.m.

Details

Message ID 5c9b89aa-e659-0eaf-ee40-2bdc86a08def@behrisch.de
State New
Headers show

Commit Message

Michael Behrisch Oct. 21, 2016, 8:32 a.m.
Am 20.10.2016 um 10:00 schrieb Clément Bœsch:
> On Thu, Oct 20, 2016 at 09:55:17AM +0200, Nicolas George wrote:
>> Le nonidi 29 vendémiaire, an CCXXV, Clement Boesch a écrit :
>>> it's really a trivial and harmless patch.
>>
>> Which is not enough to accept it.
>>
> 
> but the patch is perfectly fine and semantically more correct (it
> explicits that it's wrong to add entry afterward).
> 
>> I am sure there are better uses of contributors' time than that.
>>
> 
> people are free to do whatever they feel like; you're just wasting yours
> by bikeshedding about this stuff you could just ignore.
> 

So here is the patch again, this time without the line breaks, hopefully.

Best regards,
Michael
---
 libavutil/log.h    |  2 +-
 libavutil/pixfmt.h | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

Comments

Michael Behrisch Oct. 25, 2016, 10:58 p.m.
Hi all,

Am 21.10.2016 um 10:32 schrieb Michael Behrisch:
> Am 20.10.2016 um 10:00 schrieb Clément Bœsch:
>> On Thu, Oct 20, 2016 at 09:55:17AM +0200, Nicolas George wrote:
>>> Le nonidi 29 vendémiaire, an CCXXV, Clement Boesch a écrit :
>>>> it's really a trivial and harmless patch.
>>> 
>>> Which is not enough to accept it.
>>> 
>> 
>> but the patch is perfectly fine and semantically more correct (it 
>> explicits that it's wrong to add entry afterward).
>> 
>>> I am sure there are better uses of contributors' time than that.
>>> 
>> 
>> people are free to do whatever they feel like; you're just wasting
>> yours by bikeshedding about this stuff you could just ignore.
>> 
> 
> So here is the patch again, this time without the line breaks,
> hopefully.

does the lack of further reaction mean that the patch was rejected or
does the discussion continue elsewhere?

Best regards,
Michael
Clément Bœsch Oct. 26, 2016, 5:43 p.m.
On Fri, Oct 21, 2016 at 10:32:58AM +0200, Michael Behrisch wrote:
> Am 20.10.2016 um 10:00 schrieb Clément Bœsch:
> > On Thu, Oct 20, 2016 at 09:55:17AM +0200, Nicolas George wrote:
> >> Le nonidi 29 vendémiaire, an CCXXV, Clement Boesch a écrit :
> >>> it's really a trivial and harmless patch.
> >>
> >> Which is not enough to accept it.
> >>
> > 
> > but the patch is perfectly fine and semantically more correct (it
> > explicits that it's wrong to add entry afterward).
> > 
> >> I am sure there are better uses of contributors' time than that.
> >>
> > 
> > people are free to do whatever they feel like; you're just wasting yours
> > by bikeshedding about this stuff you could just ignore.
> > 
> 
> So here is the patch again, this time without the line breaks, hopefully.
> 
> Best regards,
> Michael
> 

> Date: Thu, 20 Oct 2016 08:48:25 +0200
> From: Michael Behrisch <oss@behrisch.de>
> To: ffmpeg-devel@ffmpeg.org
> Cc: Michael Behrisch <oss@behrisch.de>
> Subject: [PATCH] removing comma at final enumeration items to fix pedantic
>  warnings
> X-Mailer: git-send-email 2.6.6
> 

Reworded the commit message and applied.

thanks

Patch hide | download patch | download mbox

diff --git a/libavutil/log.h b/libavutil/log.h
index 0acc1b9..f0a5738 100644
--- a/libavutil/log.h
+++ b/libavutil/log.h
@@ -44,7 +44,7 @@  typedef enum {
     AV_CLASS_CATEGORY_DEVICE_AUDIO_INPUT,
     AV_CLASS_CATEGORY_DEVICE_OUTPUT,
     AV_CLASS_CATEGORY_DEVICE_INPUT,
-    AV_CLASS_CATEGORY_NB, ///< not part of ABI/API
+    AV_CLASS_CATEGORY_NB  ///< not part of ABI/API
 }AVClassCategory;
 
 #define AV_IS_INPUT_DEVICE(category) \
diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h
index b15c0ef..7a3f68b 100644
--- a/libavutil/pixfmt.h
+++ b/libavutil/pixfmt.h
@@ -306,7 +306,7 @@  enum AVPixelFormat {
 
     AV_PIX_FMT_MEDIACODEC, ///< hardware decoding through MediaCodec
 
-    AV_PIX_FMT_NB,        ///< number of pixel formats, DO NOT USE THIS if you want to link with shared libav* because the number of formats might differ between versions
+    AV_PIX_FMT_NB         ///< number of pixel formats, DO NOT USE THIS if you want to link with shared libav* because the number of formats might differ between versions
 };
 
 #if AV_HAVE_BIGENDIAN
@@ -401,7 +401,7 @@  enum AVColorPrimaries {
     AVCOL_PRI_SMPTEST428_1 = 10, ///< SMPTE ST 428-1 (CIE 1931 XYZ)
     AVCOL_PRI_SMPTE431    = 11, ///< SMPTE ST 431-2 (2011)
     AVCOL_PRI_SMPTE432    = 12, ///< SMPTE ST 432-1 D65 (2010)
-    AVCOL_PRI_NB,               ///< Not part of ABI
+    AVCOL_PRI_NB                ///< Not part of ABI
 };
 
 /**
@@ -427,7 +427,7 @@  enum AVColorTransferCharacteristic {
     AVCOL_TRC_SMPTEST2084  = 16, ///< SMPTE ST 2084 for 10-, 12-, 14- and 16-bit systems
     AVCOL_TRC_SMPTEST428_1 = 17, ///< SMPTE ST 428-1
     AVCOL_TRC_ARIB_STD_B67 = 18, ///< ARIB STD-B67, known as "Hybrid log-gamma"
-    AVCOL_TRC_NB,                ///< Not part of ABI
+    AVCOL_TRC_NB                 ///< Not part of ABI
 };
 
 /**
@@ -446,7 +446,7 @@  enum AVColorSpace {
     AVCOL_SPC_BT2020_NCL  = 9,  ///< ITU-R BT2020 non-constant luminance system
     AVCOL_SPC_BT2020_CL   = 10, ///< ITU-R BT2020 constant luminance system
     AVCOL_SPC_SMPTE2085   = 11, ///< SMPTE 2085, Y'D'zD'x
-    AVCOL_SPC_NB,               ///< Not part of ABI
+    AVCOL_SPC_NB                ///< Not part of ABI
 };
 #define AVCOL_SPC_YCGCO AVCOL_SPC_YCOCG
 
@@ -458,7 +458,7 @@  enum AVColorRange {
     AVCOL_RANGE_UNSPECIFIED = 0,
     AVCOL_RANGE_MPEG        = 1, ///< the normal 219*2^(n-8) "MPEG" YUV ranges
     AVCOL_RANGE_JPEG        = 2, ///< the normal     2^n-1   "JPEG" YUV ranges
-    AVCOL_RANGE_NB,              ///< Not part of ABI
+    AVCOL_RANGE_NB               ///< Not part of ABI
 };
 
 /**
@@ -484,7 +484,7 @@  enum AVChromaLocation {
     AVCHROMA_LOC_TOP         = 4,
     AVCHROMA_LOC_BOTTOMLEFT  = 5,
     AVCHROMA_LOC_BOTTOM      = 6,
-    AVCHROMA_LOC_NB,              ///< Not part of ABI
+    AVCHROMA_LOC_NB               ///< Not part of ABI
 };
 
 #endif /* AVUTIL_PIXFMT_H */