| Message ID | 20181117223908.31954-1-cus@passwd.hu |
|---|---|
| State | Accepted |
| Commit | e3a96309826dd0ea33db0300f7c75414fdbea0a4 |
| Headers | show |
On Sat, Nov 17, 2018 at 11:39:08PM +0100, Marton Balint wrote: > Fixes ticket #7494. > > Signed-off-by: Marton Balint <cus@passwd.hu> > --- > libavcodec/mpeg_er.c | 2 ++ > 1 file changed, 2 insertions(+) probably ok a fate test covering this case if its stable should be added too. thx [...]
On Sun, 18 Nov 2018, Michael Niedermayer wrote: > On Sat, Nov 17, 2018 at 11:39:08PM +0100, Marton Balint wrote: >> Fixes ticket #7494. >> >> Signed-off-by: Marton Balint <cus@passwd.hu> >> --- >> libavcodec/mpeg_er.c | 2 ++ >> 1 file changed, 2 insertions(+) > > probably ok Thanks, applied and backported to 4.1. > > a fate test covering this case if its stable should be added too. I think the project should pay somebody to create fate tests from fixed tickets, or offer doing this as a project for outreachy/whatever, because even less experienced developers can do it and it improves quality a lot. Regards, Marton
diff --git a/libavcodec/mpeg_er.c b/libavcodec/mpeg_er.c index ada1a1692f..f54cb8548b 100644 --- a/libavcodec/mpeg_er.c +++ b/libavcodec/mpeg_er.c @@ -78,6 +78,8 @@ static void mpeg_er_decode_mb(void *opaque, int ref, int mv_dir, int mv_type, ff_update_block_index(s); s->bdsp.clear_blocks(s->block[0]); + if (!s->chroma_y_shift) + s->bdsp.clear_blocks(s->block[6]); s->dest[0] = s->current_picture.f->data[0] + s->mb_y * 16 * s->linesize +
Fixes ticket #7494. Signed-off-by: Marton Balint <cus@passwd.hu> --- libavcodec/mpeg_er.c | 2 ++ 1 file changed, 2 insertions(+)