diff mbox

[FFmpeg-devel] configure: select rotation filters for ffmpeg

Message ID 77044f2e-b3e5-8421-8c75-b8c0799ccd43@gyani.pro
State Accepted
Commit fda793f6fa7678e36b00eeea12343f90da75bfcb
Headers show

Commit Message

Gyan Doshi March 2, 2019, 3:33 p.m. UTC
From fda793f6fa7678e36b00eeea12343f90da75bfcb Mon Sep 17 00:00:00 2001
From: Gyan Doshi <ffmpeg@gyani.pro>
Date: Sat, 2 Mar 2019 20:49:12 +0530
Subject: [PATCH] configure: select rotation filters for ffmpeg

autorotate is enabled by default in ffmpeg so the rotation filters
are required and will be attempted for insertion without the user's
knowledge if an input stream has rotation side-data.
---
 configure | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Michael Niedermayer March 2, 2019, 10:21 p.m. UTC | #1
On Sat, Mar 02, 2019 at 09:03:18PM +0530, Gyan wrote:
> 

>  configure |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 4b5163db4a15d9d6caaebb35d11fac16a5c64f37  0001-configure-select-rotation-filters-for-ffmpeg.patch
> From fda793f6fa7678e36b00eeea12343f90da75bfcb Mon Sep 17 00:00:00 2001
> From: Gyan Doshi <ffmpeg@gyani.pro>
> Date: Sat, 2 Mar 2019 20:49:12 +0530
> Subject: [PATCH] configure: select rotation filters for ffmpeg
> 
> autorotate is enabled by default in ffmpeg so the rotation filters
> are required and will be attempted for insertion without the user's
> knowledge if an input stream has rotation side-data.
> ---
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index bbeaf2fadc..3042ab9176 100755
> --- a/configure
> +++ b/configure
> @@ -3595,8 +3595,8 @@ avutil_extralibs="d3d11va_extralibs nanosleep_extralibs pthreads_extralibs vaapi
>  # programs
>  ffmpeg_deps="avcodec avfilter avformat"
>  ffmpeg_select="aformat_filter anull_filter atrim_filter format_filter
> -               null_filter
> -               trim_filter"
> +               hflip_filter null_filter
> +               transpose_filter trim_filter vflip_filter"
>  ffmpeg_suggest="ole32 psapi shell32"
>  ffplay_deps="avcodec avformat swscale swresample sdl2"
>  ffplay_select="rdft crop_filter transpose_filter hflip_filter vflip_filter rotate_filter"

LGTM

thx

[...]
Gyan Doshi March 3, 2019, 5:09 a.m. UTC | #2
On 03-03-2019 03:51 AM, Michael Niedermayer wrote:
> On Sat, Mar 02, 2019 at 09:03:18PM +0530, Gyan wrote:
>>   configure |    4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>> 4b5163db4a15d9d6caaebb35d11fac16a5c64f37  0001-configure-select-rotation-filters-for-ffmpeg.patch
>>  From fda793f6fa7678e36b00eeea12343f90da75bfcb Mon Sep 17 00:00:00 2001
>> From: Gyan Doshi <ffmpeg@gyani.pro>
>> Date: Sat, 2 Mar 2019 20:49:12 +0530
>> Subject: [PATCH] configure: select rotation filters for ffmpeg
>>
>> autorotate is enabled by default in ffmpeg so the rotation filters
>> are required and will be attempted for insertion without the user's
>> knowledge if an input stream has rotation side-data.
>> ---
>>   configure | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/configure b/configure
>> index bbeaf2fadc..3042ab9176 100755
>> --- a/configure
>> +++ b/configure
>> @@ -3595,8 +3595,8 @@ avutil_extralibs="d3d11va_extralibs nanosleep_extralibs pthreads_extralibs vaapi
>>   # programs
>>   ffmpeg_deps="avcodec avfilter avformat"
>>   ffmpeg_select="aformat_filter anull_filter atrim_filter format_filter
>> -               null_filter
>> -               trim_filter"
>> +               hflip_filter null_filter
>> +               transpose_filter trim_filter vflip_filter"
>>   ffmpeg_suggest="ole32 psapi shell32"
>>   ffplay_deps="avcodec avformat swscale swresample sdl2"
>>   ffplay_select="rdft crop_filter transpose_filter hflip_filter vflip_filter rotate_filter"
> LGTM
Pushed as fda793f6fa7678e36b00eeea12343f90da75bfcb

Thanks,
Gyan
diff mbox

Patch

diff --git a/configure b/configure
index bbeaf2fadc..3042ab9176 100755
--- a/configure
+++ b/configure
@@ -3595,8 +3595,8 @@  avutil_extralibs="d3d11va_extralibs nanosleep_extralibs pthreads_extralibs vaapi
 # programs
 ffmpeg_deps="avcodec avfilter avformat"
 ffmpeg_select="aformat_filter anull_filter atrim_filter format_filter
-               null_filter
-               trim_filter"
+               hflip_filter null_filter
+               transpose_filter trim_filter vflip_filter"
 ffmpeg_suggest="ole32 psapi shell32"
 ffplay_deps="avcodec avformat swscale swresample sdl2"
 ffplay_select="rdft crop_filter transpose_filter hflip_filter vflip_filter rotate_filter"