| Message ID | 20190414165104.24738-1-cus@passwd.hu |
|---|---|
| State | Accepted |
| Commit | f9840cd2b501fe7956155542be5afb4432530903 |
| Headers | show |
sön 2019-04-14 klockan 18:51 +0200 skrev Marton Balint: > This makes it more consistent with other metadata keys. > > Signed-off-by: Marton Balint <cus@passwd.hu> > --- > libavformat/mxfdec.c | 2 +- > tests/ref/fate/mxf-probe-d10 | 2 +- > tests/ref/fate/mxf-probe-dnxhd | 2 +- > tests/ref/fate/mxf-probe-dv25 | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > index 8c65a2bbcf..3ea8de1666 100644 > --- a/libavformat/mxfdec.c > +++ b/libavformat/mxfdec.c > @@ -722,7 +722,7 @@ static int mxf_read_partition_pack(void *arg, > AVIOContext *pb, int tag, int size > if (partition->type == Header) { > char str[36]; > snprintf(str, sizeof(str), "%08x.%08x.%08x.%08x", > AV_RB32(&op[0]), AV_RB32(&op[4]), AV_RB32(&op[8]), AV_RB32(&op[12])); > - av_dict_set(&s->metadata, "operational_pattern", str, 0); > + av_dict_set(&s->metadata, "operational_pattern_ul", str, 0); OK for me /Tomas
On Sun, 14 Apr 2019, Tomas Härdin wrote: > sön 2019-04-14 klockan 18:51 +0200 skrev Marton Balint: >> This makes it more consistent with other metadata keys. >> >> Signed-off-by: Marton Balint <cus@passwd.hu> >> --- >> libavformat/mxfdec.c | 2 +- >> tests/ref/fate/mxf-probe-d10 | 2 +- >> tests/ref/fate/mxf-probe-dnxhd | 2 +- >> tests/ref/fate/mxf-probe-dv25 | 2 +- >> 4 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c >> index 8c65a2bbcf..3ea8de1666 100644 >> --- a/libavformat/mxfdec.c >> +++ b/libavformat/mxfdec.c >> @@ -722,7 +722,7 @@ static int mxf_read_partition_pack(void *arg, >> AVIOContext *pb, int tag, int size >> if (partition->type == Header) { >> char str[36]; >> snprintf(str, sizeof(str), "%08x.%08x.%08x.%08x", >> AV_RB32(&op[0]), AV_RB32(&op[4]), AV_RB32(&op[8]), AV_RB32(&op[12])); >> - av_dict_set(&s->metadata, "operational_pattern", str, 0); >> + av_dict_set(&s->metadata, "operational_pattern_ul", str, 0); > > OK for me Thanks, applied. Regards, Marton
diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 8c65a2bbcf..3ea8de1666 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -722,7 +722,7 @@ static int mxf_read_partition_pack(void *arg, AVIOContext *pb, int tag, int size if (partition->type == Header) { char str[36]; snprintf(str, sizeof(str), "%08x.%08x.%08x.%08x", AV_RB32(&op[0]), AV_RB32(&op[4]), AV_RB32(&op[8]), AV_RB32(&op[12])); - av_dict_set(&s->metadata, "operational_pattern", str, 0); + av_dict_set(&s->metadata, "operational_pattern_ul", str, 0); } if (partition->this_partition && diff --git a/tests/ref/fate/mxf-probe-d10 b/tests/ref/fate/mxf-probe-d10 index 9b8a6a688d..ab564467b5 100644 --- a/tests/ref/fate/mxf-probe-d10 +++ b/tests/ref/fate/mxf-probe-d10 @@ -96,7 +96,7 @@ TAG:file_package_umid=0x060A2B340101010501010D1313000000AE86B2009131058000000800 format_name=mxf duration=0.178375 bit_rate=56419744 -TAG:operational_pattern=060e2b34.04010101.0d010201.01010900 +TAG:operational_pattern_ul=060e2b34.04010101.0d010201.01010900 TAG:uid=0086b200-9131-0580-0000-080046a54011 TAG:generation_uid=b486b200-9131-0580-0000-080046a54011 TAG:company_name=SONY diff --git a/tests/ref/fate/mxf-probe-dnxhd b/tests/ref/fate/mxf-probe-dnxhd index 0870270a95..39968ad987 100644 --- a/tests/ref/fate/mxf-probe-dnxhd +++ b/tests/ref/fate/mxf-probe-dnxhd @@ -167,7 +167,7 @@ TAG:timecode=01:00:00:00 format_name=mxf duration=0.250250 bit_rate=25340195 -TAG:operational_pattern=060e2b34.04010102.0d010201.10030000 +TAG:operational_pattern_ul=060e2b34.04010102.0d010201.10030000 TAG:project_name=UHD TAG:uid=784c8132-ae36-ed4d-b0ff-2edf1f3f2d92 TAG:generation_uid=b6bcfcab-70ff-7331-c47c-478869de11d2 diff --git a/tests/ref/fate/mxf-probe-dv25 b/tests/ref/fate/mxf-probe-dv25 index a2e39c8057..00028b08c5 100644 --- a/tests/ref/fate/mxf-probe-dv25 +++ b/tests/ref/fate/mxf-probe-dv25 @@ -137,7 +137,7 @@ TAG:file_package_umid=0x060A2B340101010501010D4313000000F2E2FCE98722F14F947F08DE format_name=mxf duration=1.000000 bit_rate=30679040 -TAG:operational_pattern=060e2b34.04010101.0d010201.01010900 +TAG:operational_pattern_ul=060e2b34.04010101.0d010201.01010900 TAG:uid=a741d0c7-244a-bc4a-bd36-3323d04f8954 TAG:generation_uid=c1d7a0ee-89d6-754d-bd52-cdf42b53de9f TAG:company_name=AVID
This makes it more consistent with other metadata keys. Signed-off-by: Marton Balint <cus@passwd.hu> --- libavformat/mxfdec.c | 2 +- tests/ref/fate/mxf-probe-d10 | 2 +- tests/ref/fate/mxf-probe-dnxhd | 2 +- tests/ref/fate/mxf-probe-dv25 | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)