diff mbox

[FFmpeg-devel,3/6] avcodec/tta: Fix undefined shift

Message ID 20190616174850.31656-3-michael@niedermayer.cc
State Accepted
Commit ebccd2f778a861b41ad38a8464ea120d4f16b2d7
Headers show

Commit Message

Michael Niedermayer June 16, 2019, 5:48 p.m. UTC 
Fixes: left shift of negative value -4483
Fixes: 15256/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TTA_fuzzer-5738691617619968

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/tta.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/libavcodec/tta.c b/libavcodec/tta.c
index 8f097b3bcc..c7702610b6 100644
--- a/libavcodec/tta.c
+++ b/libavcodec/tta.c
@@ -372,7 +372,7 @@  static int tta_decode_frame(AVCodecContext *avctx, void *data,
         // shift samples for 24-bit sample format
         int32_t *samples = (int32_t *)frame->data[0];
         for (i = 0; i < framelen * s->channels; i++)
-            *samples++ <<= 8;
+            *samples++ *= 256;
         // reset decode buffer
         s->decode_buffer = NULL;
         break;