diff mbox

[FFmpeg-devel,7/7] avcodec/4xm: Fix vlc memleak

Message ID 20190620224721.8480-7-michael@niedermayer.cc
State Accepted
Commit 55557c6124573eb715d6c6eeb1a472b99e91f9d5
Headers show

Commit Message

Michael Niedermayer June 20, 2019, 10:47 p.m. UTC 
Fixes: memleak
Fixes: 15297/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FOURXM_fuzzer-5746203548975104

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/4xm.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Michael Niedermayer June 26, 2019, 7:30 p.m. UTC | #1 
On Fri, Jun 21, 2019 at 12:47:21AM +0200, Michael Niedermayer wrote:
> Fixes: memleak
> Fixes: 15297/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FOURXM_fuzzer-5746203548975104
> 
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/4xm.c | 1 +
>  1 file changed, 1 insertion(+)

will apply

[...]
diff mbox

Patch

diff --git a/libavcodec/4xm.c b/libavcodec/4xm.c
index 2b88c899d0..89120aa8fb 100644
--- a/libavcodec/4xm.c
+++ b/libavcodec/4xm.c
@@ -697,6 +697,7 @@  static const uint8_t *read_huffman_tables(FourXContext *f,
         len_tab[j]  = len;
     }
 
+    ff_free_vlc(&f->pre_vlc);
     if (init_vlc(&f->pre_vlc, ACDC_VLC_BITS, 257, len_tab, 1, 1,
                  bits_tab, 4, 4, 0))
         return NULL;