[FFmpeg-devel] lavu/tx: don't compile double precision transforms on CONFIG_SMALL

Submitted by Lynne on Aug. 2, 2019, 4 p.m.

Details

Message ID LlI2zui--3-1@lynne.ee
State New
Headers show

Commit Message

Lynne Aug. 2, 2019, 4 p.m.
They'll likely only be used in not so small filters, so for embedded users it makes sense to not compile them in.

Comments

Paul B Mahol Aug. 5, 2019, 2:58 p.m.
On Fri, Aug 2, 2019 at 6:01 PM Lynne <dev@lynne.ee> wrote:

> They'll likely only be used in not so small filters, so for embedded users
> it makes sense to not compile them in.
>

I think, CONFIG_SMALL should be removed.


>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Patch hide | download patch | download mbox

From bafb404153641a84224d88598659d554cfdf9543 Mon Sep 17 00:00:00 2001
From: Lynne <dev@lynne.ee>
Date: Fri, 2 Aug 2019 16:58:27 +0100
Subject: [PATCH] lavu/tx: don't compile double precision transforms on
 CONFIG_SMALL

They'll likely only be used in not so small filters, so for embedded users
it makes sense to not compile them in.
---
 libavutil/Makefile | 5 +++--
 libavutil/tx.c     | 3 +++
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/libavutil/Makefile b/libavutil/Makefile
index 57e6e3d7e8..b3f11fc7dc 100644
--- a/libavutil/Makefile
+++ b/libavutil/Makefile
@@ -161,8 +161,9 @@  OBJS = adler32.o                                                        \
        xtea.o                                                           \
        tea.o                                                            \
        tx.o                                                             \
-       tx_float.o                                                       \
-       tx_double.o
+       tx_float.o
+
+OBJS-$(!CONFIG_SMALL)                   += tx_double.o
 
 OBJS-$(CONFIG_CUDA)                     += hwcontext_cuda.o
 OBJS-$(CONFIG_D3D11VA)                  += hwcontext_d3d11va.o
diff --git a/libavutil/tx.c b/libavutil/tx.c
index b8683b416b..2547c9f363 100644
--- a/libavutil/tx.c
+++ b/libavutil/tx.c
@@ -16,6 +16,7 @@ 
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
+#include "config.h"
 #include "tx_priv.h"
 
 /* Calculates the modular multiplicative inverse, not fast, replace */
@@ -123,11 +124,13 @@  av_cold int av_tx_init(AVTXContext **ctx, av_tx_fn *tx, enum AVTXType type,
         if ((err = ff_tx_init_mdct_fft_float(s, tx, type, inv, len, scale, flags)))
             goto fail;
         break;
+#if !CONFIG_SMALL
     case AV_TX_DOUBLE_FFT:
     case AV_TX_DOUBLE_MDCT:
         if ((err = ff_tx_init_mdct_fft_double(s, tx, type, inv, len, scale, flags)))
             goto fail;
         break;
+#endif
     default:
         err = AVERROR(EINVAL);
         goto fail;
-- 
2.23.0.rc0