[FFmpeg-devel,V3] fate: add a case for ticket #3229

Submitted by Zhong Li on Aug. 12, 2019, 6:13 a.m.

Details

Message ID 1565590413-26148-1-git-send-email-zhong.li@intel.com
State Accepted
Commit 8cd96e13eea858108667000d47281b8811042d1b
Headers show

Commit Message

Zhong Li Aug. 12, 2019, 6:13 a.m.
Signed-off-by: Zhong Li <zhong.li@intel.com>
---
https://patchwork.ffmpeg.org/patch/13725/ introduces a regression but not found by fate, so add it.
Test clip produced by:
ffmpeg -i tickets/3229/bad.avi -vframes 3 -c:v copy /fate-suite/mjpeg/mjpeg_field_order.avi

 tests/fate/video.mak            | 3 +++
 tests/ref/fate/mjpeg-ticket3229 | 8 ++++++++
 2 files changed, 11 insertions(+)
 create mode 100644 tests/ref/fate/mjpeg-ticket3229

Comments

Thilo Borgmann Aug. 12, 2019, 7:54 a.m.
Am 12.08.19 um 08:13 schrieb Zhong Li:
> Signed-off-by: Zhong Li <zhong.li@intel.com>
> ---
> https://patchwork.ffmpeg.org/patch/13725/ introduces a regression but not found by fate, so add it.
> Test clip produced by:
> ffmpeg -i tickets/3229/bad.avi -vframes 3 -c:v copy /fate-suite/mjpeg/mjpeg_field_order.avi
> 
>  tests/fate/video.mak            | 3 +++
>  tests/ref/fate/mjpeg-ticket3229 | 8 ++++++++
>  2 files changed, 11 insertions(+)
>  create mode 100644 tests/ref/fate/mjpeg-ticket3229
> [...]

LGTM & sample uploaded.

-Thilo
Zhong Li Aug. 13, 2019, 2:53 a.m.
> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces@ffmpeg.org] On Behalf

> Of Thilo Borgmann

> Sent: Monday, August 12, 2019 3:55 PM

> To: ffmpeg-devel@ffmpeg.org

> Subject: Re: [FFmpeg-devel] [PATCH V3] fate: add a case for ticket #3229

> 

> Am 12.08.19 um 08:13 schrieb Zhong Li:

> > Signed-off-by: Zhong Li <zhong.li@intel.com>

> > ---

> > https://patchwork.ffmpeg.org/patch/13725/ introduces a regression but

> not found by fate, so add it.

> > Test clip produced by:

> > ffmpeg -i tickets/3229/bad.avi -vframes 3 -c:v copy

> > /fate-suite/mjpeg/mjpeg_field_order.avi

> >

> >  tests/fate/video.mak            | 3 +++

> >  tests/ref/fate/mjpeg-ticket3229 | 8 ++++++++

> >  2 files changed, 11 insertions(+)

> >  create mode 100644 tests/ref/fate/mjpeg-ticket3229 [...]

> 

> LGTM & sample uploaded.

> 

> -Thilo


Thanks!
Patch applied.

Patch hide | download patch | download mbox

diff --git a/tests/fate/video.mak b/tests/fate/video.mak
index be1458c..d2d43e5 100644
--- a/tests/fate/video.mak
+++ b/tests/fate/video.mak
@@ -232,6 +232,9 @@  fate-mimic: CMD = framecrc -idct simple -i $(TARGET_SAMPLES)/mimic/mimic2-womanl
 FATE_VIDEO-$(call DEMDEC, MOV, MJPEGB) += fate-mjpegb
 fate-mjpegb: CMD = framecrc -idct simple -fflags +bitexact -i $(TARGET_SAMPLES)/mjpegb/mjpegb_part.mov -an
 
+FATE_VIDEO-$(call DEMDEC, AVI, MJPEG) += fate-mjpeg-ticket3229
+fate-mjpeg-ticket3229: CMD = framecrc -idct simple -fflags +bitexact -i $(TARGET_SAMPLES)/mjpeg/mjpeg_field_order.avi -an
+
 FATE_VIDEO-$(call DEMDEC, MVI, MOTIONPIXELS) += fate-motionpixels
 fate-motionpixels: CMD = framecrc -i $(TARGET_SAMPLES)/motion-pixels/INTRO-partial.MVI -an -pix_fmt rgb24 -frames:v 111
 
diff --git a/tests/ref/fate/mjpeg-ticket3229 b/tests/ref/fate/mjpeg-ticket3229
new file mode 100644
index 0000000..fc5a8dd
--- /dev/null
+++ b/tests/ref/fate/mjpeg-ticket3229
@@ -0,0 +1,8 @@ 
+#tb 0: 1/30
+#media_type 0: video
+#codec_id 0: rawvideo
+#dimensions 0: 468x312
+#sar 0: 0/1
+0,          0,          0,        1,   292032, 0x3af3a5f7
+0,          6,          6,        1,   292032, 0xe97fb504
+0,          8,          8,        1,   292032, 0xd448db04