[FFmpeg-devel,v4,1/2] libavuitl: add A2R10G10B10 & A2B10G10R10

Submitted by Zachary Zhou on Sept. 11, 2019, 5:39 a.m.

Details

Message ID 20190911053956.23488-1-zachary.zhou@intel.com
State New
Headers show

Commit Message

Zachary Zhou Sept. 11, 2019, 5:39 a.m.
---
 libavutil/hwcontext_vaapi.c | 6 ++++++
 libavutil/pixfmt.h          | 3 +++
 2 files changed, 9 insertions(+)

Comments

Linjie Fu Sept. 11, 2019, 5:53 a.m.
> -----Original Message-----

> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces@ffmpeg.org] On Behalf

> Of Zachary Zhou

> Sent: Wednesday, September 11, 2019 13:40

> To: ffmpeg-devel@ffmpeg.org

> Cc: Zhou, Zachary <zachary.zhou@intel.com>

> Subject: [FFmpeg-devel] [PATCH v4 1/2] libavuitl: add A2R10G10B10 &

> A2B10G10R10

> 

> ---

>  libavutil/hwcontext_vaapi.c | 6 ++++++

>  libavutil/pixfmt.h          | 3 +++

>  2 files changed, 9 insertions(+)


Didn't see the difference compared with your V1 patch:
https://patchwork.ffmpeg.org/patch/14998/

Is there something mixed up?

- linjie
Moritz Barsnick Sept. 11, 2019, 7:52 a.m.
On Wed, Sep 11, 2019 at 13:39:55 +0800, Zachary Zhou wrote:
> Subject: [PATCH v4 1/2] libavuitl: add A2R10G10B10 & A2B10G10R10
                          ^
Nit: libavutil

Moritz
Zachary Zhou Sept. 16, 2019, 1:21 a.m.
> -----Original Message-----

> From: Fu, Linjie

> Sent: Wednesday, September 11, 2019 1:54 PM

> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>

> Cc: Zhou, Zachary <zachary.zhou@intel.com>

> Subject: RE: [FFmpeg-devel] [PATCH v4 1/2] libavuitl: add A2R10G10B10 &

> A2B10G10R10

> 

> > -----Original Message-----

> > From: ffmpeg-devel [mailto:ffmpeg-devel-bounces@ffmpeg.org] On Behalf

> > Of Zachary Zhou

> > Sent: Wednesday, September 11, 2019 13:40

> > To: ffmpeg-devel@ffmpeg.org

> > Cc: Zhou, Zachary <zachary.zhou@intel.com>

> > Subject: [FFmpeg-devel] [PATCH v4 1/2] libavuitl: add A2R10G10B10 &

> > A2B10G10R10

> >

> > ---

> >  libavutil/hwcontext_vaapi.c | 6 ++++++

> >  libavutil/pixfmt.h          | 3 +++

> >  2 files changed, 9 insertions(+)

> 

> Didn't see the difference compared with your V1 patch:

> https://patchwork.ffmpeg.org/patch/14998/

> 

> Is there something mixed up?


Thanks Linjie for the review, Yes, they are same.
only reason for the V1 here is I want to the V2 patch build get passed.

> 

> - linjie
Carl Eugen Hoyos Sept. 16, 2019, 11:37 a.m.
Am Mi., 11. Sept. 2019 um 07:40 Uhr schrieb Zachary Zhou
<zachary.zhou@intel.com>:

> +    AV_PIX_FMT_A2R10G10B10, ///< 10-bit Pixel RGB formats.
> +    AV_PIX_FMT_A2B10G10R10, ///< 10-bit Pixel BGR formats.

Without more explanation, this patch is not ok imo.

Carl Eugen

Patch hide | download patch | download mbox

diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c
index cf117640f2..9838250b66 100644
--- a/libavutil/hwcontext_vaapi.c
+++ b/libavutil/hwcontext_vaapi.c
@@ -125,6 +125,12 @@  static const VAAPIFormatDescriptor vaapi_format_map[] = {
 #endif
     MAP(BGRA, RGB32,   BGRA, 0),
     MAP(BGRX, RGB32,   BGR0, 0),
+#ifdef VA_FOURCC_A2R10G10B10
+    MAP(A2R10G10B10, RGB32_10, A2R10G10B10, 0),
+#endif
+#ifdef VA_FOURCC_A2B10G10R10
+    MAP(A2B10G10R10, RGB32_10, A2B10G10R10, 0),
+#endif
     MAP(RGBA, RGB32,   RGBA, 0),
     MAP(RGBX, RGB32,   RGB0, 0),
 #ifdef VA_FOURCC_ABGR
diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h
index d78e863d4b..e00f129b46 100644
--- a/libavutil/pixfmt.h
+++ b/libavutil/pixfmt.h
@@ -348,6 +348,9 @@  enum AVPixelFormat {
     AV_PIX_FMT_NV24,      ///< planar YUV 4:4:4, 24bpp, 1 plane for Y and 1 plane for the UV components, which are interleaved (first byte U and the following byte V)
     AV_PIX_FMT_NV42,      ///< as above, but U and V bytes are swapped
 
+    AV_PIX_FMT_A2R10G10B10, ///< 10-bit Pixel RGB formats.
+    AV_PIX_FMT_A2B10G10R10, ///< 10-bit Pixel BGR formats.
+
     AV_PIX_FMT_NB         ///< number of pixel formats, DO NOT USE THIS if you want to link with shared libav* because the number of formats might differ between versions
 };