[FFmpeg-devel] avutil/opt: Fix type specifier

Submitted by Andreas Rheinhardt on Sept. 21, 2019, 9:15 a.m.

Details

Message ID 20190921091542.21242-1-andreas.rheinhardt@gmail.com
State Accepted
Commit 25a501b5287b5e84121302c41109b0cfdd7785b2
Headers show

Commit Message

Andreas Rheinhardt Sept. 21, 2019, 9:15 a.m.
This bug has been introduced in 9e0a071e.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
---
 libavutil/opt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul B Mahol Sept. 21, 2019, 3:11 p.m.
lgtm

On 9/21/19, Andreas Rheinhardt <andreas.rheinhardt@gmail.com> wrote:
> This bug has been introduced in 9e0a071e.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
> ---
>  libavutil/opt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/opt.c b/libavutil/opt.c
> index 35dc9e153d..7c2649725f 100644
> --- a/libavutil/opt.c
> +++ b/libavutil/opt.c
> @@ -1200,7 +1200,7 @@ static void opt_list(void *obj, void *av_log_obj,
> const char *unit,
>                  break;
>              case AV_OPT_TYPE_CONST:
>                  if (parent_type == AV_OPT_TYPE_INT)
> -                    av_log(av_log_obj, AV_LOG_INFO, "%-12d ",
> opt->default_val.i64);
> +                    av_log(av_log_obj, AV_LOG_INFO, "%-12"PRId64" ",
> opt->default_val.i64);
>                  else
>                      av_log(av_log_obj, AV_LOG_INFO, "%-12s ", "");
>                  break;
> --
> 2.20.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Michael Niedermayer Sept. 22, 2019, 4:17 p.m.
On Sat, Sep 21, 2019 at 05:11:57PM +0200, Paul B Mahol wrote:
> lgtm

will apply

thx

[...]

Patch hide | download patch | download mbox

diff --git a/libavutil/opt.c b/libavutil/opt.c
index 35dc9e153d..7c2649725f 100644
--- a/libavutil/opt.c
+++ b/libavutil/opt.c
@@ -1200,7 +1200,7 @@  static void opt_list(void *obj, void *av_log_obj, const char *unit,
                 break;
             case AV_OPT_TYPE_CONST:
                 if (parent_type == AV_OPT_TYPE_INT)
-                    av_log(av_log_obj, AV_LOG_INFO, "%-12d ", opt->default_val.i64);
+                    av_log(av_log_obj, AV_LOG_INFO, "%-12"PRId64" ", opt->default_val.i64);
                 else
                     av_log(av_log_obj, AV_LOG_INFO, "%-12s ", "");
                 break;