[FFmpeg-devel,1/4] avcodec/apedec: Fix undefined integer overflow in long_filter_ehigh_3830()

Submitted by Michael Niedermayer on Oct. 17, 2019, 10:25 p.m.

Details

Message ID 20191017222515.21382-1-michael@niedermayer.cc
State Accepted
Commit 1d1719a44dd43b2d9d8ccd26e3b2854e675a7bd7
Headers show

Commit Message

Michael Niedermayer Oct. 17, 2019, 10:25 p.m.
Fixes: signed integer overflow: -1094995529 * 2 cannot be represented in type 'int'
Fixes: 18281/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5692589180715008

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/apedec.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c
index 75c6a96437..216e80b6a6 100644
--- a/libavcodec/apedec.c
+++ b/libavcodec/apedec.c
@@ -920,7 +920,8 @@  static void long_filter_ehigh_3830(int32_t *buffer, int length)
 {
     int i, j;
     int32_t dotprod, sign;
-    int32_t coeffs[8] = { 0 }, delay[8] = { 0 };
+    int32_t delay[8] = { 0 };
+    uint32_t coeffs[8] = { 0 };
 
     for (i = 0; i < length; i++) {
         dotprod = 0;