[FFmpeg-devel] doc/filters: Add note on Flite thread safety and update URL

Submitted by Gyan on Oct. 9, 2017, 5:49 a.m.

Details

Message ID fe939636-89b7-7e5a-89f4-4f5e68371b3c@gmail.com
State Accepted
Commit df45ea45df18d909d545cf12769caf85310bebd9
Headers show

Commit Message

Gyan Oct. 9, 2017, 5:49 a.m.
Version 2 of Flite, a speech synthesis library, was released towards the 
end of 2014. Among the notes at the project site: "Thread safe (really 
this time)".

Docs and project URL updated accordingly.
From 8f0de211aaa9e100cbec2b12b4a1668541a76217 Mon Sep 17 00:00:00 2001
From: Gyan Doshi <gyandoshi@gmail.com>
Date: Mon, 9 Oct 2017 11:06:10 +0530
Subject: [PATCH] doc/filters: add note on flite thread safety and update URL

Signed-off-by: Gyan Doshi <gyandoshi@gmail.com>
---
 doc/filters.texi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Gyan Oct. 17, 2017, 5:45 a.m.
On 10/9/2017 11:19 AM, Gyan Doshi wrote:
> Version 2 of Flite, a speech synthesis library, was released towards the 
> end of 2014. Among the notes at the project site: "Thread safe (really 
> this time)".
> 
> Docs and project URL updated accordingly.

Ping.
Moritz Barsnick Oct. 17, 2017, 2:45 p.m.
On Mon, Oct 09, 2017 at 11:19:45 +0530, Gyan Doshi wrote:
> Version 2 of Flite, a speech synthesis library, was released towards the 
> end of 2014. Among the notes at the project site: "Thread safe (really 
> this time)".

BTW, I have a patch flying around for support of flite 1.3. ffmpeg
currently requires >= 1.4, but RedHat/Fedora/EPEL still distribute 1.3
for some stupid reason. They could thereby gain support.

Is this too niche to even consider? (I think I can test, though I
updated my flite locally.)

Sorry for hijacking,
Moritz
Michael Niedermayer Oct. 17, 2017, 11:59 p.m.
On Mon, Oct 09, 2017 at 11:19:45AM +0530, Gyan Doshi wrote:
> Version 2 of Flite, a speech synthesis library, was released towards
> the end of 2014. Among the notes at the project site: "Thread safe
> (really this time)".
> 
> Docs and project URL updated accordingly.

>  filters.texi |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> ad3b82f7e79cb0efcab25820492a86b67d1b5fa3  0001-doc-filters-add-note-on-flite-thread-safety-and-upda.patch
> From 8f0de211aaa9e100cbec2b12b4a1668541a76217 Mon Sep 17 00:00:00 2001
> From: Gyan Doshi <gyandoshi@gmail.com>
> Date: Mon, 9 Oct 2017 11:06:10 +0530
> Subject: [PATCH] doc/filters: add note on flite thread safety and update URL
> 
> Signed-off-by: Gyan Doshi <gyandoshi@gmail.com>
> ---
>  doc/filters.texi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

will apply

thx

[...]

Patch hide | download patch | download mbox

diff --git a/doc/filters.texi b/doc/filters.texi
index 57189c77b0..ad2a01bb2e 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -4512,7 +4512,7 @@  Synthesize a voice utterance using the libflite library.
 To enable compilation of this filter you need to configure FFmpeg with
 @code{--enable-libflite}.
 
-Note that the flite library is not thread-safe.
+Note that versions of the flite library prior to 2.0 are not thread-safe.
 
 The filter accepts the following options:
 
@@ -4567,7 +4567,7 @@  ffplay -f lavfi flite=text='No more be grieved for which that thou hast done.'
 @end itemize
 
 For more information about libflite, check:
-@url{http://www.speech.cs.cmu.edu/flite/}
+@url{http://www.festvox.org/flite/}
 
 @section anoisesrc