diff mbox

[FFmpeg-devel,1/5] avcodec/dump_extradata_bsf: don't allocate a new AVPacket per filtered packet

Message ID 20180726011151.6232-1-jamrial@gmail.com
State Accepted
Commit b98bd60bfa2605fd874d42f96804d1c999278a7e
Headers show

Commit Message

James Almer July 26, 2018, 1:11 a.m. UTC 
~4x speedup in dump_extradata()

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavcodec/dump_extradata_bsf.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Michael Niedermayer July 27, 2018, 7:55 p.m. UTC | #1 
On Wed, Jul 25, 2018 at 10:11:47PM -0300, James Almer wrote:
> ~4x speedup in dump_extradata()
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavcodec/dump_extradata_bsf.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

should be ok
and nice speedup

thx

[...]
James Almer Aug. 2, 2018, 6:04 p.m. UTC | #2 
On 7/27/2018 4:55 PM, Michael Niedermayer wrote:
> On Wed, Jul 25, 2018 at 10:11:47PM -0300, James Almer wrote:
>> ~4x speedup in dump_extradata()
>>
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>>  libavcodec/dump_extradata_bsf.c | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> should be ok
> and nice speedup
> 
> thx

Patchset pushed, thanks.
diff mbox

Patch

diff --git a/libavcodec/dump_extradata_bsf.c b/libavcodec/dump_extradata_bsf.c
index 98703749f7..188a1c619b 100644
--- a/libavcodec/dump_extradata_bsf.c
+++ b/libavcodec/dump_extradata_bsf.c
@@ -34,16 +34,17 @@  enum DumpFreq {
 
 typedef struct DumpExtradataContext {
     const AVClass *class;
+    AVPacket pkt;
     int freq;
 } DumpExtradataContext;
 
 static int dump_extradata(AVBSFContext *ctx, AVPacket *out)
 {
     DumpExtradataContext *s = ctx->priv_data;
-    AVPacket *in;
+    AVPacket *in = &s->pkt;
     int ret = 0;
 
-    ret = ff_bsf_get_packet(ctx, &in);
+    ret = ff_bsf_get_packet_ref(ctx, in);
     if (ret < 0)
         return ret;
 
@@ -72,7 +73,7 @@  static int dump_extradata(AVBSFContext *ctx, AVPacket *out)
     }
 
 fail:
-    av_packet_free(&in);
+    av_packet_unref(in);
 
     return ret;
 }