| Message ID | 0101018fa7012ca1-8218ead9-5e49-46dd-8ad4-35eeddbc1cdf-000000@us-west-2.amazonses.com |
|---|---|
| Headers | show |
| Series | avcodec/dovi - disable metadata compression by default | expand |
On Thu, 23 May 2024 19:50:23 +0000 Cosmin Stejerean via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote: > From: Cosmin Stejerean <cosmin@cosmin.at> > > not all clients support metadata compression, output when vdr_dm_metadata_changed fails the DV verifier. > > Compared to v2 this makes the dovi field name a parameter of the > DOVI_ENCODING_OPTS macro as requested. It also splits up the commits into > introducing the macro, guarding compression by it, and then leveraging it in > the encoder. > > I split up each encoder into a separate patch since the original support was > added in separate patches but this could also be squashed when applying if > that's better. > > Cosmin Stejerean (5): > avcodec/dovi_rpu - add field to disable metadata compression > avcodec/dovi_rpuenc - guard metadata compression by enable_compression > avcodec/libaomenc - switch DolbyVision options to DOVI_ENCODING_OPTS > avcodec/libsvtav1 - switch DolbyVision options to DOVI_ENCODING_OPTS > avcodec/libx265 - switch DolbyVision options to DOVI_ENCODING_OPTS > > libavcodec/dovi_rpu.h | 10 ++++++++++ > libavcodec/dovi_rpuenc.c | 8 ++++++-- > libavcodec/libaomenc.c | 3 +-- > libavcodec/libsvtav1.c | 3 +-- > libavcodec/libx265.c | 3 +-- > 5 files changed, 19 insertions(+), 8 deletions(-) > > -- > 2.42.1 > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". I suppose this series is redundant now with the compression changes from my BSF patchset? Unless we want to preserve the macro for purely stylistic reasons, but we can probably stomach the duplication of only a single option field.
> On Jun 19, 2024, at 3:21 AM, Niklas Haas <ffmpeg@haasn.xyz> wrote: > > On Thu, 23 May 2024 19:50:23 +0000 Cosmin Stejerean via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote: >> From: Cosmin Stejerean <cosmin@cosmin.at> >> >> not all clients support metadata compression, output when vdr_dm_metadata_changed fails the DV verifier. >> >> Compared to v2 this makes the dovi field name a parameter of the >> DOVI_ENCODING_OPTS macro as requested. It also splits up the commits into >> introducing the macro, guarding compression by it, and then leveraging it in >> the encoder. >> >> I split up each encoder into a separate patch since the original support was >> added in separate patches but this could also be squashed when applying if >> that's better. >> >> Cosmin Stejerean (5): >> avcodec/dovi_rpu - add field to disable metadata compression >> avcodec/dovi_rpuenc - guard metadata compression by enable_compression >> avcodec/libaomenc - switch DolbyVision options to DOVI_ENCODING_OPTS >> avcodec/libsvtav1 - switch DolbyVision options to DOVI_ENCODING_OPTS >> avcodec/libx265 - switch DolbyVision options to DOVI_ENCODING_OPTS >> >> libavcodec/dovi_rpu.h | 10 ++++++++++ >> libavcodec/dovi_rpuenc.c | 8 ++++++-- >> libavcodec/libaomenc.c | 3 +-- >> libavcodec/libsvtav1.c | 3 +-- >> libavcodec/libx265.c | 3 +-- >> 5 files changed, 19 insertions(+), 8 deletions(-) >> >> -- >> 2.42.1 >> >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > I suppose this series is redundant now with the compression changes from > my BSF patchset? > > Unless we want to preserve the macro for purely stylistic reasons, but > we can probably stomach the duplication of only a single option field. > Agreed, I think we can abandon this patchset in favor of the BSF one. - Cosmin
From: Cosmin Stejerean <cosmin@cosmin.at> not all clients support metadata compression, output when vdr_dm_metadata_changed fails the DV verifier. Compared to v2 this makes the dovi field name a parameter of the DOVI_ENCODING_OPTS macro as requested. It also splits up the commits into introducing the macro, guarding compression by it, and then leveraging it in the encoder. I split up each encoder into a separate patch since the original support was added in separate patches but this could also be squashed when applying if that's better. Cosmin Stejerean (5): avcodec/dovi_rpu - add field to disable metadata compression avcodec/dovi_rpuenc - guard metadata compression by enable_compression avcodec/libaomenc - switch DolbyVision options to DOVI_ENCODING_OPTS avcodec/libsvtav1 - switch DolbyVision options to DOVI_ENCODING_OPTS avcodec/libx265 - switch DolbyVision options to DOVI_ENCODING_OPTS libavcodec/dovi_rpu.h | 10 ++++++++++ libavcodec/dovi_rpuenc.c | 8 ++++++-- libavcodec/libaomenc.c | 3 +-- libavcodec/libsvtav1.c | 3 +-- libavcodec/libx265.c | 3 +-- 5 files changed, 19 insertions(+), 8 deletions(-)