| Message ID | 1587556372-24387-1-git-send-email-mypopydev@gmail.com |
|---|---|
| Headers | show |
| Series | Support Dolby Vision | expand |
On Wed, Apr 22, 2020 at 7:53 PM Jun Zhao <mypopydev@gmail.com> wrote: > > From: Jun Zhao <barryjzhaotencent.com> > > V6: > - split the header and .c file > - bump version and update APIChnage > > V5: > - add a constructor for DOVI (tks Anton Khirnov) > - some minor coding style clean > > V4: > - change the DOVI dump message (tks Jan Ekström) > - fix the file order in Makefile > > V3: > - rename the file name for Dolby Vision trademark risk(tks Jean-Baptiste Kempf) > - fix other typo issue > > V2: > - used sidedata for Dolby Vision information (tks Jan Ekström's suggestion) > - enabled dumping Dolby Vision sidedata for ffmpeg/ffprobe tools > - enabled dvcC/dvvC box from Dolby Vision sidedata > > > Jun Zhao (6): > lavc: add a new sidedata type for DOVI > lavf/dump: dump DOVI side data > fftools/ffprobe: support DOVI sidedata > lavf/movenc: enable dvcC/dvvC box support from DOVI sidedata > lavc/version: bump minor version for DOVI sidedata > doc/APIChanges: add AV_PKT_DATA_DOVI_CONF entry > > vacingfang (3): > lavutil: add DOVI related header > lavf/mpegts: support DOVI Video Stream Descriptor > lavf/mov: support dvcC/dvvC box for DOVI > > doc/APIchanges | 3 +++ > fftools/ffprobe.c | 11 ++++++++ > libavcodec/avpacket.c | 1 + > libavcodec/packet.h | 9 +++++++ > libavcodec/version.h | 2 +- > libavformat/dump.c | 19 ++++++++++++++ > libavformat/mov.c | 60 +++++++++++++++++++++++++++++++++++++++++++ > libavformat/movenc.c | 35 ++++++++++++++++++++++++++ > libavformat/mpegts.c | 48 +++++++++++++++++++++++++++++++++++ > libavutil/Makefile | 2 ++ > libavutil/dovi_meta.c | 35 ++++++++++++++++++++++++++ > libavutil/dovi_meta.h | 70 +++++++++++++++++++++++++++++++++++++++++++++++++++ > 12 files changed, 294 insertions(+), 1 deletion(-) > create mode 100644 libavutil/dovi_meta.c > create mode 100644 libavutil/dovi_meta.h > Patchset pushed, tks
Quoting mypopy@gmail.com (2020-04-23 04:16:41) > On Wed, Apr 22, 2020 at 7:53 PM Jun Zhao <mypopydev@gmail.com> wrote: > > > > From: Jun Zhao <barryjzhaotencent.com> > > > > V6: > > - split the header and .c file > > - bump version and update APIChnage > > > > V5: > > - add a constructor for DOVI (tks Anton Khirnov) > > - some minor coding style clean > > > > V4: > > - change the DOVI dump message (tks Jan Ekström) > > - fix the file order in Makefile > > > > V3: > > - rename the file name for Dolby Vision trademark risk(tks Jean-Baptiste Kempf) > > - fix other typo issue > > > > V2: > > - used sidedata for Dolby Vision information (tks Jan Ekström's suggestion) > > - enabled dumping Dolby Vision sidedata for ffmpeg/ffprobe tools > > - enabled dvcC/dvvC box from Dolby Vision sidedata > > > > > > Jun Zhao (6): > > lavc: add a new sidedata type for DOVI > > lavf/dump: dump DOVI side data > > fftools/ffprobe: support DOVI sidedata > > lavf/movenc: enable dvcC/dvvC box support from DOVI sidedata > > lavc/version: bump minor version for DOVI sidedata > > doc/APIChanges: add AV_PKT_DATA_DOVI_CONF entry > > > > vacingfang (3): > > lavutil: add DOVI related header > > lavf/mpegts: support DOVI Video Stream Descriptor > > lavf/mov: support dvcC/dvvC box for DOVI > > > > doc/APIchanges | 3 +++ > > fftools/ffprobe.c | 11 ++++++++ > > libavcodec/avpacket.c | 1 + > > libavcodec/packet.h | 9 +++++++ > > libavcodec/version.h | 2 +- > > libavformat/dump.c | 19 ++++++++++++++ > > libavformat/mov.c | 60 +++++++++++++++++++++++++++++++++++++++++++ > > libavformat/movenc.c | 35 ++++++++++++++++++++++++++ > > libavformat/mpegts.c | 48 +++++++++++++++++++++++++++++++++++ > > libavutil/Makefile | 2 ++ > > libavutil/dovi_meta.c | 35 ++++++++++++++++++++++++++ > > libavutil/dovi_meta.h | 70 +++++++++++++++++++++++++++++++++++++++++++++++++++ > > 12 files changed, 294 insertions(+), 1 deletion(-) > > create mode 100644 libavutil/dovi_meta.c > > create mode 100644 libavutil/dovi_meta.h > > > Patchset pushed, tks You forgot the lavu version bump+APIchanges entry. Also, I think it is good form to leave at least 24 hours between posting a patch and pushing it, especially when it changes public API. Not everyone is always able to review quickly.
On Thu, Apr 23, 2020 at 5:55 PM Anton Khirnov <anton@khirnov.net> wrote: > > Quoting mypopy@gmail.com (2020-04-23 04:16:41) > > On Wed, Apr 22, 2020 at 7:53 PM Jun Zhao <mypopydev@gmail.com> wrote: > > > > > > From: Jun Zhao <barryjzhaotencent.com> > > > > > > V6: > > > - split the header and .c file > > > - bump version and update APIChnage > > > > > > V5: > > > - add a constructor for DOVI (tks Anton Khirnov) > > > - some minor coding style clean > > > > > > V4: > > > - change the DOVI dump message (tks Jan Ekström) > > > - fix the file order in Makefile > > > > > > V3: > > > - rename the file name for Dolby Vision trademark risk(tks Jean-Baptiste Kempf) > > > - fix other typo issue > > > > > > V2: > > > - used sidedata for Dolby Vision information (tks Jan Ekström's suggestion) > > > - enabled dumping Dolby Vision sidedata for ffmpeg/ffprobe tools > > > - enabled dvcC/dvvC box from Dolby Vision sidedata > > > > > > > > > Jun Zhao (6): > > > lavc: add a new sidedata type for DOVI > > > lavf/dump: dump DOVI side data > > > fftools/ffprobe: support DOVI sidedata > > > lavf/movenc: enable dvcC/dvvC box support from DOVI sidedata > > > lavc/version: bump minor version for DOVI sidedata > > > doc/APIChanges: add AV_PKT_DATA_DOVI_CONF entry > > > > > > vacingfang (3): > > > lavutil: add DOVI related header > > > lavf/mpegts: support DOVI Video Stream Descriptor > > > lavf/mov: support dvcC/dvvC box for DOVI > > > > > > doc/APIchanges | 3 +++ > > > fftools/ffprobe.c | 11 ++++++++ > > > libavcodec/avpacket.c | 1 + > > > libavcodec/packet.h | 9 +++++++ > > > libavcodec/version.h | 2 +- > > > libavformat/dump.c | 19 ++++++++++++++ > > > libavformat/mov.c | 60 +++++++++++++++++++++++++++++++++++++++++++ > > > libavformat/movenc.c | 35 ++++++++++++++++++++++++++ > > > libavformat/mpegts.c | 48 +++++++++++++++++++++++++++++++++++ > > > libavutil/Makefile | 2 ++ > > > libavutil/dovi_meta.c | 35 ++++++++++++++++++++++++++ > > > libavutil/dovi_meta.h | 70 +++++++++++++++++++++++++++++++++++++++++++++++++++ > > > 12 files changed, 294 insertions(+), 1 deletion(-) > > > create mode 100644 libavutil/dovi_meta.c > > > create mode 100644 libavutil/dovi_meta.h > > > > > Patchset pushed, tks > > You forgot the lavu version bump+APIchanges entry. > Will update this part > Also, I think it is good form to leave at least 24 hours between posting > a patch and pushing it, especially when it changes public API. > Not everyone is always able to review quickly. > Tks the remind and comments/review again, will follow the suggestion next time.
From: Jun Zhao <barryjzhaotencent.com> V6: - split the header and .c file - bump version and update APIChnage V5: - add a constructor for DOVI (tks Anton Khirnov) - some minor coding style clean V4: - change the DOVI dump message (tks Jan Ekström) - fix the file order in Makefile V3: - rename the file name for Dolby Vision trademark risk(tks Jean-Baptiste Kempf) - fix other typo issue V2: - used sidedata for Dolby Vision information (tks Jan Ekström's suggestion) - enabled dumping Dolby Vision sidedata for ffmpeg/ffprobe tools - enabled dvcC/dvvC box from Dolby Vision sidedata Jun Zhao (6): lavc: add a new sidedata type for DOVI lavf/dump: dump DOVI side data fftools/ffprobe: support DOVI sidedata lavf/movenc: enable dvcC/dvvC box support from DOVI sidedata lavc/version: bump minor version for DOVI sidedata doc/APIChanges: add AV_PKT_DATA_DOVI_CONF entry vacingfang (3): lavutil: add DOVI related header lavf/mpegts: support DOVI Video Stream Descriptor lavf/mov: support dvcC/dvvC box for DOVI doc/APIchanges | 3 +++ fftools/ffprobe.c | 11 ++++++++ libavcodec/avpacket.c | 1 + libavcodec/packet.h | 9 +++++++ libavcodec/version.h | 2 +- libavformat/dump.c | 19 ++++++++++++++ libavformat/mov.c | 60 +++++++++++++++++++++++++++++++++++++++++++ libavformat/movenc.c | 35 ++++++++++++++++++++++++++ libavformat/mpegts.c | 48 +++++++++++++++++++++++++++++++++++ libavutil/Makefile | 2 ++ libavutil/dovi_meta.c | 35 ++++++++++++++++++++++++++ libavutil/dovi_meta.h | 70 +++++++++++++++++++++++++++++++++++++++++++++++++++ 12 files changed, 294 insertions(+), 1 deletion(-) create mode 100644 libavutil/dovi_meta.c create mode 100644 libavutil/dovi_meta.h