mbox series

[FFmpeg-devel,v2,0/5] Add support for Closed Caption FIFO

Message ID 1680904709-25951-1-git-send-email-dheitmueller@ltnglobal.com
Headers show
Series Add support for Closed Caption FIFO | expand

Message

Devin Heitmueller April 7, 2023, 9:58 p.m. UTC 
This patch series address all known issues reported to date, and in
particular moves the API into libavfilter where it can remain
private (at least for now).

Comments and/or further review is welcomed.

Devin Heitmueller (5):
  ccfifo: Properly handle CEA-708 captions through framerate conversion
  vf_fps: properly preserve CEA-708 captions
  yadif: Properly preserve CEA-708 closed captions
  tinterlace: Properly preserve CEA-708 closed captions
  vf_ccrepack: Add new filter to repack CEA-708 side data

 doc/filters.texi            |  10 +++
 libavfilter/Makefile        |   2 +
 libavfilter/allfilters.c    |   1 +
 libavfilter/ccfifo.c        | 191 ++++++++++++++++++++++++++++++++++++++++++++
 libavfilter/ccfifo.h        |  85 ++++++++++++++++++++
 libavfilter/tinterlace.h    |   2 +
 libavfilter/vf_bwdif.c      |   7 ++
 libavfilter/vf_ccrepack.c   | 100 +++++++++++++++++++++++
 libavfilter/vf_fps.c        |   9 ++-
 libavfilter/vf_tinterlace.c |   8 ++
 libavfilter/vf_yadif.c      |   6 ++
 libavfilter/vf_yadif_cuda.c |   8 ++
 libavfilter/yadif.h         |   2 +
 libavfilter/yadif_common.c  |   5 ++
 14 files changed, 435 insertions(+), 1 deletion(-)
 create mode 100644 libavfilter/ccfifo.c
 create mode 100644 libavfilter/ccfifo.h
 create mode 100644 libavfilter/vf_ccrepack.c

Comments

Devin Heitmueller April 14, 2023, 1:19 p.m. UTC | #1 
On Fri, Apr 7, 2023 at 5:03 PM Devin Heitmueller
<devin.heitmueller@ltnglobal.com> wrote:
>
> This patch series address all known issues reported to date, and in
> particular moves the API into libavfilter where it can remain
> private (at least for now).
>
> Comments and/or further review is welcomed.
>
> Devin Heitmueller (5):
>   ccfifo: Properly handle CEA-708 captions through framerate conversion
>   vf_fps: properly preserve CEA-708 captions
>   yadif: Properly preserve CEA-708 closed captions
>   tinterlace: Properly preserve CEA-708 closed captions
>   vf_ccrepack: Add new filter to repack CEA-708 side data
>
>  doc/filters.texi            |  10 +++
>  libavfilter/Makefile        |   2 +
>  libavfilter/allfilters.c    |   1 +
>  libavfilter/ccfifo.c        | 191 ++++++++++++++++++++++++++++++++++++++++++++
>  libavfilter/ccfifo.h        |  85 ++++++++++++++++++++
>  libavfilter/tinterlace.h    |   2 +
>  libavfilter/vf_bwdif.c      |   7 ++
>  libavfilter/vf_ccrepack.c   | 100 +++++++++++++++++++++++
>  libavfilter/vf_fps.c        |   9 ++-
>  libavfilter/vf_tinterlace.c |   8 ++
>  libavfilter/vf_yadif.c      |   6 ++
>  libavfilter/vf_yadif_cuda.c |   8 ++
>  libavfilter/yadif.h         |   2 +
>  libavfilter/yadif_common.c  |   5 ++
>  14 files changed, 435 insertions(+), 1 deletion(-)
>  create mode 100644 libavfilter/ccfifo.c
>  create mode 100644 libavfilter/ccfifo.h
>  create mode 100644 libavfilter/vf_ccrepack.c
>
> --
> 1.8.3.1
>

Does anyone have any further comments on this patch series?  I moved
the API to be internal to libavfilter as requested, and there's one
trivial memory leak, but I don't think it's gotten any substantive
review.

I would like to see it merged, so I welcome further comments/feedback.

Thanks,

Devin