| Message ID | 1682707254-27604-1-git-send-email-dheitmueller@ltnglobal.com |
|---|---|
| Headers | show |
| Series | Implement SMPTE 2038 output support over Decklink SDI | expand |
Hi Marton, On Fri, Apr 28, 2023 at 1:45 PM Devin Heitmueller <devin.heitmueller@ltnglobal.com> wrote: > > This patch series implements output of SMPTE 2038 VANC over SDI, building > on the prior patch series which added it in the TS domain. Note that > we moved the AVPacketQueue to be common code within libavdevice so it > can be shared by both the decklink input and output. > > This latest revision of the patch series includes some refactoring > for the decklink queue requested by Marton Balint. > > Devin > > Devin Heitmueller (4): > decklink: Move AVPacketQueue into decklink_common > decklink: rename AVPacketQueue to DecklinkPacketQueue > decklink: Convert to using avpriv_packet_list functions > decklink_enc: add support for SMPTE 2038 VANC packet output > > libavdevice/decklink_common.cpp | 110 ++++++++++++++++++++++++++++++++++ > libavdevice/decklink_common.h | 17 +++++- > libavdevice/decklink_dec.cpp | 130 +++------------------------------------- > libavdevice/decklink_enc.cpp | 99 +++++++++++++++++++++++++++++- > libavdevice/decklink_enc_c.c | 1 + > 5 files changed, 231 insertions(+), 126 deletions(-) Do you have any further comments regarding this patch series? It includes the renaming changes you specifically requested, so even if you have some concerns about patch 4/4 could you please merge 1-3 (as I have other changes pending which can't be submitted until those are in)? Regards, Devin
On Thu, 11 May 2023, Devin Heitmueller wrote: > Hi Marton, > > On Fri, Apr 28, 2023 at 1:45 PM Devin Heitmueller > <devin.heitmueller@ltnglobal.com> wrote: >> >> This patch series implements output of SMPTE 2038 VANC over SDI, building >> on the prior patch series which added it in the TS domain. Note that >> we moved the AVPacketQueue to be common code within libavdevice so it >> can be shared by both the decklink input and output. >> >> This latest revision of the patch series includes some refactoring >> for the decklink queue requested by Marton Balint. >> >> Devin >> >> Devin Heitmueller (4): >> decklink: Move AVPacketQueue into decklink_common >> decklink: rename AVPacketQueue to DecklinkPacketQueue >> decklink: Convert to using avpriv_packet_list functions >> decklink_enc: add support for SMPTE 2038 VANC packet output >> >> libavdevice/decklink_common.cpp | 110 ++++++++++++++++++++++++++++++++++ >> libavdevice/decklink_common.h | 17 +++++- >> libavdevice/decklink_dec.cpp | 130 +++------------------------------------- >> libavdevice/decklink_enc.cpp | 99 +++++++++++++++++++++++++++++- >> libavdevice/decklink_enc_c.c | 1 + >> 5 files changed, 231 insertions(+), 126 deletions(-) > > Do you have any further comments regarding this patch series? It > includes the renaming changes you specifically requested, so even if > you have some concerns about patch 4/4 could you please merge 1-3 (as > I have other changes pending which can't be submitted until those are > in)? Will apply patches 1 and 2. I will squash them as I am not sure if it is good idea to have av* non-static functions even temporarily. I will post some comments for patch 3. I will need a bit more time to think about patch 4. :) Thanks, Marton > > Regards, > > Devin > > -- > Devin Heitmueller, Senior Software Engineer > LTN Global Communications > o: +1 (301) 363-1001 > w: https://ltnglobal.com e: devin.heitmueller@ltnglobal.com > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On Thu, May 11, 2023 at 5:19 PM Marton Balint <cus@passwd.hu> wrote: > Will apply patches 1 and 2. I will squash them as I am not sure if it is > good idea to have av* non-static functions even temporarily. No objection. I did it that way just to make it easier to review. > I will post some comments for patch 3. I will need a bit more time to > think about patch 4. :) Sounds good. Thanks Devin