mbox series

[FFmpeg-devel,0/7] Misc AFD improvements and support for Bar Data

Message ID 1686169347-28987-1-git-send-email-dheitmueller@ltnglobal.com
Headers show
Series Misc AFD improvements and support for Bar Data | expand

Message

Devin Heitmueller June 7, 2023, 8:22 p.m. UTC
This patch series includes some misc changes related to AFD, as well
as adding support for S2016-1 bar data.

The current focus of this series for bar data is getting the basic
support in place within the raw domain and decklink output.  A subsequent
patch series will be submitted which includes the patches to the
H.264/HEVC decoders and libx264 to properly handle the SEI data.

Devin Heitmueller (7):
  Preserve AFD side data when going from AVPacket to AVFrame
  vf_drawtext: Add ability to show AFD value
  avcodec/avframe: add new side data types for Bar Data
  libavfilter: Add filter to insert AFD/bar data
  Provide a side data description for newly introduced bar data
  avcodec/v210enc: Pass through bar data
  avdevice/decklink_enc: Add support for output of bar data as VANC

 doc/filters.texi             |  57 +++++++++++++++++++
 libavcodec/decode.c          |   2 +
 libavcodec/defs.h            |  12 ++++
 libavcodec/packet.h          |   6 ++
 libavcodec/v210enc.c         |   8 +++
 libavdevice/decklink_enc.cpp |  32 ++++++++---
 libavfilter/Makefile         |   1 +
 libavfilter/allfilters.c     |   1 +
 libavfilter/vf_afd.c         | 133 +++++++++++++++++++++++++++++++++++++++++++
 libavfilter/vf_drawtext.c    |  19 +++++++
 libavutil/frame.c            |   1 +
 libavutil/frame.h            |   6 ++
 12 files changed, 270 insertions(+), 8 deletions(-)
 create mode 100644 libavfilter/vf_afd.c

Comments

Devin Heitmueller June 15, 2023, 2:54 p.m. UTC | #1
On Wed, Jun 7, 2023 at 3:24 PM Devin Heitmueller
<devin.heitmueller@ltnglobal.com> wrote:
>
> This patch series includes some misc changes related to AFD, as well
> as adding support for S2016-1 bar data.
>
> The current focus of this series for bar data is getting the basic
> support in place within the raw domain and decklink output.  A subsequent
> patch series will be submitted which includes the patches to the
> H.264/HEVC decoders and libx264 to properly handle the SEI data.
>
> Devin Heitmueller (7):
>   Preserve AFD side data when going from AVPacket to AVFrame
>   vf_drawtext: Add ability to show AFD value
>   avcodec/avframe: add new side data types for Bar Data
>   libavfilter: Add filter to insert AFD/bar data
>   Provide a side data description for newly introduced bar data
>   avcodec/v210enc: Pass through bar data
>   avdevice/decklink_enc: Add support for output of bar data as VANC
>
>  doc/filters.texi             |  57 +++++++++++++++++++
>  libavcodec/decode.c          |   2 +
>  libavcodec/defs.h            |  12 ++++
>  libavcodec/packet.h          |   6 ++
>  libavcodec/v210enc.c         |   8 +++
>  libavdevice/decklink_enc.cpp |  32 ++++++++---
>  libavfilter/Makefile         |   1 +
>  libavfilter/allfilters.c     |   1 +
>  libavfilter/vf_afd.c         | 133 +++++++++++++++++++++++++++++++++++++++++++
>  libavfilter/vf_drawtext.c    |  19 +++++++
>  libavutil/frame.c            |   1 +
>  libavutil/frame.h            |   6 ++
>  12 files changed, 270 insertions(+), 8 deletions(-)
>  create mode 100644 libavfilter/vf_afd.c
>
> --
> 1.8.3.1
>

Does anyone have any comments/feedback on this patch series?

Devin
Paul B Mahol June 15, 2023, 2:57 p.m. UTC | #2
On Thu, Jun 15, 2023 at 4:54 PM Devin Heitmueller <
devin.heitmueller@ltnglobal.com> wrote:

> On Wed, Jun 7, 2023 at 3:24 PM Devin Heitmueller
> <devin.heitmueller@ltnglobal.com> wrote:
> >
> > This patch series includes some misc changes related to AFD, as well
> > as adding support for S2016-1 bar data.
> >
> > The current focus of this series for bar data is getting the basic
> > support in place within the raw domain and decklink output.  A subsequent
> > patch series will be submitted which includes the patches to the
> > H.264/HEVC decoders and libx264 to properly handle the SEI data.
> >
> > Devin Heitmueller (7):
> >   Preserve AFD side data when going from AVPacket to AVFrame
> >   vf_drawtext: Add ability to show AFD value
> >   avcodec/avframe: add new side data types for Bar Data
> >   libavfilter: Add filter to insert AFD/bar data
> >   Provide a side data description for newly introduced bar data
> >   avcodec/v210enc: Pass through bar data
> >   avdevice/decklink_enc: Add support for output of bar data as VANC
> >
> >  doc/filters.texi             |  57 +++++++++++++++++++
> >  libavcodec/decode.c          |   2 +
> >  libavcodec/defs.h            |  12 ++++
> >  libavcodec/packet.h          |   6 ++
> >  libavcodec/v210enc.c         |   8 +++
> >  libavdevice/decklink_enc.cpp |  32 ++++++++---
> >  libavfilter/Makefile         |   1 +
> >  libavfilter/allfilters.c     |   1 +
> >  libavfilter/vf_afd.c         | 133
> +++++++++++++++++++++++++++++++++++++++++++
> >  libavfilter/vf_drawtext.c    |  19 +++++++
> >  libavutil/frame.c            |   1 +
> >  libavutil/frame.h            |   6 ++
> >  12 files changed, 270 insertions(+), 8 deletions(-)
> >  create mode 100644 libavfilter/vf_afd.c
> >
> > --
> > 1.8.3.1
> >
>
> Does anyone have any comments/feedback on this patch series?
>

It may conflict with another set of drawtext patches.


>
> Devin
>
> --
> Devin Heitmueller, Senior Software Engineer
> LTN Global Communications
> o: +1 (301) 363-1001
> w: https://ltnglobal.com  e: devin.heitmueller@ltnglobal.com
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
Devin Heitmueller June 15, 2023, 3:21 p.m. UTC | #3
Hello Paul,

On Thu, Jun 15, 2023 at 10:57 AM Paul B Mahol <onemda@gmail.com> wrote:
> It may conflict with another set of drawtext patches.

I'm happy to regenerate the drawtext patch if there is a conflict.  If
the other patches could be merged though that would be helpful as it
would avoid me having to regenerate the entire patch series (assuming
there are no other issues/comments).  None of the other patches in the
series depend on the drawtext patch, but the drawtext patch depends on
other patches in the series.

Devin
Devin Heitmueller June 22, 2023, 11:52 a.m. UTC | #4
Does anyone else have any comments on this series that would prevent
it from being merged upstream?  If not, I can rebase the drawtext
patch so there are no conflicts.

Devin