mbox series

[FFmpeg-devel,v4,0/4] Add passthrough support for SCTE-35

Message ID 1690810686-4723-1-git-send-email-dheitmueller@ltnglobal.com
Headers show
Series Add passthrough support for SCTE-35 | expand

Message

Devin Heitmueller July 31, 2023, 1:38 p.m. UTC
Properly set up the MPEG-TS mux and recalculate the pts_adjust field
in SCTE_35 packets, such that a user can transparently pass through
SCTE-35 streams when both the input and output are MPEG-TS.

This patch series updated to reflect feedback from James Almer.

Devin Heitmueller (4):
  avcodec: Add new side data type to contain original PTS value
  mpegts: Stash original PTS for SCTE-35 sections for processing later
  mpegtsenc: Add support for output of SCTE-35 streams over TS
  bsf: Add new bitstream filter to set SCTE-35 pts_adjustment when
    reclocking

 doc/bitstream_filters.texi       |   9 ++++
 libavcodec/Makefile              |   1 +
 libavcodec/bitstream_filters.c   |   1 +
 libavcodec/defs.h                |  12 +++++
 libavcodec/packet.h              |  11 +++++
 libavcodec/scte35ptsadjust_bsf.c | 100 +++++++++++++++++++++++++++++++++++++++
 libavformat/mpegts.c             |  11 ++++-
 libavformat/mpegts.h             |   1 +
 libavformat/mpegtsenc.c          |  76 +++++++++++++++++++++++++++--
 libavformat/mux.c                |   6 ++-
 10 files changed, 221 insertions(+), 7 deletions(-)
 create mode 100644 libavcodec/scte35ptsadjust_bsf.c

Comments

Devin Heitmueller Aug. 4, 2023, 11:16 a.m. UTC | #1
On Mon, Jul 31, 2023 at 9:38 AM Devin Heitmueller
<devin.heitmueller@ltnglobal.com> wrote:
>
> Properly set up the MPEG-TS mux and recalculate the pts_adjust field
> in SCTE_35 packets, such that a user can transparently pass through
> SCTE-35 streams when both the input and output are MPEG-TS.
>
> This patch series updated to reflect feedback from James Almer.
>
> Devin Heitmueller (4):
>   avcodec: Add new side data type to contain original PTS value
>   mpegts: Stash original PTS for SCTE-35 sections for processing later
>   mpegtsenc: Add support for output of SCTE-35 streams over TS
>   bsf: Add new bitstream filter to set SCTE-35 pts_adjustment when
>     reclocking
>
>  doc/bitstream_filters.texi       |   9 ++++
>  libavcodec/Makefile              |   1 +
>  libavcodec/bitstream_filters.c   |   1 +
>  libavcodec/defs.h                |  12 +++++
>  libavcodec/packet.h              |  11 +++++
>  libavcodec/scte35ptsadjust_bsf.c | 100 +++++++++++++++++++++++++++++++++++++++
>  libavformat/mpegts.c             |  11 ++++-
>  libavformat/mpegts.h             |   1 +
>  libavformat/mpegtsenc.c          |  76 +++++++++++++++++++++++++++--
>  libavformat/mux.c                |   6 ++-
>  10 files changed, 221 insertions(+), 7 deletions(-)
>  create mode 100644 libavcodec/scte35ptsadjust_bsf.c
>
> --
> 1.8.3.1
>

ping.
Devin Heitmueller Aug. 8, 2023, 2:31 p.m. UTC | #2
On Fri, Aug 4, 2023 at 7:16 AM Devin Heitmueller
<devin.heitmueller@ltnglobal.com> wrote:
>
> On Mon, Jul 31, 2023 at 9:38 AM Devin Heitmueller
> <devin.heitmueller@ltnglobal.com> wrote:
> >
> > Properly set up the MPEG-TS mux and recalculate the pts_adjust field
> > in SCTE_35 packets, such that a user can transparently pass through
> > SCTE-35 streams when both the input and output are MPEG-TS.
> >
> > This patch series updated to reflect feedback from James Almer.
> >
> > Devin Heitmueller (4):
> >   avcodec: Add new side data type to contain original PTS value
> >   mpegts: Stash original PTS for SCTE-35 sections for processing later
> >   mpegtsenc: Add support for output of SCTE-35 streams over TS
> >   bsf: Add new bitstream filter to set SCTE-35 pts_adjustment when
> >     reclocking
> >
> >  doc/bitstream_filters.texi       |   9 ++++
> >  libavcodec/Makefile              |   1 +
> >  libavcodec/bitstream_filters.c   |   1 +
> >  libavcodec/defs.h                |  12 +++++
> >  libavcodec/packet.h              |  11 +++++
> >  libavcodec/scte35ptsadjust_bsf.c | 100 +++++++++++++++++++++++++++++++++++++++
> >  libavformat/mpegts.c             |  11 ++++-
> >  libavformat/mpegts.h             |   1 +
> >  libavformat/mpegtsenc.c          |  76 +++++++++++++++++++++++++++--
> >  libavformat/mux.c                |   6 ++-
> >  10 files changed, 221 insertions(+), 7 deletions(-)
> >  create mode 100644 libavcodec/scte35ptsadjust_bsf.c
> >
> > --
> > 1.8.3.1
> >
>
> ping.

If nobody has any additional feedback, could I please get somebody to
merge this series?

Thanks,

Devin
Dennis Mungai Aug. 8, 2023, 3:30 p.m. UTC | #3
On Tue, 8 Aug 2023, 17:31 Devin Heitmueller, <
devin.heitmueller@ltnglobal.com> wrote:

> On Fri, Aug 4, 2023 at 7:16 AM Devin Heitmueller
> <devin.heitmueller@ltnglobal.com> wrote:
> >
> > On Mon, Jul 31, 2023 at 9:38 AM Devin Heitmueller
> > <devin.heitmueller@ltnglobal.com> wrote:
> > >
> > > Properly set up the MPEG-TS mux and recalculate the pts_adjust field
> > > in SCTE_35 packets, such that a user can transparently pass through
> > > SCTE-35 streams when both the input and output are MPEG-TS.
> > >
> > > This patch series updated to reflect feedback from James Almer.
> > >
> > > Devin Heitmueller (4):
> > >   avcodec: Add new side data type to contain original PTS value
> > >   mpegts: Stash original PTS for SCTE-35 sections for processing later
> > >   mpegtsenc: Add support for output of SCTE-35 streams over TS
> > >   bsf: Add new bitstream filter to set SCTE-35 pts_adjustment when
> > >     reclocking
> > >
> > >  doc/bitstream_filters.texi       |   9 ++++
> > >  libavcodec/Makefile              |   1 +
> > >  libavcodec/bitstream_filters.c   |   1 +
> > >  libavcodec/defs.h                |  12 +++++
> > >  libavcodec/packet.h              |  11 +++++
> > >  libavcodec/scte35ptsadjust_bsf.c | 100
> +++++++++++++++++++++++++++++++++++++++
> > >  libavformat/mpegts.c             |  11 ++++-
> > >  libavformat/mpegts.h             |   1 +
> > >  libavformat/mpegtsenc.c          |  76 +++++++++++++++++++++++++++--
> > >  libavformat/mux.c                |   6 ++-
> > >  10 files changed, 221 insertions(+), 7 deletions(-)
> > >  create mode 100644 libavcodec/scte35ptsadjust_bsf.c
> > >
> > > --
> > > 1.8.3.1
> > >
> >
> > ping.
>
> If nobody has any additional feedback, could I please get somebody to
> merge this series?
>
> Thanks,
>
> Devin
>
> --
> Devin Heitmueller, Senior Software Engineer
> LTN Global Communications
> o: +1 (301) 363-1001
> w: https://ltnglobal.com  e: devin.heitmueller@ltnglobal.com



Is there anything blocking this patch(set) from bring merged upstream?

>
>
Dennis Mungai Sept. 1, 2023, 9:29 a.m. UTC | #4
On Tue, 8 Aug 2023 at 18:30, Dennis Mungai <dmngaie@gmail.com> wrote:

> On Tue, 8 Aug 2023, 17:31 Devin Heitmueller, <
> devin.heitmueller@ltnglobal.com> wrote:
>
>> On Fri, Aug 4, 2023 at 7:16 AM Devin Heitmueller
>> <devin.heitmueller@ltnglobal.com> wrote:
>> >
>> > On Mon, Jul 31, 2023 at 9:38 AM Devin Heitmueller
>> > <devin.heitmueller@ltnglobal.com> wrote:
>> > >
>> > > Properly set up the MPEG-TS mux and recalculate the pts_adjust field
>> > > in SCTE_35 packets, such that a user can transparently pass through
>> > > SCTE-35 streams when both the input and output are MPEG-TS.
>> > >
>> > > This patch series updated to reflect feedback from James Almer.
>> > >
>> > > Devin Heitmueller (4):
>> > >   avcodec: Add new side data type to contain original PTS value
>> > >   mpegts: Stash original PTS for SCTE-35 sections for processing later
>> > >   mpegtsenc: Add support for output of SCTE-35 streams over TS
>> > >   bsf: Add new bitstream filter to set SCTE-35 pts_adjustment when
>> > >     reclocking
>> > >
>> > >  doc/bitstream_filters.texi       |   9 ++++
>> > >  libavcodec/Makefile              |   1 +
>> > >  libavcodec/bitstream_filters.c   |   1 +
>> > >  libavcodec/defs.h                |  12 +++++
>> > >  libavcodec/packet.h              |  11 +++++
>> > >  libavcodec/scte35ptsadjust_bsf.c | 100
>> +++++++++++++++++++++++++++++++++++++++
>> > >  libavformat/mpegts.c             |  11 ++++-
>> > >  libavformat/mpegts.h             |   1 +
>> > >  libavformat/mpegtsenc.c          |  76 +++++++++++++++++++++++++++--
>> > >  libavformat/mux.c                |   6 ++-
>> > >  10 files changed, 221 insertions(+), 7 deletions(-)
>> > >  create mode 100644 libavcodec/scte35ptsadjust_bsf.c
>> > >
>> > > --
>> > > 1.8.3.1
>> > >
>> >
>> > ping.
>>
>> If nobody has any additional feedback, could I please get somebody to
>> merge this series?
>>
>> Thanks,
>>
>> Devin
>>
>> --
>> Devin Heitmueller, Senior Software Engineer
>> LTN Global Communications
>> o: +1 (301) 363-1001
>> w: https://ltnglobal.com  e: devin.heitmueller@ltnglobal.com
>
>
>
> Is there anything blocking this patch(set) from bring merged upstream?
>


Hello,

Any feedback on this patch-set, so far?
Is there anything blocking it from being merged? Any pending reviews?

-Dennis.