[FFmpeg-devel,v8,0/2] Pro Pinball Series Soundbank demuxer + decoder.

Adds support for the soundbank files used by the Pro Pinball series of games.

Please CC for review.

v8:
  - change "goto done" to a return + "goto fail"
  - Handle truncated files
  - Fix potential byte counter desync

v7:
  - Fix empty lines
  - Use av_malloc_array() instead of av_reallocp_array()
  - Replace multiple av_freep()'s with a goto
  - Minor comment cleanups
  - Ask for a sample if unexpected header values are found

v6:
  - fix tools/probetest failure

v5:
  - add probe function
  - add flag #define's

v4:
  - fix adpcm index table type

v3:
  - fix potential memory leak if read_header() fails
  - fix a buffer overread
  - attempt seek before updating state
  - remove unneeded check
  - naming fixes

v2:
  - Add sanity checks in header fields
  - Formatting and comment fixes
  - Change the struct names to match the files

Zane van Iperen (2):
  avcodec: add support for Cunning Developments' ADPCM
  avformat: add demuxer for Pro Pinball Series' Soundbanks

 Changelog                |   2 +
 doc/general.texi         |   1 +
 libavcodec/Makefile      |   1 +
 libavcodec/adpcm.c       |  33 +++++
 libavcodec/adpcm_data.c  |  13 ++
 libavcodec/adpcm_data.h  |   2 +
 libavcodec/allcodecs.c   |   1 +
 libavcodec/avcodec.h     |   1 +
 libavcodec/codec_desc.c  |   7 +
 libavcodec/version.h     |   4 +-
 libavformat/Makefile     |   1 +
 libavformat/allformats.c |   1 +
 libavformat/pp_bnk.c     | 290 +++++++++++++++++++++++++++++++++++++++
 libavformat/version.h    |   2 +-
 14 files changed, 356 insertions(+), 3 deletions(-)
 create mode 100644 libavformat/pp_bnk.c

On Tue, 07 Apr 2020 10:48:53 +0000
"Zane van Iperen" <zane@zanevaniperen.com> wrote:

> Adds support for the soundbank files used by the Pro Pinball series
> of games.
> 
> Please CC for review.
> 
> v8:
>   - change "goto done" to a return + "goto fail"
>   - Handle truncated files
>   - Fix potential byte counter desync
> 
> v7:
>   - Fix empty lines
>   - Use av_malloc_array() instead of av_reallocp_array()
>   - Replace multiple av_freep()'s with a goto
>   - Minor comment cleanups
>   - Ask for a sample if unexpected header values are found
> 
> v6:
>   - fix tools/probetest failure
> 
> v5:
>   - add probe function
>   - add flag #define's
> 
> v4:
>   - fix adpcm index table type
> 
> v3:
>   - fix potential memory leak if read_header() fails
>   - fix a buffer overread
>   - attempt seek before updating state
>   - remove unneeded check
>   - naming fixes
> 
> v2:
>   - Add sanity checks in header fields
>   - Formatting and comment fixes
>   - Change the struct names to match the files
> 
> Zane van Iperen (2):
>   avcodec: add support for Cunning Developments' ADPCM
>   avformat: add demuxer for Pro Pinball Series' Soundbanks
> 
>  Changelog                |   2 +
>  doc/general.texi         |   1 +
>  libavcodec/Makefile      |   1 +
>  libavcodec/adpcm.c       |  33 +++++
>  libavcodec/adpcm_data.c  |  13 ++
>  libavcodec/adpcm_data.h  |   2 +
>  libavcodec/allcodecs.c   |   1 +
>  libavcodec/avcodec.h     |   1 +
>  libavcodec/codec_desc.c  |   7 +
>  libavcodec/version.h     |   4 +-
>  libavformat/Makefile     |   1 +
>  libavformat/allformats.c |   1 +
>  libavformat/pp_bnk.c     | 290
> +++++++++++++++++++++++++++++++++++++++ libavformat/version.h    |
> 2 +- 14 files changed, 356 insertions(+), 3 deletions(-)
>  create mode 100644 libavformat/pp_bnk.c
> 
> --
> 2.17.1
> 
> 

Ping.

Zane

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

On Tue, 07 Apr 2020 10:48:53 +0000
"Zane van Iperen" <zane@zanevaniperen.com> wrote:

> Adds support for the soundbank files used by the Pro Pinball series
> of games.
> 

Ping 2. Could I please have some reviews on this, it's been over a week.

I have a rebased version here, if required:
https://github.com/vs49688/FFmpeg fj-v9-pre