| Message ID | 20220102094940.1765-1-dcnieho@gmail.com |
|---|---|
| Headers | show |
| Series | avdevice/dshow fixups | expand |
These LGTM. Feel free to add yourself as a dshow maintainer if so interested, as well! :) On Sun, Jan 2, 2022 at 2:50 AM Diederick Niehorster <dcnieho@gmail.com> wrote: > > These five patches fix two regressions (one crashing bug making dshow > unusable on x86, and one regression introduced by my recent patches due > to which devices that seem to not behave according to spec but worked > fine before my patches could no longer be used. > They furthermore fix three small issues i found looking through the dshow code: 2x needed cleanup not being done, and one where to skip setting format for a pin when its useless. > > new in v2 is fixing of the x86 crash > > Diederick Niehorster (5): > avdevice/dshow: tv_tuner_audio_dialog cleanup missing > avdevice/dshow: proper cleanup of queried media types > avdevice/dshow: fix crash on x86 > avdevice/dshow: only set pin format if wanted > avdevice/dshow: ensure pin's default format is set > > libavdevice/dshow.c | 93 +++++++++++++--------- > libavdevice/dshow_capture.h | 120 ++++++++++++++--------------- > libavdevice/dshow_crossbar.c | 4 + > libavdevice/dshow_enummediatypes.c | 8 +- > libavdevice/dshow_enumpins.c | 8 +- > libavdevice/dshow_filter.c | 24 +++--- > libavdevice/dshow_pin.c | 48 ++++++------ > 7 files changed, 165 insertions(+), 140 deletions(-) > > -- > 2.28.0.windows.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On 2022-01-04 05:02 am, Roger Pack wrote: > These LGTM. Feel free to add yourself as a dshow maintainer if so > interested, as well! :) I assume these need to be pushed too. Gyan > > On Sun, Jan 2, 2022 at 2:50 AM Diederick Niehorster <dcnieho@gmail.com> wrote: >> These five patches fix two regressions (one crashing bug making dshow >> unusable on x86, and one regression introduced by my recent patches due >> to which devices that seem to not behave according to spec but worked >> fine before my patches could no longer be used. >> They furthermore fix three small issues i found looking through the dshow code: 2x needed cleanup not being done, and one where to skip setting format for a pin when its useless. >> >> new in v2 is fixing of the x86 crash >> >> Diederick Niehorster (5): >> avdevice/dshow: tv_tuner_audio_dialog cleanup missing >> avdevice/dshow: proper cleanup of queried media types >> avdevice/dshow: fix crash on x86 >> avdevice/dshow: only set pin format if wanted >> avdevice/dshow: ensure pin's default format is set >> >> libavdevice/dshow.c | 93 +++++++++++++--------- >> libavdevice/dshow_capture.h | 120 ++++++++++++++--------------- >> libavdevice/dshow_crossbar.c | 4 + >> libavdevice/dshow_enummediatypes.c | 8 +- >> libavdevice/dshow_enumpins.c | 8 +- >> libavdevice/dshow_filter.c | 24 +++--- >> libavdevice/dshow_pin.c | 48 ++++++------ >> 7 files changed, 165 insertions(+), 140 deletions(-) >> >> -- >> 2.28.0.windows.1 >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On Tue, Jan 4, 2022 at 5:10 AM Gyan Doshi <ffmpeg@gyani.pro> wrote: > On 2022-01-04 05:02 am, Roger Pack wrote: > > These LGTM. Feel free to add yourself as a dshow maintainer if so > > interested, as well! :) > > I assume these need to be pushed too. Yes thanks, please push. Would be good to get in before the release branch, fixing the regressions. Thanks! Dee
On 2022-01-04 04:06 pm, Diederick C. Niehorster wrote: > On Tue, Jan 4, 2022 at 5:10 AM Gyan Doshi <ffmpeg@gyani.pro> wrote: >> On 2022-01-04 05:02 am, Roger Pack wrote: >>> These LGTM. Feel free to add yourself as a dshow maintainer if so >>> interested, as well! :) >> I assume these need to be pushed too. > Yes thanks, please push. Would be good to get in before the release > branch, fixing the regressions. Too late for that. But I will backport to 5.0 Regards, Gyan
Hi Gyan, On Tue, Jan 4, 2022 at 1:05 PM Gyan Doshi <ffmpeg@gyani.pro> wrote: > > On 2022-01-04 04:06 pm, Diederick C. Niehorster wrote: > > On Tue, Jan 4, 2022 at 5:10 AM Gyan Doshi <ffmpeg@gyani.pro> wrote: > >> On 2022-01-04 05:02 am, Roger Pack wrote: > >>> These LGTM. Feel free to add yourself as a dshow maintainer if so > >>> interested, as well! :) > >> I assume these need to be pushed too. > > Yes thanks, please push. Would be good to get in before the release > > branch, fixing the regressions. > > Too late for that. But I will backport to 5.0 Super! Its still on time for the actual release, thats what matters. Thanks and cheers, Dee
On 2022-01-04 09:58 pm, Diederick C. Niehorster wrote: > Hi Gyan, > > On Tue, Jan 4, 2022 at 1:05 PM Gyan Doshi <ffmpeg@gyani.pro> wrote: >> On 2022-01-04 04:06 pm, Diederick C. Niehorster wrote: >>> On Tue, Jan 4, 2022 at 5:10 AM Gyan Doshi <ffmpeg@gyani.pro> wrote: >>>> On 2022-01-04 05:02 am, Roger Pack wrote: >>>>> These LGTM. Feel free to add yourself as a dshow maintainer if so >>>>> interested, as well! :) >>>> I assume these need to be pushed too. >>> Yes thanks, please push. Would be good to get in before the release >>> branch, fixing the regressions. >> Too late for that. But I will backport to 5.0 > Super! Its still on time for the actual release, thats what matters. Done in both master and release/5.0 Pushed to master as d1f7700133312929d64aaa69ab3a08b5ae171390...e84d8ba44141b55f2b28e0ad3b597d2e7d422336 Regards, Gyan