[FFmpeg-devel,v3,0/8] rewrite avpriv_find_start_code() for clarity

Message ID	20220209032854.565698-1-scott.the.elm@gmail.com
Headers	show Delivered-To: ffmpegpatchwork2@gmail.com Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; From: Scott Theisen <scott.the.elm@gmail.com> To: ffmpeg-devel@ffmpeg.org Date: Tue, 8 Feb 2022 22:28:46 -0500 Message-Id: <20220209032854.565698-1-scott.the.elm@gmail.com> In-Reply-To: <20220201212056.29712-1-scott.the.elm@gmail.com> References: <20220201212056.29712-1-scott.the.elm@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3 0/8] rewrite avpriv_find_start_code() for clarity Precedence: list Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Series	rewrite avpriv_find_start_code() for clarity \| expand [FFmpeg-devel,v3,0/8] rewrite avpriv_find_start_code() for clarity [FFmpeg-devel,v3,1/8] avcodec/startcode.h: create start_code_is_valid() [FFmpeg-devel,v3,2/8] avpriv_find_start_code(): readability enhancement part 1 [FFmpeg-devel,v3,3/8] avpriv_find_start_code(): rewrite while loop [FFmpeg-devel,v3,4/8] avpriv_find_start_code(): rewrite for loop for clarity [FFmpeg-devel,v3,5/8] avpriv_find_start_code(): add doxygen comment and rename a parameter [FFmpeg-devel,v3,6/8] avpriv_find_start_code(): correct type of start_code parameter [FFmpeg-devel,v3,7/8] avpriv_find_start_code(): constify pointer parameters [FFmpeg-devel,v3,8/8] avpriv_find_start_code(): make start_code output only

Message ID

20220209032854.565698-1-scott.the.elm@gmail.com

Headers

Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org
 designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100;
From: Scott Theisen <scott.the.elm@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Date: Tue,  8 Feb 2022 22:28:46 -0500
Message-Id: <20220209032854.565698-1-scott.the.elm@gmail.com>
In-Reply-To: <20220201212056.29712-1-scott.the.elm@gmail.com>
References: <20220201212056.29712-1-scott.the.elm@gmail.com>
MIME-Version: 1.0
Subject: [FFmpeg-devel] [PATCH v3 0/8] rewrite avpriv_find_start_code() for
 clarity
Precedence: list
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>

Series

rewrite avpriv_find_start_code() for clarity | expand

Message

Scott Theisen Feb. 9, 2022, 3:28 a.m. UTC

I have removed most of my added comments.

Rebased to account for Andreas Rheinhardt moving the prototype to
startcode.h.

Per his suggestion, the function signature is now unmodified.
(ff_)mpeg1_find_frame_end() now has a wrapper function preserving
the original behavior allowing start codes across buffer boundaries.

-Scott

Comments

Scott Theisen March 7, 2022, 6:44 p.m. UTC | #1

On 2/8/22 22:28, Scott Theisen wrote:
> I have removed most of my added comments.
>
> Rebased to account for Andreas Rheinhardt moving the prototype to
> startcode.h.
>
> Per his suggestion, the function signature is now unmodified.
> (ff_)mpeg1_find_frame_end() now has a wrapper function preserving
> the original behavior allowing start codes across buffer boundaries.
>
> -Scott
>

Andreas,

Have you had a chance to look at v3?

Thanks,

Scott