mbox series

[FFmpeg-devel,0/3] v2: vaapi: switch 8bit 444 format to VUYX

Message ID 20220820043146.398996-1-philipl@overt.org
Headers show
Series v2: vaapi: switch 8bit 444 format to VUYX | expand

Message

Philip Langdale Aug. 20, 2022, 4:31 a.m. UTC 
After discussion with Mark, I'm switching the preferred format for 8bit
444 content in vaapi to VUYX, which is the alpha-less variant of VUYA.

This format is formally supported by the driver, so we don't even need
to do any fudging.

I am not removing VUYA because we found another use for it, replacing
the previous requirement to use v408[enc|dec] to work with it.

* v2: Fix test update in wrong change
* v3: Remove incorrect alpha flag from pix_fmt

Philip Langdale (3):
  lavu/pixfmt: Introduce VUYX format
  libswscale: add support for VUYX format
  lavc/vaapi: Switch preferred 8bit 444 format to VUYX

 libavcodec/vaapi_decode.c                |  4 ++-
 libavcodec/vaapi_encode.c                |  2 +-
 libavcodec/vaapi_encode_h265.c           |  3 +-
 libavcodec/vaapi_encode_vp9.c            |  3 +-
 libavutil/pixdesc.c                      | 12 ++++++++
 libavutil/pixfmt.h                       |  2 ++
 libavutil/tests/pixfmt_best.c            |  1 +
 libswscale/input.c                       | 10 ++++---
 libswscale/output.c                      | 35 +++++++++++++++++++++---
 libswscale/utils.c                       |  1 +
 tests/ref/fate/filter-pixdesc-vuyx       |  1 +
 tests/ref/fate/filter-pixfmts-copy       |  1 +
 tests/ref/fate/filter-pixfmts-crop       |  1 +
 tests/ref/fate/filter-pixfmts-field      |  1 +
 tests/ref/fate/filter-pixfmts-fieldorder |  1 +
 tests/ref/fate/filter-pixfmts-hflip      |  1 +
 tests/ref/fate/filter-pixfmts-il         |  1 +
 tests/ref/fate/filter-pixfmts-null       |  1 +
 tests/ref/fate/filter-pixfmts-pad        |  1 +
 tests/ref/fate/filter-pixfmts-scale      |  1 +
 tests/ref/fate/filter-pixfmts-transpose  |  1 +
 tests/ref/fate/filter-pixfmts-vflip      |  1 +
 tests/ref/fate/imgutils                  |  1 +
 tests/ref/fate/pixfmt_best               |  2 +-
 tests/ref/fate/sws-pixdesc-query         |  3 ++
 25 files changed, 76 insertions(+), 15 deletions(-)
 create mode 100644 tests/ref/fate/filter-pixdesc-vuyx

Comments

Philip Langdale Aug. 23, 2022, 9:45 p.m. UTC | #1 
On Fri, 19 Aug 2022 21:31:43 -0700
Philip Langdale <philipl@overt.org> wrote:

> After discussion with Mark, I'm switching the preferred format for
> 8bit 444 content in vaapi to VUYX, which is the alpha-less variant of
> VUYA.
> 
> This format is formally supported by the driver, so we don't even need
> to do any fudging.
> 
> I am not removing VUYA because we found another use for it, replacing
> the previous requirement to use v408[enc|dec] to work with it.
> 
> * v2: Fix test update in wrong change
> * v3: Remove incorrect alpha flag from pix_fmt
> 
> Philip Langdale (3):
>   lavu/pixfmt: Introduce VUYX format
>   libswscale: add support for VUYX format
>   lavc/vaapi: Switch preferred 8bit 444 format to VUYX

I will push this in a few days if there are no comments.

--phil
Philip Langdale Aug. 26, 2022, 2:13 a.m. UTC | #2 
On Tue, 23 Aug 2022 14:45:37 -0700
Philip Langdale <philipl@overt.org> wrote:

> On Fri, 19 Aug 2022 21:31:43 -0700
> Philip Langdale <philipl@overt.org> wrote:
> 
> > After discussion with Mark, I'm switching the preferred format for
> > 8bit 444 content in vaapi to VUYX, which is the alpha-less variant
> > of VUYA.
> > 
> > This format is formally supported by the driver, so we don't even
> > need to do any fudging.
> > 
> > I am not removing VUYA because we found another use for it,
> > replacing the previous requirement to use v408[enc|dec] to work
> > with it.
> > 
> > * v2: Fix test update in wrong change
> > * v3: Remove incorrect alpha flag from pix_fmt
> > 
> > Philip Langdale (3):
> >   lavu/pixfmt: Introduce VUYX format
> >   libswscale: add support for VUYX format
> >   lavc/vaapi: Switch preferred 8bit 444 format to VUYX  
> 
> I will push this in a few days if there are no comments.
> 

Pushed.

--phil