mbox series

[FFmpeg-devel,v6,0/3] ffmpeg: add video heartbeat capability to fix_sub_duration

Message ID 20221219073408.11501-1-jeebjp@gmail.com
Headers show
Series ffmpeg: add video heartbeat capability to fix_sub_duration | expand

Message

Jan Ekström Dec. 19, 2022, 7:34 a.m. UTC 
Changes from v5:
 - Rebased things on top of current master (option related code moved to
   ffmpeg_mux_init etc).
 - Added notes in the documentation regarding drawbacks of this option and
   that it should not be utilized in cases where latency of when the subtitle
   event is passed on to output is not relevant.

Jan Ekström (3):
  ffmpeg: refactor post-decoding steps for subtitles into a function
  ffmpeg: move decoded frame counter from after post-processing to
    decode
  ffmpeg: add video heartbeat capability to fix_sub_duration

 doc/ffmpeg.texi                               |  14 ++
 fftools/ffmpeg.c                              | 194 +++++++++++++++---
 fftools/ffmpeg.h                              |   8 +
 fftools/ffmpeg_mux_init.c                     |   4 +
 fftools/ffmpeg_opt.c                          |   5 +
 tests/fate/ffmpeg.mak                         |  14 ++
 .../fate/ffmpeg-fix_sub_duration_heartbeat    |  48 +++++
 7 files changed, 264 insertions(+), 23 deletions(-)
 create mode 100644 tests/ref/fate/ffmpeg-fix_sub_duration_heartbeat

Comments

Jan Ekström Jan. 9, 2023, 3:10 p.m. UTC | #1 
On Mon, Dec 19, 2022 at 9:34 AM Jan Ekström <jeebjp@gmail.com> wrote:
>
> Changes from v5:
>  - Rebased things on top of current master (option related code moved to
>    ffmpeg_mux_init etc).
>  - Added notes in the documentation regarding drawbacks of this option and
>    that it should not be utilized in cases where latency of when the subtitle
>    event is passed on to output is not relevant.
>
> Jan Ekström (3):
>   ffmpeg: refactor post-decoding steps for subtitles into a function
>   ffmpeg: move decoded frame counter from after post-processing to
>     decode
>   ffmpeg: add video heartbeat capability to fix_sub_duration

If there are no further comments, I will start pulling this patch set
in later this week.

Jan