mbox series

[FFmpeg-devel,v3,0/6] webp: add support for animated WebP decoding

Message ID 20230720230752.68246-1-thilo.borgmann@mail.de
Headers show
Series webp: add support for animated WebP decoding | expand

Message

Thilo Borgmann July 20, 2023, 11:07 p.m. UTC
All issues of v2 fixed. Makes tsan happy now as well.

Patch 5/6 is still there for making changes in lavc/webp reviewable but
shall be stashed when pushing.

-Thilo

Josef Zlomek (2):
  libavcodec/webp: add support for animated WebP decoding
  libavformat/webp: add WebP demuxer

Thilo Borgmann (4):
  avcodec/webp: move definitions into header
  avcodec/webp: remove unused definitions
  avcodec/webp_parser: parse each frame into one packet
  avcodec/webp: make init_canvas_frame static

 Changelog                                   |   2 +
 doc/demuxers.texi                           |  28 +
 libavcodec/codec_desc.c                     |   3 +-
 libavcodec/version.h                        |   2 +-
 libavcodec/webp.c                           | 714 +++++++++++++++++--
 libavcodec/webp.h                           |  38 +
 libavcodec/webp_parser.c                    | 130 ++--
 libavformat/Makefile                        |   1 +
 libavformat/allformats.c                    |   1 +
 libavformat/version.h                       |   2 +-
 libavformat/webpdec.c                       | 733 ++++++++++++++++++++
 tests/ref/fate/exif-image-webp              |  12 +-
 tests/ref/fate/webp-rgb-lena-lossless       |   2 +-
 tests/ref/fate/webp-rgb-lena-lossless-rgb24 |   2 +-
 tests/ref/fate/webp-rgb-lossless            |   2 +-
 tests/ref/fate/webp-rgb-lossy-q80           |   2 +-
 tests/ref/fate/webp-rgba-lossless           |   2 +-
 tests/ref/fate/webp-rgba-lossy-q80          |   2 +-
 18 files changed, 1563 insertions(+), 115 deletions(-)
 create mode 100644 libavcodec/webp.h
 create mode 100644 libavformat/webpdec.c

Comments

James Zern July 24, 2023, 8:44 p.m. UTC | #1
On Thu, Jul 20, 2023 at 4:08 PM Thilo Borgmann <thilo.borgmann@mail.de> wrote:
>
> All issues of v2 fixed. Makes tsan happy now as well.
>
> Patch 5/6 is still there for making changes in lavc/webp reviewable but
> shall be stashed when pushing.
>

This looks to fail fate:
https://patchwork.ffmpeg.org/check/83180/
It seems to regress on still images:
https://www.gstatic.com/webp/gallery3/1_webp_a.webp
[webp @ 0x555880fd3040] [IMGUTILS @ 0x7f34f04a8ce0] Picture size 0x0 is invalid

> -Thilo
>
> Josef Zlomek (2):
>   libavcodec/webp: add support for animated WebP decoding
>   libavformat/webp: add WebP demuxer
>
> Thilo Borgmann (4):
>   avcodec/webp: move definitions into header
>   avcodec/webp: remove unused definitions
>   avcodec/webp_parser: parse each frame into one packet
>   avcodec/webp: make init_canvas_frame static
>
>  Changelog                                   |   2 +
>  doc/demuxers.texi                           |  28 +
>  libavcodec/codec_desc.c                     |   3 +-
>  libavcodec/version.h                        |   2 +-
>  libavcodec/webp.c                           | 714 +++++++++++++++++--
>  libavcodec/webp.h                           |  38 +
>  libavcodec/webp_parser.c                    | 130 ++--
>  libavformat/Makefile                        |   1 +
>  libavformat/allformats.c                    |   1 +
>  libavformat/version.h                       |   2 +-
>  libavformat/webpdec.c                       | 733 ++++++++++++++++++++
>  tests/ref/fate/exif-image-webp              |  12 +-
>  tests/ref/fate/webp-rgb-lena-lossless       |   2 +-
>  tests/ref/fate/webp-rgb-lena-lossless-rgb24 |   2 +-
>  tests/ref/fate/webp-rgb-lossless            |   2 +-
>  tests/ref/fate/webp-rgb-lossy-q80           |   2 +-
>  tests/ref/fate/webp-rgba-lossless           |   2 +-
>  tests/ref/fate/webp-rgba-lossy-q80          |   2 +-
>  18 files changed, 1563 insertions(+), 115 deletions(-)
>  create mode 100644 libavcodec/webp.h
>  create mode 100644 libavformat/webpdec.c
>
> --
> 2.37.1 (Apple Git-137.1)
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Thilo Borgmann July 25, 2023, 8:59 a.m. UTC | #2
Am 24.07.23 um 22:44 schrieb James Zern:
> On Thu, Jul 20, 2023 at 4:08 PM Thilo Borgmann <thilo.borgmann@mail.de> wrote:
>>
>> All issues of v2 fixed. Makes tsan happy now as well.
>>
>> Patch 5/6 is still there for making changes in lavc/webp reviewable but
>> shall be stashed when pushing.
>>
> 
> This looks to fail fate:
> https://patchwork.ffmpeg.org/check/83180/
> It seems to regress on still images:
> https://www.gstatic.com/webp/gallery3/1_webp_a.webp
> [webp @ 0x555880fd3040] [IMGUTILS @ 0x7f34f04a8ce0] Picture size 0x0 is invalid

Uh fixed in v4. Time to add another fate test as well.

Thanks,
Thilo