mbox series

[FFmpeg-devel,v7,0/7] webp: add support for animated WebP decoding

Message ID 20231206013505.57654-1-thilo.borgmann@mail.de
Headers show
Series webp: add support for animated WebP decoding | expand

Message

Thilo Borgmann Dec. 6, 2023, 1:34 a.m. UTC 
Still images fixed, includes FATE tests, VP8 decoder decoupled so there are no more data races, fixed more asserts, fixed ffprobe regression.

Patch 5/7 is still there for making changes in lavc/webp reviewable but shall be stashed when pushing.

-Thilo

Josef Zlomek (2):
  libavcodec/webp: add support for animated WebP decoding
  libavformat/webp: add WebP demuxer

Thilo Borgmann (5):
  avcodec/webp: move definitions into header
  avcodec/webp: remove unused definitions
  avcodec/webp_parser: parse each frame into one packet
  avcodec/webp: make init_canvas_frame static
  fate: add test for animated WebP

 Changelog                                   |   2 +
 doc/demuxers.texi                           |  28 +
 libavcodec/codec_desc.c                     |   3 +-
 libavcodec/version.h                        |   2 +-
 libavcodec/webp.c                           | 763 ++++++++++++++++++--
 libavcodec/webp.h                           |  38 +
 libavcodec/webp_parser.c                    | 130 ++--
 libavformat/Makefile                        |   1 +
 libavformat/allformats.c                    |   1 +
 libavformat/version.h                       |   2 +-
 libavformat/webpdec.c                       | 733 +++++++++++++++++++
 tests/fate/image.mak                        |   3 +
 tests/ref/fate/exif-image-webp              |  12 +-
 tests/ref/fate/webp-anim                    |  22 +
 tests/ref/fate/webp-rgb-lena-lossless       |   2 +-
 tests/ref/fate/webp-rgb-lena-lossless-rgb24 |   2 +-
 tests/ref/fate/webp-rgb-lossless            |   2 +-
 tests/ref/fate/webp-rgb-lossy-q80           |   2 +-
 tests/ref/fate/webp-rgba-lossless           |   2 +-
 tests/ref/fate/webp-rgba-lossy-q80          |   2 +-
 20 files changed, 1630 insertions(+), 122 deletions(-)
 create mode 100644 libavcodec/webp.h
 create mode 100644 libavformat/webpdec.c
 create mode 100644 tests/ref/fate/webp-anim

Comments

Michael Niedermayer Dec. 6, 2023, 10:01 p.m. UTC | #1 
On Wed, Dec 06, 2023 at 02:34:58AM +0100, Thilo Borgmann via ffmpeg-devel wrote:
> Still images fixed, includes FATE tests, VP8 decoder decoupled so there are no more data races, fixed more asserts, fixed ffprobe regression.
> 
> Patch 5/7 is still there for making changes in lavc/webp reviewable but shall be stashed when pushing.
> 
> -Thilo
> 
> Josef Zlomek (2):
>   libavcodec/webp: add support for animated WebP decoding
>   libavformat/webp: add WebP demuxer
> 
> Thilo Borgmann (5):
>   avcodec/webp: move definitions into header
>   avcodec/webp: remove unused definitions
>   avcodec/webp_parser: parse each frame into one packet
>   avcodec/webp: make init_canvas_frame static
>   fate: add test for animated WebP

something in this patch leads to new warnings:

./ffmpeg -i fate-suite/exif/image_small.webp -vcodec copy -bitexact  file-4087B.webp
./ffmpeg -i file-4087B.webp -f null -

after this patchset

./ffmpeg -i fate-suite/exif/image_small.webp -vcodec copy -bitexact  file-4087B.webp
./ffmpeg -i file-4087B.webp -f null -
[webp @ 0x55a5284bcb80] EXIF chunk present, but Exif bit not set in the VP8X header

something similar happens with "ALPHA chunk present, but alpha bit not set in the VP8X header"
with ticket 4087/5_webp_a.webp

thx

[...]