mbox series

[FFmpeg-devel,0/1] fate/jpegxl: add multiframe permuted TOC image parser

Message ID 20231209194938.308992-1-leo.izen@gmail.com
Headers show
Series fate/jpegxl: add multiframe permuted TOC image parser | expand

Message

Leo Izen Dec. 9, 2023, 7:49 p.m. UTC
This patch requires a sample that hasn't been uploaded yet. It can be found
at [1] and it should be placed at jxl/orange.jxl once uploaded. It's 262k,
which is not very large, but large enough that I did not want to attach it
to this email.

[1]: https://buzo.us/O.jxl

sample sha256sum: 9288337dc0d37effd1f539d4e20083a8ffed757e486f4098121520c74e8de6f6
sample signature: https://buzo.us/A.asc

Leo Izen (1):
  fate/jpegxl: add multiframe permuted TOC image parser test

 tests/fate/jxl.mak                         |  3 +++
 tests/ref/fate/jxl-multiframe-permuted-toc | 11 +++++++++++
 2 files changed, 14 insertions(+)
 create mode 100644 tests/ref/fate/jxl-multiframe-permuted-toc

Comments

Thilo Borgmann Dec. 9, 2023, 8:25 p.m. UTC | #1
Am 09.12.23 um 20:49 schrieb Leo Izen:
> This patch requires a sample that hasn't been uploaded yet. It can be found
> at [1] and it should be placed at jxl/orange.jxl once uploaded. It's 262k,
> which is not very large, but large enough that I did not want to attach it
> to this email.
> 
> [1]: https://buzo.us/O.jxl
> 
> sample sha256sum: 9288337dc0d37effd1f539d4e20083a8ffed757e486f4098121520c74e8de6f6
> sample signature: https://buzo.us/A.asc

Uploaded.

-Thilo
Andreas Rheinhardt Dec. 10, 2023, 2:07 p.m. UTC | #2
Leo Izen:
> This patch requires a sample that hasn't been uploaded yet. It can be found
> at [1] and it should be placed at jxl/orange.jxl once uploaded. It's 262k,
> which is not very large, but large enough that I did not want to attach it
> to this email.
> 
> [1]: https://buzo.us/O.jxl
> 
> sample sha256sum: 9288337dc0d37effd1f539d4e20083a8ffed757e486f4098121520c74e8de6f6
> sample signature: https://buzo.us/A.asc
> 
> Leo Izen (1):
>   fate/jpegxl: add multiframe permuted TOC image parser test
> 
>  tests/fate/jxl.mak                         |  3 +++
>  tests/ref/fate/jxl-multiframe-permuted-toc | 11 +++++++++++
>  2 files changed, 14 insertions(+)
>  create mode 100644 tests/ref/fate/jxl-multiframe-permuted-toc
> 

I disagree with your assertion that 262k is not very large. Why do you
use a 2400x2400 sample?

- Andreas
Leo Izen Dec. 10, 2023, 2:47 p.m. UTC | #3
On 12/10/23 09:07, Andreas Rheinhardt wrote:
> Leo Izen:
>> This patch requires a sample that hasn't been uploaded yet. It can be found
>> at [1] and it should be placed at jxl/orange.jxl once uploaded. It's 262k,
>> which is not very large, but large enough that I did not want to attach it
>> to this email.
>>
>> [1]: https://buzo.us/O.jxl
>>
>> sample sha256sum: 9288337dc0d37effd1f539d4e20083a8ffed757e486f4098121520c74e8de6f6
>> sample signature: https://buzo.us/A.asc
>>
>> Leo Izen (1):
>>    fate/jpegxl: add multiframe permuted TOC image parser test
>>
>>   tests/fate/jxl.mak                         |  3 +++
>>   tests/ref/fate/jxl-multiframe-permuted-toc | 11 +++++++++++
>>   2 files changed, 14 insertions(+)
>>   create mode 100644 tests/ref/fate/jxl-multiframe-permuted-toc
>>
> 
> I disagree with your assertion that 262k is not very large. Why do you
> use a 2400x2400 sample?
> 

It had to be larger than 2048x2048 to have multiple LF groups in a 
single frame, as that's the LF group size. The images themselves are 
monochrome.

- Leo Izen (Traneptora)